Convert builtin "global" late lints to run per module #113734

cjgillot · 2023-07-15T18:41:25Z

The compiler currently has 4 non-incremental lints:

clashing_extern_declarations;
missing_debug_implementations;
~~unnameable_test_items;~~ changed by Make test harness lint about unnnameable tests. #114414
missing_docs.

Non-incremental lints get reexecuted for each compilation, which is slow. Moreover, those lints are allow-by-default, so run for nothing most of the time. This PR attempts to make them more incremental-friendly.

clashing_extern_declarations is moved to a standalone query.

missing_debug_implementation can use non_blanket_impls_for_ty instead of recomputing it.

missing_docs is harder as it needs to track if there is a doc(hidden) module surrounding. I hack around this using the lint level engine. That's easy to implement and allows to re-enable the lint for a re-exported module, while a more proper solution would reuse the same device as unnameable_test_items.

rustbot · 2023-07-15T18:41:30Z

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

cjgillot · 2023-07-15T18:43:17Z

@bors try @rust-timer queue

bors · 2023-07-15T18:43:26Z

⌛ Trying commit f79296b3077e49380fb3b70761fab33d65e413a0 with merge 48a02fa0c7ccb590217148ef329202c4883e7230...

bors · 2023-07-15T19:58:45Z

☀️ Try build successful - checks-actions
Build commit: 48a02fa0c7ccb590217148ef329202c4883e7230 (48a02fa0c7ccb590217148ef329202c4883e7230)

rust-timer · 2023-07-15T21:15:43Z

Finished benchmarking commit (48a02fa0c7ccb590217148ef329202c4883e7230): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.7%, 1.0%]	4
Improvements ✅ (primary)	-2.2%	[-4.2%, -0.6%]	108
Improvements ✅ (secondary)	-5.2%	[-26.7%, -0.2%]	72
All ❌✅ (primary)	-2.2%	[-4.2%, -0.6%]	108

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[2.5%, 2.5%]	1
Improvements ✅ (primary)	-2.5%	[-6.5%, -0.6%]	95
Improvements ✅ (secondary)	-6.0%	[-13.3%, -0.7%]	62
All ❌✅ (primary)	-2.5%	[-6.5%, -0.6%]	95

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.6%	[-7.1%, -1.5%]	86
Improvements ✅ (secondary)	-7.9%	[-28.2%, -2.1%]	52
All ❌✅ (primary)	-3.6%	[-7.1%, -1.5%]	86

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.2%]	4
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	2
All ❌✅ (primary)	0.1%	[0.1%, 0.2%]	4

Bootstrap: 657.257s -> 656.692s (-0.09%)

cjgillot · 2023-07-16T13:51:45Z

cc @rust-lang/rustdoc for the change to missing docs lint.

src/librustdoc/core.rs

…chenkov Simplify native_libs query Drive-by cleanup I saw while implementing rust-lang#113734

cjgillot · 2023-08-03T08:52:52Z

r? compiler

…trochenkov Make test harness lint about unnnameable tests. Implementation of rust-lang#113734 (comment) About the options suggested in rust-lang#36629 (comment): adding this case to unused_attribute was just more complicated. I'll try to understand a bit more what you had in mind in rust-lang/rfcs#2471 (comment) This was just simpler to do in a standalone PR. I'll remove the corresponding changes from rust-lang#113734 later. r? `@petrochenkov`

petrochenkov · 2023-08-05T05:47:27Z

@bors r

bors · 2023-08-05T05:47:29Z

📌 Commit 905b63d has been approved by petrochenkov

It is now in the queue for this repository.

Make test harness lint about unnnameable tests. Implementation of rust-lang/rust#113734 (comment) About the options suggested in rust-lang/rust#36629 (comment): adding this case to unused_attribute was just more complicated. I'll try to understand a bit more what you had in mind in rust-lang/rfcs#2471 (comment) This was just simpler to do in a standalone PR. I'll remove the corresponding changes from rust-lang/rust#113734 later. r? `@petrochenkov`

bors · 2023-08-05T07:20:19Z

⌛ Testing commit 905b63d with merge 67626b8...

bors · 2023-08-05T09:08:27Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 67626b8 to master...

rust-timer · 2023-08-05T11:36:18Z

Finished benchmarking commit (67626b8): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.4%, 0.8%]	3
Improvements ✅ (primary)	-1.7%	[-3.4%, -0.2%]	88
Improvements ✅ (secondary)	-4.2%	[-26.5%, -0.2%]	85
All ❌✅ (primary)	-1.7%	[-3.4%, -0.2%]	88

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-3.0%	[-8.8%, -0.5%]	105
Improvements ✅ (secondary)	-6.1%	[-12.2%, -0.6%]	66
All ❌✅ (primary)	-3.0%	[-8.8%, -0.5%]	105

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.9%	[-5.3%, -1.7%]	54
Improvements ✅ (secondary)	-8.4%	[-28.8%, -1.1%]	56
All ❌✅ (primary)	-2.9%	[-5.3%, -1.7%]	54

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.1%]	4
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.1%]	4

Bootstrap: 650.338s -> 649.856s (-0.07%)

Kobzol · 2023-08-05T18:27:40Z

Awesome results!

rustbot assigned wesleywiser Jul 15, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 15, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 15, 2023

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 15, 2023

This comment has been minimized.

Sign in to view

cjgillot force-pushed the no-crate-lint branch from a1fe371 to e91cd22 Compare July 15, 2023 22:18

This comment has been minimized.

Sign in to view

cjgillot force-pushed the no-crate-lint branch from e91cd22 to 15c1be5 Compare July 16, 2023 10:05

cjgillot mentioned this pull request Jul 16, 2023

Simplify native_libs query #113754

Merged

GuillaumeGomez reviewed Jul 16, 2023

View reviewed changes

src/librustdoc/core.rs Show resolved Hide resolved

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jul 16, 2023

Rollup merge of rust-lang#113754 - cjgillot:simplify-foreign, r=petro…

1d464c6

…chenkov Simplify native_libs query Drive-by cleanup I saw while implementing rust-lang#113734

cjgillot force-pushed the no-crate-lint branch from 15c1be5 to 2f28f5a Compare July 19, 2023 10:52

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 19, 2023

Rollup merge of rust-lang#113754 - cjgillot:simplify-foreign, r=petro…

b7bd83a

…chenkov Simplify native_libs query Drive-by cleanup I saw while implementing rust-lang#113734

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 19, 2023

Rollup merge of rust-lang#113754 - cjgillot:simplify-foreign, r=petro…

dbb6b1a

…chenkov Simplify native_libs query Drive-by cleanup I saw while implementing rust-lang#113734

rustbot assigned petrochenkov Aug 3, 2023

This comment was marked as resolved.

Sign in to view

cjgillot added 8 commits August 4, 2023 16:09

Querify clashing_extern_declarations lint.

817f45f

Simplify clashing_extern_declarations.

56063ff

Bless ui tests.

6c7054e

Make MissingDebugImplementation a module lint.

53e5fd6

Make MissingDoc a module lint.

7c34f1a

Make rustc internal lints per module.

c0a683a

Add comment for rustdoc overrides.

0edd4f9

Fetch diagnostic item later.

905b63d

cjgillot force-pushed the no-crate-lint branch from 2f28f5a to 905b63d Compare August 4, 2023 16:09

cjgillot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 4, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 5, 2023

bors merged commit 67626b8 into rust-lang:master Aug 5, 2023
12 checks passed

rustbot added this to the 1.73.0 milestone Aug 5, 2023

This was referenced Aug 5, 2023

Add internal lint against Ty == Ty #107393

Closed

Make borrow check results available to Clippy #108328

Closed

rustbot removed the perf-regression Performance regression. label Aug 5, 2023

cjgillot deleted the no-crate-lint branch August 5, 2023 11:59

Alexendoo mentioned this pull request Sep 5, 2023

register_late_mod_pass doesn't visit all attributes #115571

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert builtin "global" late lints to run per module #113734

Convert builtin "global" late lints to run per module #113734

cjgillot commented Jul 15, 2023 •

edited

Loading

rustbot commented Jul 15, 2023

cjgillot commented Jul 15, 2023

This comment has been minimized.

bors commented Jul 15, 2023

This comment has been minimized.

bors commented Jul 15, 2023

This comment has been minimized.

rust-timer commented Jul 15, 2023

This comment has been minimized.

This comment has been minimized.

cjgillot commented Jul 16, 2023

cjgillot commented Aug 3, 2023

This comment was marked as resolved.

petrochenkov commented Aug 5, 2023

bors commented Aug 5, 2023

bors commented Aug 5, 2023

bors commented Aug 5, 2023

rust-timer commented Aug 5, 2023

Kobzol commented Aug 5, 2023

Convert builtin "global" late lints to run per module #113734

Convert builtin "global" late lints to run per module #113734

Conversation

cjgillot commented Jul 15, 2023 • edited Loading

rustbot commented Jul 15, 2023

cjgillot commented Jul 15, 2023

This comment has been minimized.

bors commented Jul 15, 2023

This comment has been minimized.

bors commented Jul 15, 2023

This comment has been minimized.

rust-timer commented Jul 15, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

This comment has been minimized.

This comment has been minimized.

cjgillot commented Jul 16, 2023

cjgillot commented Aug 3, 2023

This comment was marked as resolved.

petrochenkov commented Aug 5, 2023

bors commented Aug 5, 2023

bors commented Aug 5, 2023

bors commented Aug 5, 2023

rust-timer commented Aug 5, 2023

Overall result: ✅ improvements - no action needed

Kobzol commented Aug 5, 2023

cjgillot commented Jul 15, 2023 •

edited

Loading