Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discard default auto trait impls if explicit ones exist (rebase of #85048) #113312

Merged
merged 4 commits into from
Jul 28, 2023
Merged

discard default auto trait impls if explicit ones exist (rebase of #85048) #113312

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift click to select a range
3adedc9
update auto trait handling
lcnr May 7, 2021
b5b3f33
deal with opaque types without cycling
lcnr Jan 19, 2022
944f237
always emit consider `AutoImplCandidates` for them if they don't also…
Ddystopia Jul 4, 2023
3715934
Change the description of `SUSPICIOUS_AUTO_TRAIT_IMPLS`
Ddystopia Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Change the description of SUSPICIOUS_AUTO_TRAIT_IMPLS
  • Loading branch information
@Ddystopia
Ddystopia committed Jul 28, 2023
commit 37159345a74797316deb0b6f911d48b7243bba77
6 changes: 3 additions & 3 deletions compiler/rustc_lint_defs/src/builtin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4052,12 4052,12 @@ declare_lint! {
///
/// The compiler disables the automatic implementation if an explicit one
/// exists for given type constructor. The exact rules governing this
/// are currently unsound, quite subtle, and will be modified in the future.
/// This change will cause the automatic implementation to be disabled in more
/// were previously unsound, quite subtle, and have been recently modified.
/// This change caused the automatic implementation to be disabled in more
/// cases, potentially breaking some code.
pub SUSPICIOUS_AUTO_TRAIT_IMPLS,
Warn,
"the rules governing auto traits will change in the future",
"the rules governing auto traits have recently changed resulting in potential breakage",
@future_incompatible = FutureIncompatibleInfo {
reason: FutureIncompatibilityReason::FutureReleaseSemanticsChange,
reference: "issue #93367 <https://github.com/rust-lang/rust/issues/93367>",
Expand Down
Loading