Improve `invalid_reference_casting` lint #112431

Urgau · 2023-06-08T19:11:56Z

This PR is a follow-up to #111567 and #113422.

This PR does multiple things:

First it adds support for deferred de-reference, the goal is to support code like this, where the casting and de-reference are not done on the same expression
```
let myself = self as *const Self as *mut Self;
*myself = Self::Ready(value);
```
Second it does not lint anymore on SB/TB UB code by only checking assignments (=, =, ...) and creation of mutable references &mut *
Thirdly it greatly improves the diagnostics in particular for cast from &mut to &mut or assignments
~~And lastly it renames the lint from cast_ref_to_mut to invalid_reference_casting which is more consistent with the "rules" and also more consistent with what the lint checks~~ Rename and allow cast_ref_to_mut lint #113422

This PR is best reviewed commit by commit.

r? compiler

rustbot · 2023-06-08T19:12:04Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

rustbot · 2023-06-08T21:17:31Z

The Miri subtree was changed

cc @rust-lang/miri

Urgau · 2023-06-20T15:07:44Z

r? compiler

bors · 2023-06-29T14:29:36Z

☔ The latest upstream changes (presumably #113151) made this pull request unmergeable. Please resolve the merge conflicts.

tests/ui/lint/cast_ref_to_mut.rs

eholk · 2023-06-29T23:16:02Z

For the SB comments, is the idea that these are UB per Stacked Borrows, but not necessarily actually UB? For example, are these examples allowed under Tree Borrows?

Urgau · 2023-06-30T07:32:26Z

For the SB comments, is the idea that these are UB per Stacked Borrows, but not necessarily actually UB?

Yes, those are UB under Stacked Borrows. As to when ever those are actually UB, I have no idea.

For example, are these examples allowed under Tree Borrows?

Maybe, I don't know and it shouldn't matter. Neither Stacked Borrows or Tree Borrows are official, so we shouldn't strive for either of them.

There is another thing to take into account, when uplifting the lint T-lang only officially approved linting for &T -> &mut T casts, so checking for anything more is already borderline.

With this PR only &T -> &mut T and *(&T -> &mut T) = ... are linted against instead of everything that de-reference the result of an immutable-ref to (mut/const) pointer casting.

compiler/rustc_lint/src/reference_casting.rs

bors · 2023-07-02T18:33:30Z

☔ The latest upstream changes (presumably #113260) made this pull request unmergeable. Please resolve the merge conflicts.

Urgau · 2023-07-03T16:40:06Z

r? @Nilstrieb (per Zulip discussion)

Nilstrieb

I have some feedback and a question around UnsafeCell.

The original PR will land in 1.72.0 (nightly, beta in a few days). The rename should really get into the same release, so can you split it out into a separate PR to avoid it being caught up in bikeshedding here?

Nilstrieb · 2023-07-06T18:23:57Z

library/core/src/cell.rs

@@ -1893,7 1893,8 @@ impl<T: ?Sized fmt::Display> fmt::Display for RefMut<'_, T> {
 /// on an _exclusive_ `UnsafeCell<T>`. Even though `T` and `UnsafeCell<T>` have the
 /// same memory layout, the following is not allowed and undefined behavior:
 ///
-/// ```rust,no_run
+#[cfg_attr(bootstrap, doc = "```rust,no_run")]
+#[cfg_attr(not(bootstrap), doc = "```rust,compile_fail")]


This is an interesting case. It's a UB example but it's also something that's fine in both SB and TB as they don't care about get at all, so it seems likely to be fine in the future. Avoiding to lint here is quite easy by just checking whether the pointee has interior mutability with !pointee.is_freeze(), but I'm afraid that this would cause the lint to miss more subtle cases where the type has interior mutability somewhere deeply nested.
@RalfJung what's your opinion on this here? Should the compiler emit a deny-by-default lint on this code below?

I am totally fine with linting against this, calling get is a lot more clear and the docs for UnsafeCell explicitly say this is UB. It might be "just" library UB instead of language UB, but that's still good enough to justify a lint IMO. We can always revisit this once we have an official aliasing model.

compiler/rustc_lint/src/reference_casting.rs

Urgau · 2023-07-29T11:10:22Z

#113422 has now been merged. I've rebased. This PR is no longer blocked and is ready for another review.

@rustbot label: -S-blocked S-waiting-on-review

Rename and allow `cast_ref_to_mut` lint This PR is a small subset of rust-lang/rust#112431, that is the renaming of the lint (`cast_ref_to_mut` -> `invalid_reference_casting`). BUT also temporarily change the default level of the lint from deny-by-default to allow-by-default until rust-lang/rust#112431 is merged. r? `@Nilstrieb`

Nilstrieb · 2023-08-02T10:54:53Z

@bors r

bors · 2023-08-02T10:54:56Z

📌 Commit 507d497 has been approved by Nilstrieb

It is now in the queue for this repository.

bors · 2023-08-02T11:25:16Z

⌛ Testing commit 507d497 with merge d170833...

bors · 2023-08-02T13:38:29Z

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing d170833 to master...

rust-timer · 2023-08-03T03:07:18Z

Finished benchmarking commit (d170833): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.4%	[0.4%, 0.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	2
Improvements ✅ (secondary)	-3.6%	[-4.6%, -2.5%]	2
All ❌✅ (primary)	-2.2%	[-2.2%, -2.2%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 647.763s -> 648.737s (0.15%)

Rename and allow `cast_ref_to_mut` lint This PR is a small subset of rust-lang/rust#112431, that is the renaming of the lint (`cast_ref_to_mut` -> `invalid_reference_casting`). BUT also temporarily change the default level of the lint from deny-by-default to allow-by-default until rust-lang/rust#112431 is merged. r? `@Nilstrieb`

Language -------- - [Uplift `clippy::fn_null_check` lint as `useless_ptr_null_checks`.] (rust-lang/rust#111717) - [Make `noop_method_call` warn by default.] (rust-lang/rust#111916) - [Support interpolated block for `try` and `async` in macros.] (rust-lang/rust#112953) - [Make `unconditional_recursion` lint detect recursive drops.] (rust-lang/rust#113902) - [Future compatibility warning for some impls being incorrectly considered not overlapping.] (rust-lang/rust#114023) - [The `invalid_reference_casting` lint is now **deny-by-default** (instead of allow-by-default)] (rust-lang/rust#112431) Compiler -------- - [Write version information in a `.comment` section like GCC/Clang.] (rust-lang/rust#97550) - [Add documentation on v0 symbol mangling.] (rust-lang/rust#97571) - [Stabilize `extern "thiscall"` and `"thiscall-unwind"` ABIs.] (rust-lang/rust#114562) - [Only check outlives goals on impl compared to trait.] (rust-lang/rust#109356) - [Infer type in irrefutable slice patterns with fixed length as array.] (rust-lang/rust#113199) - [Discard default auto trait impls if explicit ones exist.] (rust-lang/rust#113312) - Add several new tier 3 targets: - [`aarch64-unknown-teeos`] (rust-lang/rust#113480) - [`csky-unknown-linux-gnuabiv2`] (rust-lang/rust#113658) - [`riscv64-linux-android`] (rust-lang/rust#112858) - [`riscv64gc-unknown-hermit`] (rust-lang/rust#114004) - [`x86_64-unikraft-linux-musl`] (rust-lang/rust#113411) - [`x86_64-unknown-linux-ohos`] (rust-lang/rust#113061) - [Add `wasm32-wasi-preview1-threads` as a tier 2 target.] (rust-lang/rust#112922) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Add `Read`, `Write` and `Seek` impls for `Arc<File>`.] (rust-lang/rust#94748) - [Merge functionality of `io::Sink` into `io::Empty`.] (rust-lang/rust#98154) - [Implement `RefUnwindSafe` for `Backtrace`] (rust-lang/rust#100455) - [Make `ExitStatus` implement `Default`] (rust-lang/rust#106425) - [`impl SliceIndex<str> for (Bound<usize>, Bound<usize>)`] (rust-lang/rust#111081) - [Change default panic handler message format.] (rust-lang/rust#112849) - [Cleaner `assert_eq!` & `assert_ne!` panic messages.] (rust-lang/rust#111071) - [Correct the (deprecated) Android `stat` struct definitions.] (rust-lang/rust#113130) Stabilized APIs --------------- - [Unsigned `{integer}::div_ceil`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.div_ceil) - [Unsigned `{integer}::next_multiple_of`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.next_multiple_of) - [Unsigned `{integer}::checked_next_multiple_of`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.checked_next_multiple_of) - [`std::ffi::FromBytesUntilNulError`] (https://doc.rust-lang.org/stable/std/ffi/struct.FromBytesUntilNulError.html) - [`std::os::unix::fs::chown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.chown.html) - [`std::os::unix::fs::fchown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.fchown.html) - [`std::os::unix::fs::lfchown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.lchown.html) - [`LocalKey::<Cell<T>>::get`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.get) - [`LocalKey::<Cell<T>>::set`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.set) - [`LocalKey::<Cell<T>>::take`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.take) - [`LocalKey::<Cell<T>>::replace`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.replace) - [`LocalKey::<RefCell<T>>::with_borrow`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.with_borrow) - [`LocalKey::<RefCell<T>>::with_borrow_mut`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.with_borrow_mut) - [`LocalKey::<RefCell<T>>::set`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.set-1) - [`LocalKey::<RefCell<T>>::take`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.take-1) - [`LocalKey::<RefCell<T>>::replace`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.replace-1) These APIs are now stable in const contexts: - [`rc::Weak::new`] (https://doc.rust-lang.org/stable/alloc/rc/struct.Weak.html#method.new) - [`sync::Weak::new`] (https://doc.rust-lang.org/stable/alloc/sync/struct.Weak.html#method.new) - [`NonNull::as_ref`] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.as_ref) Cargo ----- - [Encode URL params correctly for `SourceId` in `Cargo.lock`.] (rust-lang/cargo#12280) - [Bail out an error when using `cargo::` in custom build script.] (rust-lang/cargo#12332) Compatibility Notes ------------------- - [Update the minimum external LLVM to 15.] (rust-lang/rust#114148) - [Check for non-defining uses of return position `impl Trait`.] (rust-lang/rust#112842) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Remove LLVM pointee types, supporting only opaque pointers.] (rust-lang/rust#105545) - [Port PGO/LTO/BOLT optimized build pipeline to Rust.] (rust-lang/rust#112235) - [Replace in-tree `rustc_apfloat` with the new version of the crate.] (rust-lang/rust#113843) - [Update to LLVM 17.] (rust-lang/rust#114048) - [Add `internal_features` lint for internal unstable features.] (rust-lang/rust#108955) - [Mention style for new syntax in tracking issue template.] (rust-lang/rust#113586)

Pkgsrc changes: * Adjust patches and cargo checksums to new versions. * For an external LLVM, set dependency of llvm >= 15, in accordance with the upstream changes. * Add a patch with a backport from LLVM 17.0.3 fixing codegen for PPC, ref. rust-lang/rust#116845 Upstream changes: Version 1.73.0 (2023-10-05) ========================== Language -------- - [Uplift `clippy::fn_null_check` lint as `useless_ptr_null_checks`.] (rust-lang/rust#111717) - [Make `noop_method_call` warn by default.] (rust-lang/rust#111916) - [Support interpolated block for `try` and `async` in macros.] (rust-lang/rust#112953) - [Make `unconditional_recursion` lint detect recursive drops.] (rust-lang/rust#113902) - [Future compatibility warning for some impls being incorrectly considered not overlapping.] (rust-lang/rust#114023) - [The `invalid_reference_casting` lint is now **deny-by-default** (instead of allow-by-default)] (rust-lang/rust#112431 Compiler -------- - [Write version information in a `.comment` section like GCC/Clang.] (rust-lang/rust#97550) - [Add documentation on v0 symbol mangling.] (rust-lang/rust#97571) - [Stabilize `extern "thiscall"` and `"thiscall-unwind"` ABIs.] (rust-lang/rust#114562) - [Only check outlives goals on impl compared to trait.] (rust-lang/rust#109356) - [Infer type in irrefutable slice patterns with fixed length as array.] (rust-lang/rust#113199) - [Discard default auto trait impls if explicit ones exist.] (rust-lang/rust#113312) - Add several new tier 3 targets: - [`aarch64-unknown-teeos`] (rust-lang/rust#113480) - [`csky-unknown-linux-gnuabiv2`] (rust-lang/rust#113658) - [`riscv64-linux-android`] (rust-lang/rust#112858) - [`riscv64gc-unknown-hermit`] (rust-lang/rust#114004) - [`x86_64-unikraft-linux-musl`] (rust-lang/rust#113411) - [`x86_64-unknown-linux-ohos`] (rust-lang/rust#113061) - [Add `wasm32-wasi-preview1-threads` as a tier 2 target.] (rust-lang/rust#112922) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Add `Read`, `Write` and `Seek` impls for `Arc<File>`.] (rust-lang/rust#94748) - [Merge functionality of `io::Sink` into `io::Empty`.] (rust-lang/rust#98154) - [Implement `RefUnwindSafe` for `Backtrace`] (rust-lang/rust#100455) - [Make `ExitStatus` implement `Default`] (rust-lang/rust#106425) - [`impl SliceIndex<str> for (Bound<usize>, Bound<usize>)`] (rust-lang/rust#111081) - [Change default panic handler message format.] (rust-lang/rust#112849) - [Cleaner `assert_eq!` & `assert_ne!` panic messages.] (rust-lang/rust#111071) - [Correct the (deprecated) Android `stat` struct definitions.] (rust-lang/rust#113130) Stabilized APIs --------------- - [Unsigned `{integer}::div_ceil`] (https://doc.rust-lang.org/stable/std/primitiv e.u32.html#method.div_ceil) - [Unsigned `{integer}::next_multiple_of`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.next_multiple_of) - [Unsigned `{integer}::checked_next_multiple_of`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.checked_next_multiple_of) - [`std::ffi::FromBytesUntilNulError`] (https://doc.rust-lang.org/stable/std/ffi/struct.FromBytesUntilNulError.html) - [`std::os::unix::fs::chown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.chown.html) - [`std::os::unix::fs::fchown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.fchown.html) - [`std::os::unix::fs::lfchown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.lchown.html) - [`LocalKey::<Cell<T>>::get`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.get) - [`LocalKey::<Cell<T>>::set`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.set) - [`LocalKey::<Cell<T>>::take`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.take) - [`LocalKey::<Cell<T>>::replace`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.replace) - [`LocalKey::<RefCell<T>>::with_borrow`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.with_borrow) - [`LocalKey::<RefCell<T>>::with_borrow_mut`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.with_borrow_mut) - [`LocalKey::<RefCell<T>>::set`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.set-1) - [`LocalKey::<RefCell<T>>::take`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.take-1) - [`LocalKey::<RefCell<T>>::replace`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.replace-1) These APIs are now stable in const contexts: - [`rc::Weak::new`] (https://doc.rust-lang.org/stable/alloc/rc/struct.Weak.html#method.new) - [`sync::Weak::new`] (https://doc.rust-lang.org/stable/alloc/sync/struct.Weak.html#method.new) - [`NonNull::as_ref`] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.as_ref) Cargo ----- - [Encode URL params correctly for `SourceId` in `Cargo.lock`.] (rust-lang/cargo#12280) - [Bail out an error when using `cargo::` in custom build script.] (rust-lang/cargo#12332) Misc ---- Compatibility Notes ------------------- - [Update the minimum external LLVM to 15.] (rust-lang/rust#114148) - [Check for non-defining uses of return position `impl Trait`.] (rust-lang/rust#112842) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Remove LLVM pointee types, supporting only opaque pointers.] (rust-lang/rust#105545) - [Port PGO/LTO/BOLT optimized build pipeline to Rust.] (rust-lang/rust#112235) - [Replace in-tree `rustc_apfloat` with the new version of the crate.] (rust-lang/rust#113843) - [Update to LLVM 17.] (rust-lang/rust#114048) - [Add `internal_features` lint for internal unstable features.] (rust-lang/rust#108955) - [Mention style for new syntax in tracking issue template.] (rust-lang/rust#113586)

Rename and allow `cast_ref_to_mut` lint This PR is a small subset of rust-lang/rust#112431, that is the renaming of the lint (`cast_ref_to_mut` -> `invalid_reference_casting`). BUT also temporarily change the default level of the lint from deny-by-default to allow-by-default until rust-lang/rust#112431 is merged. r? `@Nilstrieb`

rustbot assigned eholk Jun 8, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 8, 2023

This comment has been minimized.

Sign in to view

Urgau force-pushed the cast_ref_to_mut_improvments branch 2 times, most recently from 54bef35 to 01cb874 Compare June 8, 2023 21:17

Urgau force-pushed the cast_ref_to_mut_improvments branch 2 times, most recently from c9956a9 to fc7e634 Compare June 10, 2023 17:32

rustbot assigned jackh726 and unassigned eholk Jun 20, 2023

Urgau force-pushed the cast_ref_to_mut_improvments branch from add632a to 1f84677 Compare June 29, 2023 15:39

This comment has been minimized.

Sign in to view

Urgau force-pushed the cast_ref_to_mut_improvments branch from 1f84677 to 7ec9794 Compare June 29, 2023 16:27

eholk reviewed Jun 29, 2023

View reviewed changes

tests/ui/lint/cast_ref_to_mut.rs Outdated Show resolved Hide resolved

WaffleLapkin reviewed Jun 30, 2023

View reviewed changes

compiler/rustc_lint/src/reference_casting.rs Outdated Show resolved Hide resolved

Urgau force-pushed the cast_ref_to_mut_improvments branch from 7ec9794 to 85fac39 Compare June 30, 2023 22:02

Urgau force-pushed the cast_ref_to_mut_improvments branch from 85fac39 to c68706f Compare July 2, 2023 19:31

rustbot assigned Nilstrieb and unassigned jackh726 Jul 3, 2023

Nilstrieb requested changes Jul 6, 2023

View reviewed changes

Urgau mentioned this pull request Jul 6, 2023

Rename and allow cast_ref_to_mut lint #113422

Merged

Urgau added 2 commits July 29, 2023 12:20

Improve diagnostics of the invalid_reference_casting lint

20a6b57

Adjust some tests for invalid_reference_casting improvements

507d497

Urgau force-pushed the cast_ref_to_mut_improvments branch from 9724a74 to 507d497 Compare July 29, 2023 10:37

Urgau changed the title ~~Improve cast_ref_to_mut lint~~ Improve invalid_reference_casting lint Jul 29, 2023

rustbot removed the S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. label Jul 29, 2023

Nilstrieb approved these changes Aug 2, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 2, 2023

bors merged commit d170833 into rust-lang:master Aug 2, 2023
12 checks passed

rustbot added this to the 1.73.0 milestone Aug 2, 2023

Urgau deleted the cast_ref_to_mut_improvments branch August 2, 2023 13:42

bors mentioned this pull request Aug 2, 2023

Add allow-by-default lint for unit bindings #112380

Merged

Urgau mentioned this pull request Aug 2, 2023

Crate does not compile with latest beta jabuwu/rusty_spine#13

Closed

Urgau mentioned this pull request Aug 22, 2023

Uplift clippy::cast_ref_to_mut lint #111567

Merged

cuviper mentioned this pull request Aug 23, 2023

Announcing Rust 1.72.0 rust-lang/blog.rust-lang.org#1129

Merged

LegionMammal978 mentioned this pull request Oct 4, 2023

invalid_reference_casting lint catches some patterns that aren't UB #116410

Open

JanekGraff mentioned this pull request Nov 24, 2023

Fix compilation error in spi.rs for rust Version 1.73 stm32-rs/stm32f0xx-hal#170

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve `invalid_reference_casting` lint #112431

Improve `invalid_reference_casting` lint #112431

Urgau commented Jun 8, 2023 •

edited

Loading

rustbot commented Jun 8, 2023

This comment has been minimized.

This comment has been minimized.

rustbot commented Jun 8, 2023

Urgau commented Jun 20, 2023

bors commented Jun 29, 2023

This comment has been minimized.

eholk commented Jun 29, 2023

Urgau commented Jun 30, 2023

bors commented Jul 2, 2023

Urgau commented Jul 3, 2023

Nilstrieb left a comment

Nilstrieb Jul 6, 2023

RalfJung Jul 7, 2023

Urgau commented Jul 29, 2023

Nilstrieb commented Aug 2, 2023

bors commented Aug 2, 2023

bors commented Aug 2, 2023

bors commented Aug 2, 2023

rust-timer commented Aug 3, 2023

Improve invalid_reference_casting lint #112431

Improve invalid_reference_casting lint #112431

Conversation

Urgau commented Jun 8, 2023 • edited Loading

rustbot commented Jun 8, 2023

This comment has been minimized.

This comment has been minimized.

rustbot commented Jun 8, 2023

Urgau commented Jun 20, 2023

bors commented Jun 29, 2023

This comment has been minimized.

eholk commented Jun 29, 2023

Urgau commented Jun 30, 2023

bors commented Jul 2, 2023

Urgau commented Jul 3, 2023

Nilstrieb left a comment

Choose a reason for hiding this comment

Nilstrieb Jul 6, 2023

Choose a reason for hiding this comment

RalfJung Jul 7, 2023

Choose a reason for hiding this comment

Urgau commented Jul 29, 2023

Nilstrieb commented Aug 2, 2023

bors commented Aug 2, 2023

bors commented Aug 2, 2023

bors commented Aug 2, 2023

rust-timer commented Aug 3, 2023

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Improve `invalid_reference_casting` lint #112431

Improve `invalid_reference_casting` lint #112431

Urgau commented Jun 8, 2023 •

edited

Loading