libsyntax: ext cleanup #11168
Merged
libsyntax: ext cleanup #11168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r from me, but pcwalton should probably take a look and figure out how to reconcile the de-@-mut-ing |
|
I've gone ahead and removed all of the |
|
Don't worry about conflicting with me; I'll clean up my end. Thanks so much! |
bors
added a commit
that referenced
this pull request
Dec 30, 2013
* Pass `&ExtCtxt` instead of `@ExtCtxt`. * Stop passing duplicate parameters around in `expand`. * Make `ast_fold` methods take `&mut self`. After these, it should be possible to remove the `@mut` boxes from `ExtCtxt` altogether, though #11167 is doing some of that so I'm holding off on that for now. This will probably conflict with that PR, so I'm guessing that one will have to be rebased on top of the other. r? @pcwalton
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 31, 2023
…1995 Update bug URL to use the ice template The previous URL linked to the blank new issue from without any template. This will now link to the ICE template :) * Before: https://github.com/rust-lang/rust-clippy/issues/new * After: https://github.com/rust-lang/rust-clippy/issues/new?template=ice.yml That's it, nothing too interesting besides that. For everyone reading this: here, have some free cream 🍨 🍦 and have a beautiful day. 🙃 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
&ExtCtxtinstead of@ExtCtxt.expand.ast_foldmethods take&mut self.After these, it should be possible to remove the
@mutboxes fromExtCtxtaltogether, though #11167 is doing some of that so I'm holding off on that for now. This will probably conflict with that PR, so I'm guessing that one will have to be rebased on top of the other.r? @pcwalton