Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #110919

Merged
merged 20 commits into from
Apr 28, 2023
Merged

Rollup of 7 pull requests #110919

merged 20 commits into from
Apr 28, 2023

Conversation

JohnTitor
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Lukas Markeffsky and others added 20 commits April 25, 2023 18:11
It exists and is pretty cool. More people should use it.
…gure, r=albertlarsan68

configure --set support list as arguments

Fixes rust-lang#109316

r? `@jyn514`
…d, r=thomcc

Document `const {}` syntax for `std::thread_local`.

It exists and is pretty cool. More people should use it.

It was added in rust-lang#83416 and stabilized in rust-lang#91355 with the tracking issue rust-lang#84223.
format panic message only once

Formatting the panic message multiple times can cause problems for some real-world crates, so here's a test to ensure that we don't do that.

This was regressed in rust-lang#109507 and reverted in rust-lang#110782.

fixes rust-lang#110717
fixes rust-itertools/itertools#694
refactor(docs): remove macro resolution fallback

close rust-lang#110879

r?`@jyn514`
…ler-errors

remove inline const deadcode in typeck

inline consts get typeck'd with their parent so this is not reachable
…-key, r=cuviper

Remove unused std::sys_common::thread_local_key::Key

Part of rust-lang#110897

This `Key` type seems unused. Let's remove it and see if anything explodes. :)
…rwin, r=jyn514

Skip `rustc` version detection on macOS

Fixes rust-lang#104723
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Apr 28, 2023
@JohnTitor
Copy link
Member Author

@bors r p=7 rollup=never

@bors
Copy link
Contributor

bors commented Apr 28, 2023

📌 Commit 00b9ce5 has been approved by JohnTitor

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2023
@bors
Copy link
Contributor

bors commented Apr 28, 2023

⌛ Testing commit 00b9ce5 with merge 033aa09...

@bors
Copy link
Contributor

bors commented Apr 28, 2023

☀️ Test successful - checks-actions
Approved by: JohnTitor
Pushing 033aa09 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 28, 2023
@bors bors merged commit 033aa09 into rust-lang:master Apr 28, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 28, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha
#110909 527f184228cbf64c10618c83edfe1bc25ae58009
#110898 7bfe0df0201829a2083ccbe51cc9f1cde435eb02
#110893 19085a0ba74ef9ff9811cbf8b291537bc93ce27d
#110881 585367d50aceac955784c0899e747dd55cecf938
#110721 56c371691831c102cfdbece3dc8ae5fe1a6bbc24
#110620 1d433212e27b250a62d84483a530a0e872dbeedd
#109702 c6bbdadc2b627819b44eb3931f5d7dcbc355ab60

previous master: 9a3258fa52

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@JohnTitor JohnTitor deleted the rollup-9phs2vx branch April 28, 2023 06:43
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (033aa09): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.5% [-2.9%, -2.2%] 5
All ❌✅ (primary) - - 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants