Don't recover lifetimes/labels containing emojis as character literals #108031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that at the time of this commit, `unic-emoji-char` seems to have data tables only up to Unicode 5.0, but Unicode is already newer than this. A newer emoji such as `🥺` will not be recognized as an emoji but older emojis such as `🐱` will.
|
r? @jackh726 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors r |
bors
added
S-waiting-on-bors
|
r? @estebank |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 18, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#108031 (Don't recover lifetimes/labels containing emojis as character literals) - rust-lang#108046 (Don't allow evaluating queries that were fed in a previous compiler run) - rust-lang#108162 (Don't eagerly convert principal to string) - rust-lang#108186 (Deny non-lifetime bound vars in `for<..> ||` closure binders) - rust-lang#108197 (Update cargo) - rust-lang#108205 (link to llvm changes that prompted the special cases) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Apr 10, 2023
… literals" Reverts PR rust-lang#108031 Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 10, 2023
…avidtwco Revert "Don't recover lifetimes/labels containing emojis as character literals" Reverts PR rust-lang#108031 per rust-lang#109754 (comment) Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Apr 11, 2023
…avidtwco Revert "Don't recover lifetimes/labels containing emojis as character literals" Reverts PR rust-lang#108031 per rust-lang#109754 (comment) Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 11, 2023
…avidtwco Revert "Don't recover lifetimes/labels containing emojis as character literals" Reverts PR rust-lang#108031 per rust-lang#109754 (comment) Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Apr 11, 2023
…avidtwco Revert "Don't recover lifetimes/labels containing emojis as character literals" Reverts PR rust-lang#108031 per rust-lang#109754 (comment) Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 12, 2023
…avidtwco Revert "Don't recover lifetimes/labels containing emojis as character literals" Reverts PR rust-lang#108031 per rust-lang#109754 (comment) Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 16, 2023
… literals" Reverts PR rust-lang#108031 Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
MabezDev
pushed a commit
to esp-rs/rust
that referenced
this pull request
May 16, 2023
… literals" Reverts PR rust-lang#108031 Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108019.
Note that at the time of this commit,
unic-emoji-charseems to have data tables only up to Unicode 5.0, but Unicode is already newer than this.A newer emoji such as
🥺will not be recognized as an emoji but older emojis such as🐱will.This PR leaves a couple of FIXMEs where
unic_emoji_char::is_emojiis used.