Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mem::swap inlinable #107140

Closed
wants to merge 1 commit into from
Closed

Make mem::swap inlinable #107140

wants to merge 1 commit into from

Conversation

saethlin
Copy link
Member

@saethlin saethlin commented Jan 21, 2023 •
edited
Loading

This change makes the MIR for mem::swap much smaller, and makes it inline according to our current heuristics.

Unfortunately it is perf-neutral. Boring.

@rustbot
Copy link
Collaborator

rustbot commented Jan 21, 2023

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 21, 2023
@saethlin
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 21, 2023
@bors
Copy link
Contributor

bors commented Jan 21, 2023

⌛ Trying commit 5292020 with merge ff54912196fda2a700518055910d1968e78dda89...

@bors
Copy link
Contributor

bors commented Jan 21, 2023

☀️ Try build successful - checks-actions
Build commit: ff54912196fda2a700518055910d1968e78dda89 (ff54912196fda2a700518055910d1968e78dda89)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ff54912196fda2a700518055910d1968e78dda89): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.7% [0.7%, 0.7%] 1
Regressions ❌
(secondary)		 5.1% [1.4%, 8.6%] 3
Improvements ✅
(primary)		 -2.3% [-2.3%, -2.3%] 1
Improvements ✅
(secondary)		 -4.3% [-6.3%, -2.4%] 2
All ❌✅ (primary) -0.8% [-2.3%, 0.7%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 25.8% [25.8%, 25.8%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 21, 2023
@saethlin saethlin closed this Jan 21, 2023
@saethlin saethlin deleted the mem-swap-inline-const branch March 15, 2023 00:33
@scottmcm scottmcm mentioned this pull request Mar 16, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 16, 2024
@bors
Auto merge of rust-lang#122582 - scottmcm:swap-intrinsic-v2, r=<try>
3f68c63 
Let codegen decide when to `mem::swap` with immediates

Making `libcore` decide this is silly; the backend has so much better information about when it's a good idea.

Thus this PR introduces a new `typed_swap` intrinsic with a fallback body, and replaces that fallback implementation when swapping immediates or scalar pairs.

r? oli-obk

Replaces rust-lang#111744, and means we'll never need more libs PRs like rust-lang#111803 or rust-lang#107140
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 17, 2024
@bors
Auto merge of rust-lang#122582 - scottmcm:swap-intrinsic-v2, r=<try>
5ad978d 
Let codegen decide when to `mem::swap` with immediates

Making `libcore` decide this is silly; the backend has so much better information about when it's a good idea.

Thus this PR introduces a new `typed_swap` intrinsic with a fallback body, and replaces that fallback implementation when swapping immediates or scalar pairs.

r? oli-obk

Replaces rust-lang#111744, and means we'll never need more libs PRs like rust-lang#111803 or rust-lang#107140
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2024
@bors
Auto merge of rust-lang#122582 - scottmcm:swap-intrinsic-v2, r=oli-obk
f038790 
Let codegen decide when to `mem::swap` with immediates

Making `libcore` decide this is silly; the backend has so much better information about when it's a good idea.

Thus this PR introduces a new `typed_swap` intrinsic with a fallback body, and replaces that fallback implementation when swapping immediates or scalar pairs.

r? oli-obk

Replaces rust-lang#111744, and means we'll never need more libs PRs like rust-lang#111803 or rust-lang#107140
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2024
@bors
Auto merge of rust-lang#122582 - scottmcm:swap-intrinsic-v2, r=oli-obk
ea4d0e9 
Let codegen decide when to `mem::swap` with immediates

Making `libcore` decide this is silly; the backend has so much better information about when it's a good idea.

Thus this PR introduces a new `typed_swap` intrinsic with a fallback body, and replaces that fallback implementation when swapping immediates or scalar pairs.

r? oli-obk

Replaces rust-lang#111744, and means we'll never need more libs PRs like rust-lang#111803 or rust-lang#107140
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2024
@bors
Auto merge of rust-lang#122582 - scottmcm:swap-intrinsic-v2, r=oli-obk
d6eb0f5 
Let codegen decide when to `mem::swap` with immediates

Making `libcore` decide this is silly; the backend has so much better information about when it's a good idea.

Thus this PR introduces a new `typed_swap` intrinsic with a fallback body, and replaces that fallback implementation when swapping immediates or scalar pairs.

r? oli-obk

Replaces rust-lang#111744, and means we'll never need more libs PRs like rust-lang#111803 or rust-lang#107140
RenjiSann pushed a commit to RenjiSann/rust that referenced this pull request Mar 25, 2024
@bors @RenjiSann
Auto merge of rust-lang#122582 - scottmcm:swap-intrinsic-v2, r=oli-obk
66b9b2c 
Let codegen decide when to `mem::swap` with immediates

Making `libcore` decide this is silly; the backend has so much better information about when it's a good idea.

Thus this PR introduces a new `typed_swap` intrinsic with a fallback body, and replaces that fallback implementation when swapping immediates or scalar pairs.

r? oli-obk

Replaces rust-lang#111744, and means we'll never need more libs PRs like rust-lang#111803 or rust-lang#107140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saethlin @rustbot @rust-timer @bors @m-ou-se