Provide help on closures capturing self causing borrow checker errors #106641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
chenyukang
commented
Jan 9, 2023
| } | ||
|
|
||
| for (span, suggest) in finder.closure_call_changes { | ||
| if let Ok(span) = sm.span_extend_while(span, |c| c != '(') { |
There was a problem hiding this comment.
Is there any better solution to get the span for suggestion when there is no argument for a call?
There was a problem hiding this comment.
What you can do when there's no argument is get the span for the whole call
self.foo()
---- self span
--- method path segment span
----- Method span segment
---------- expression span
for function calls is the same: you use the full span and then suggest, instead of "just" "self at this place, you suggest "(self) replacing the (). Does that make sense? It looks worse, but it is more resilient.
There was a problem hiding this comment.
Yes, I updated the code.
chenyukang
force-pushed
the
yukang/fix-105761-segguest-this
branch
2 times, most recently
from
2ce36de
to
80fb856
Compare
|
@bors r |
|
📌 Commit 80fb8561ccfb1bc721942a146a3e04d7c1ce89a5 has been approved by It is now in the queue for this repository. |
|
🌲 The tree is currently closed for pull requests below priority 999. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
rustbot
added
the
S-waiting-on-author
bors
removed
the
S-waiting-on-bors
chenyukang
force-pushed
the
yukang/fix-105761-segguest-this
branch
from
80fb856
to
eafbca9
Compare
|
@bors r |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 13, 2023
…est-this, r=estebank Provide help on closures capturing self causing borrow checker errors Fixes rust-lang#105761 r? `@estebank`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 13, 2023
…est-this, r=estebank Provide help on closures capturing self causing borrow checker errors Fixes rust-lang#105761 r? ``@estebank``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 13, 2023
…est-this, r=estebank Provide help on closures capturing self causing borrow checker errors Fixes rust-lang#105761 r? ```@estebank```
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 13, 2023
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#104645 (Add log-backtrace option to show backtraces along with logging) - rust-lang#106465 (Bump `IMPLIED_BOUNDS_ENTAILMENT` to Deny ReportNow) - rust-lang#106489 (Fix linker detection for linker (drivers) with a version postfix (e.g. clang-12 instead of clang)) - rust-lang#106585 (When suggesting writing a fully qualified path probe for appropriate types) - rust-lang#106641 (Provide help on closures capturing self causing borrow checker errors) - rust-lang#106678 (Warn when using panic-strategy abort for proc-macro crates) - rust-lang#106701 (Fix `mpsc::SyncSender` spinning behavior) - rust-lang#106793 (Normalize test output more thoroughly) - rust-lang#106797 (riscv: Fix ELF header flags) - rust-lang#106813 (Remove redundant session field) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105761
r? @estebank