Fix unsoundness in bootstrap cache code #105624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
T-bootstrap
compiler-errors
force-pushed
the
cache-unsound
branch
2 times, most recently
from
02519f7
to
d8d84d8
Compare
compiler-errors
force-pushed
the
cache-unsound
branch
from
d8d84d8
to
675fa0b
Compare
compiler-errors
commented
Dec 12, 2022
| let l = T::intern_cache().lock().unwrap(); | ||
| unsafe { mem::transmute::<&U, &'static U>(l.get(*self).as_ref()) } | ||
| unsafe { mem::transmute::<&U, &U>(l.get(*self).as_ref()) } |
There was a problem hiding this comment.
We still need to unsafely transmute the lifetime from the temporary borrow on this line to the &self lifetime in the signature.
|
@bors r I want to rip out all this interning code at some point and use a library instead, but this a good change in the meantime, thanks. |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 14, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#105399 (Use more LFS functions.) - rust-lang#105578 (Fix transmutes between pointers in different address spaces (e.g. fn ptrs on AVR)) - rust-lang#105598 (explain mem::forget(env_lock) in fork/exec) - rust-lang#105624 (Fix unsoundness in bootstrap cache code) - rust-lang#105630 (Add a test for rust-lang#92481) - rust-lang#105684 (Improve rustdoc markdown variable naming) - rust-lang#105697 (Remove fee1-dead from reviewers) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
rustbot
added
the
stable-nominated
|
I guess it missed the mark and the nomination can probably be now deleted @rustbot label -stable-nominated |
rustbot
removed
the
stable-nominated
rustbot
added
the
stable-nominated
|
I'm unilaterally approving this for stable backport, to ensure it gets into the next point release for 1.67. @rustbot label: stable-accepted |
rustbot
added
the
stable-accepted
Merged
cuviper
removed
the
stable-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 7, 2023
…crum Release 1.67.1 - Revert back to LlvmArchiveBuilder on all platforms rust-lang#107360 - 🚨 fix unsoundness in bootstrap cache code rust-lang#105624 - Mark uninlined_format_args as pedantic rust-lang/rust-clippy#10265 - Revert "switch to the macos-12-xl builder" rust-lang#107574 r? `@Mark-Simulacrum`
wip-sync
pushed a commit
to NetBSD/pkgsrc-wip
that referenced
this pull request
Feb 12, 2023
Pkgsrc changes: * checksums only. Upstream changes: Version 1.67.1 (2023-02-09) =========================== - [Fix interoperability with thin archives.] (rust-lang/rust#107360) - [Fix an internal error in the compiler build process.] (rust-lang/rust#105624) - [Downgrade `clippy::uninlined_format_args` to pedantic.] (rust-lang/rust-clippy#10265)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered via #105575, which showed that rustc was failing to build during a perf run.