Change `bindings_with_variant_name` to deny-by-default #104154

timrobertsdev · 2022-11-08T15:30:18Z

Changed the bindings_with_variant_name lint to deny-by-default and fixed up the affected tests.

Addresses #103442.

rustbot · 2022-11-08T15:30:26Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) soon.

Please see the contribution instructions for more information.

fmease · 2022-11-08T16:10:09Z

Not sure if I should comment on the issue or here on the PR. In any case, we can't just turn this into a deny-by-default lint without breaking Rust's backward compatibility guarantees, right? This should probably only ever happen in a new edition (e.g. starting from edition 2024) or after marking it as future-incompat and waiting for an extensive period of time. A crater run wouldn't be out of place either, I'd wager.

lcnr · 2022-11-08T16:16:21Z

Crater silently ignores lints from dependencies and having deny by default lints impact the root should be fine, as that's something the user can easily change themselves. Afaik upgrading a lint to deny is therefore generally not considered breaking.

I encountered this lint multiple times myself and iirc I never wanted to continue compilation in these cases as this lint always detected a bug.

I think this requires compiler signoff?

@rfcbot fcp merge

rfcbot · 2022-11-08T16:16:22Z

estebank · 2022-11-08T17:21:57Z

@rfcbot concern proc-macros
How does this lint in particular interact with evaluated proc macros? I could see a weird situation where a clash occurs intentionally on the part of the macro author, but will the link either not trigger at all or only trigger on the macro's users' code?

timrobertsdev · 2022-11-08T18:39:56Z

@estebank
I'm not sure what you had in mind, but I put together this (very) short macro to see:

use proc_macro::TokenStream;
use quote::quote;

#[proc_macro_attribute]
pub fn foo(_input: TokenStream, _attributes: TokenStream) -> TokenStream {
    quote! {
        pub enum Foo {
            Bar,
            Baz,
        }

        pub fn bar(foo: Foo) {
            match foo {
                Bar => {},
                Baz => {},
            }
        }
    }.into()
}

Used as:

use macro_crate::foo;
#[foo]
pub struct Dummy;

Results in no errors being reported when checked or built.

estebank · 2022-11-09T01:44:56Z

@rfcbot resolve proc-macros

scottmcm · 2022-11-27T08:15:02Z

💯. I'm a big fan of this -- warning lints for general smells, but when there are specific situations that we know are essentially always mistakes, they ought to be deny-only.

(FYI @rust-lang/lang that this is happening.)

workingjubilee · 2022-11-27T09:52:38Z

I agree that while technically valid Rust, it is absolutely improbable that anyone should want code that is formed like this to compile. Like "there's over 2 million Rust programmers and I expect less than 5 would want this to work, and they have already found out how to #![allow(nonstandard_style)]".

rfcbot · 2022-12-15T15:08:23Z

🔔 This is now entering its final comment period, as per the review above. 🔔

bors · 2022-12-18T12:27:19Z

☔ The latest upstream changes (presumably #104417) made this pull request unmergeable. Please resolve the merge conflicts.

jhpratt · 2022-12-22T20:15:54Z

Given that this is happening without an edition boundary, should there be a crater run? I suspect there will be minimal breakage, but it's better to be sure.

scottmcm · 2022-12-23T07:33:35Z

Given that this had been a warning for ages and it's so unlikely to be correct code, I think I'm fine with just letting the beta crater run catch any of them.

After all, it's still a lint, not a hard error, so even if it impacts stuff we're still allowed to do it.

nikomatsakis · 2022-12-24T12:43:30Z

@rfcbot fcp reviewed

rfcbot · 2022-12-25T15:15:48Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

scottmcm · 2023-01-18T04:37:07Z

@timrobertsdev Could you rebase this, please? All the tests moved, which impacted a ton of PRs.

(Then we can merge it, since the FCP completed!)

@rustbot author

timrobertsdev · 2023-01-18T21:49:23Z

@scottmcm will do, it'll be a day or two until I can get to a PC to do so

scottmcm · 2023-01-20T08:25:43Z

Thanks, @timrobertsdev! I'm excited to start giving a deny for this.

@bors r

bors · 2023-01-20T08:25:46Z

📌 Commit 1cbce72 has been approved by scottmcm

It is now in the queue for this repository.

…ings_with_variant_name, r=scottmcm Change `bindings_with_variant_name` to deny-by-default Changed the `bindings_with_variant_name` lint to deny-by-default and fixed up the affected tests. Addresses rust-lang#103442.

…mpiler-errors Rollup of 9 pull requests Successful merges: - rust-lang#104154 (Change `bindings_with_variant_name` to deny-by-default) - rust-lang#104347 (diagnostics: suggest changing `s@self::{macro}`@::macro`` for exported) - rust-lang#104672 (Unify stable and unstable sort implementations in same core module) - rust-lang#107048 (check for x version updates) - rust-lang#107061 (Implement some more new solver candidates and fix some bugs) - rust-lang#107095 (rustdoc: remove redundant CSS selector `.sidebar .current`) - rust-lang#107112 (Fix typo in opaque_types.rs) - rust-lang#107124 (fix check macro expansion) - rust-lang#107131 (rustdoc: use CSS inline layout for radio line instead of flexbox) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

Pkgsrc changes: * Adjust patches and cargo checksums to new versions. Upstream changes: Version 1.68.0 (2023-03-09) =========================== Language -------- - [Stabilize default_alloc_error_handler] (rust-lang/rust#102318) This allows usage of `alloc` on stable without requiring the definition of a handler for allocation failure. Defining custom handlers is still unstable. - [Stabilize `efiapi` calling convention.] (rust-lang/rust#105795) - [Remove implicit promotion for types with drop glue] (rust-lang/rust#105085) Compiler -------- - [Change `bindings_with_variant_name` to deny-by-default] (rust-lang/rust#104154) - [Allow .. to be parsed as let initializer] (rust-lang/rust#105701) - [Add `armv7-sony-vita-newlibeabihf` as a tier 3 target] (rust-lang/rust#105712) - [Always check alignment during compile-time const evaluation] (rust-lang/rust#104616) - [Disable "split dwarf inlining" by default.] (rust-lang/rust#106709) - [Add vendor to Fuchsia's target triple] (rust-lang/rust#106429) - [Enable sanitizers for s390x-linux] (rust-lang/rust#107127) Libraries --------- - [Loosen the bound on the Debug implementation of Weak.] (rust-lang/rust#90291) - [Make `std::task::Context` !Send and !Sync] (rust-lang/rust#95985) - [PhantomData layout guarantees] (rust-lang/rust#104081) - [Don't derive Debug for `OnceWith` & `RepeatWith`] (rust-lang/rust#104163) - [Implement DerefMut for PathBuf] (rust-lang/rust#105018) - [Add O(1) `Vec -> VecDeque` conversion guarantee] (rust-lang/rust#105128) - [Leak amplification for peek_mut() to ensure BinaryHeap's invariant is always met] (rust-lang/rust#105851) Stabilized APIs --------------- - [`{core,std}::pin::pin!`] (https://doc.rust-lang.org/stable/std/pin/macro.pin.html) - [`impl From<bool> for {f32,f64}`] (https://doc.rust-lang.org/stable/std/primitive.f32.html#impl-From-for-f32) - [`std::path::MAIN_SEPARATOR_STR`] (https://doc.rust-lang.org/stable/std/path/constant.MAIN_SEPARATOR_STR.html) - [`impl DerefMut for PathBuf`] (https://doc.rust-lang.org/stable/std/path/struct.PathBuf.html#impl-DerefMut-for-PathBuf) These APIs are now stable in const contexts: - [`VecDeque::new`] (https://doc.rust-lang.org/stable/std/collections/struct.VecDeque.html#method.new) Cargo ----- - [Stabilize sparse registry support for crates.io] (rust-lang/cargo#11224) - [`cargo build --verbose` tells you more about why it recompiles.] (rust-lang/cargo#11407) - [Show progress of crates.io index update even `net.git-fetch-with-cli` option enabled] (rust-lang/cargo#11579) Misc ---- Compatibility Notes ------------------- - [Add `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` to future-incompat report] (rust-lang/rust#103418) - [Only specify `--target` by default for `-Zgcc-ld=lld` on wasm] (rust-lang/rust#101792) - [Bump `IMPLIED_BOUNDS_ENTAILMENT` to Deny ReportNow] (rust-lang/rust#106465) - [`std::task::Context` no longer implements Send and Sync] (rust-lang/rust#95985) nternal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Encode spans relative to the enclosing item] (rust-lang/rust#84762) - [Don't normalize in AstConv] (rust-lang/rust#101947) - [Find the right lower bound region in the scenario of partial order relations] (rust-lang/rust#104765) - [Fix impl block in const expr] (rust-lang/rust#104889) - [Check ADT fields for copy implementations considering regions] (rust-lang/rust#105102) - [rustdoc: simplify JS search routine by not messing with lev distance] (rust-lang/rust#105796) - [Enable ThinLTO for rustc on `x86_64-pc-windows-msvc`] (rust-lang/rust#103591) - [Enable ThinLTO for rustc on `x86_64-apple-darwin`] (rust-lang/rust#103647)

Pkgsrc changes: * Adjust patches (add & remove) and cargo checksums to new versions. * It's conceivable that the workaround for LLVM based NetBSD works even less in this version (ref. PKGSRC_HAVE_LIBCPP not having a corresponding patch anymore). Upstream changes: Version 1.68.2 (2023-03-28) =========================== - [Update the GitHub RSA host key bundled within Cargo] (rust-lang/cargo#11883). The key was [rotated by GitHub] (https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/) on 2023-03-24 after the old one leaked. - [Mark the old GitHub RSA host key as revoked] (rust-lang/cargo#11889). This will prevent Cargo from accepting the leaked key even when trusted by the system. - [Add support for `@revoked` and a better error message for `@cert-authority` in Cargo's SSH host key verification] (rust-lang/cargo#11635) Version 1.68.1 (2023-03-23) =========================== - [Fix miscompilation in produced Windows MSVC artifacts] (rust-lang/rust#109094) This was introduced by enabling ThinLTO for the distributed rustc which led to miscompilations in the resulting binary. Currently this is believed to be limited to the -Zdylib-lto flag used for rustc compilation, rather than a general bug in ThinLTO, so only rustc artifacts should be affected. - [Fix --enable-local-rust builds] (rust-lang/rust#109111) - [Treat `$prefix-clang` as `clang` in linker detection code] (rust-lang/rust#109156) - [Fix panic in compiler code] (rust-lang/rust#108162) Version 1.68.0 (2023-03-09) =========================== Language -------- - [Stabilize default_alloc_error_handler] (rust-lang/rust#102318) This allows usage of `alloc` on stable without requiring the definition of a handler for allocation failure. Defining custom handlers is still unstable. - [Stabilize `efiapi` calling convention.] (rust-lang/rust#105795) - [Remove implicit promotion for types with drop glue] (rust-lang/rust#105085) Compiler -------- - [Change `bindings_with_variant_name` to deny-by-default] (rust-lang/rust#104154) - [Allow .. to be parsed as let initializer] (rust-lang/rust#105701) - [Add `armv7-sony-vita-newlibeabihf` as a tier 3 target] (rust-lang/rust#105712) - [Always check alignment during compile-time const evaluation] (rust-lang/rust#104616) - [Disable "split dwarf inlining" by default.] (rust-lang/rust#106709) - [Add vendor to Fuchsia's target triple] (rust-lang/rust#106429) - [Enable sanitizers for s390x-linux] (rust-lang/rust#107127) Libraries --------- - [Loosen the bound on the Debug implementation of Weak.] (rust-lang/rust#90291) - [Make `std::task::Context` !Send and !Sync] (rust-lang/rust#95985) - [PhantomData layout guarantees] (rust-lang/rust#104081) - [Don't derive Debug for `OnceWith` & `RepeatWith`] (rust-lang/rust#104163) - [Implement DerefMut for PathBuf] (rust-lang/rust#105018) - [Add O(1) `Vec -> VecDeque` conversion guarantee] (rust-lang/rust#105128) - [Leak amplification for peek_mut() to ensure BinaryHeap's invariant is always met] (rust-lang/rust#105851) Stabilized APIs --------------- - [`{core,std}::pin::pin!`] (https://doc.rust-lang.org/stable/std/pin/macro.pin.html) - [`impl From<bool> for {f32,f64}`] (https://doc.rust-lang.org/stable/std/primitive.f32.html#impl-From-for-f32) - [`std::path::MAIN_SEPARATOR_STR`] (https://doc.rust-lang.org/stable/std/path/constant.MAIN_SEPARATOR_STR.html) - [`impl DerefMut for PathBuf`] (https://doc.rust-lang.org/stable/std/path/struct.PathBuf.html#impl-DerefMut-for-PathBuf) These APIs are now stable in const contexts: - [`VecDeque::new`] (https://doc.rust-lang.org/stable/std/collections/struct.VecDeque.html#method.new) Cargo ----- - [Stabilize sparse registry support for crates.io] (rust-lang/cargo#11224) - [`cargo build --verbose` tells you more about why it recompiles.] (rust-lang/cargo#11407) - [Show progress of crates.io index update even `net.git-fetch-with-cli` option enabled] (rust-lang/cargo#11579) Misc ---- Compatibility Notes ------------------- - [Add `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` to future-incompat report] (rust-lang/rust#103418) - [Only specify `--target` by default for `-Zgcc-ld=lld` on wasm] (rust-lang/rust#101792) - [Bump `IMPLIED_BOUNDS_ENTAILMENT` to Deny ReportNow] (rust-lang/rust#106465) - [`std::task::Context` no longer implements Send and Sync] (rust-lang/rust#95985) nternal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Encode spans relative to the enclosing item] (rust-lang/rust#84762) - [Don't normalize in AstConv] (rust-lang/rust#101947) - [Find the right lower bound region in the scenario of partial order relations] (rust-lang/rust#104765) - [Fix impl block in const expr] (rust-lang/rust#104889) - [Check ADT fields for copy implementations considering regions] (rust-lang/rust#105102) - [rustdoc: simplify JS search routine by not messing with lev distance] (rust-lang/rust#105796) - [Enable ThinLTO for rustc on `x86_64-pc-windows-msvc`] (rust-lang/rust#103591) - [Enable ThinLTO for rustc on `x86_64-apple-darwin`] (rust-lang/rust#103647) Version 1.67.0 (2023-01-26) ========================== Language -------- - [Make `Sized` predicates coinductive, allowing cycles.] (rust-lang/rust#100386) - [`#[must_use]` annotations on `async fn` also affect the `Future::Output`.] (rust-lang/rust#100633) - [Elaborate supertrait obligations when deducing closure signatures.] (rust-lang/rust#101834) - [Invalid literals are no longer an error under `cfg(FALSE)`.] (rust-lang/rust#102944) - [Unreserve braced enum variants in value namespace.] (rust-lang/rust#103578) Compiler -------- - [Enable varargs support for calling conventions other than `C` or `cdecl`.] (rust-lang/rust#97971) - [Add new MIR constant propagation based on dataflow analysis.] (rust-lang/rust#101168) - [Optimize field ordering by grouping m\*2^n-sized fields with equivalently aligned ones.] (rust-lang/rust#102750) - [Stabilize native library modifier `verbatim`.] (rust-lang/rust#104360) Added and removed targets: - [Add a tier 3 target for PowerPC on AIX] (rust-lang/rust#102293), `powerpc64-ibm-aix`. - [Add a tier 3 target for the Sony PlayStation 1] (rust-lang/rust#102689), `mipsel-sony-psx`. - [Add tier 3 `no_std` targets for the QNX Neutrino RTOS] (rust-lang/rust#102701), `aarch64-unknown-nto-qnx710` and `x86_64-pc-nto-qnx710`. - [Remove tier 3 `linuxkernel` targets] (rust-lang/rust#104015) (not used by the actual kernel). Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Merge `crossbeam-channel` into `std::sync::mpsc`.] (rust-lang/rust#93563) - [Fix inconsistent rounding of 0.5 when formatted to 0 decimal places.] (rust-lang/rust#102935) - [Derive `Eq` and `Hash` for `ControlFlow`.] (rust-lang/rust#103084) - [Don't build `compiler_builtins` with `-C panic=abort`.] (rust-lang/rust#103786) Stabilized APIs --------------- - [`{integer}::checked_ilog`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog) - [`{integer}::checked_ilog2`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog2) - [`{integer}::checked_ilog10`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog10) - [`{integer}::ilog`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog) - [`{integer}::ilog2`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog2) - [`{integer}::ilog10`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog10) - [`NonZeroU*::ilog2`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#method.ilog2) - [`NonZeroU*::ilog10`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#method.ilog10) - [`NonZero*::BITS`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#associatedconstant.BITS) These APIs are now stable in const contexts: - [`char::from_u32`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.from_u32) - [`char::from_digit`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.from_digit) - [`char::to_digit`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_digit) - [`core::char::from_u32`] (https://doc.rust-lang.org/stable/core/char/fn.from_u32.html) - [`core::char::from_digit`] (https://doc.rust-lang.org/stable/core/char/fn.from_digit.html) Compatibility Notes ------------------- - [The layout of `repr(Rust)` types now groups m\*2^n-sized fields with equivalently aligned ones.] (rust-lang/rust#102750) This is intended to be an optimization, but it is also known to increase type sizes in a few cases for the placement of enum tags. As a reminder, the layout of `repr(Rust)` types is an implementation detail, subject to change. - [0.5 now rounds to 0 when formatted to 0 decimal places.] (rust-lang/rust#102935) This makes it consistent with the rest of floating point formatting that rounds ties toward even digits. - [Chains of `&&` and `||` will now drop temporaries from their sub-expressions in evaluation order, left-to-right.] (rust-lang/rust#103293) Previously, it was "twisted" such that the _first_ expression dropped its temporaries _last_, after all of the other expressions dropped in order. - [Underscore suffixes on string literals are now a hard error.] (rust-lang/rust#103914) This has been a future-compatibility warning since 1.20.0. - [Stop passing `-export-dynamic` to `wasm-ld`.] (rust-lang/rust#105405) - [`main` is now mangled as `__main_void` on `wasm32-wasi`.] (rust-lang/rust#105468) - [Cargo now emits an error if there are multiple registries in the configuration with the same index URL.] (rust-lang/cargo#10592) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Rewrite LLVM's archive writer in Rust.] (rust-lang/rust#97485)

chore: Enable linting error for `bindings_with_variant_name` Reference for the lint: https://doc.rust-lang.org/beta/nightly-rustc/rustc_lint/builtin/static.BINDINGS_WITH_VARIANT_NAME.html This lint is currently only a warning on our current Rust version. I recommend turning it into an error. The failure can be quite nasty. Consider this example: ```Rust pub enum PayloadType { Summary, Data } // ... later somewhere let x = PayloadType::Data; match x { Summary => println!("summary"), Data => println!("data"), } ``` Now, in the ic repo, the above code will print "summary", because without the fully-qualified path, Summary is just a bound variable (instead of a sum type variant) **This lint is deny-by-default since Rust 1.68.2 ([this MR](rust-lang/rust#104154)), but we're still on an older version. That's why I suggest we enable it pro-actively.** See merge request dfinity-lab/public/ic!12636

rustbot assigned lcnr Nov 8, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 8, 2022

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Nov 8, 2022

workingjubilee mentioned this pull request Nov 27, 2022

pattern binding **** is named the same as one of the variants of the type SHOULD BE ERROR #104966

Closed

This was linked to issues Nov 27, 2022

pattern binding **** is named the same as one of the variants of the type SHOULD BE ERROR #104966

Closed

Matching field-less enum variants that aren't imported should deny-lint, not just give lots of warnings #103442

Closed

est31 mentioned this pull request Nov 27, 2022

Matching field-less enum variants that aren't imported should deny-lint, not just give lots of warnings #103442

Closed

inquisitivecrystal added relnotes Marks issues that should be documented in the release notes of the next release. needs-fcp This change is insta-stable, so needs a completed FCP to proceed. labels Nov 30, 2022

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Dec 15, 2022

apiraino removed the to-announce Announce this issue on triage meeting label Jan 12, 2023

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2023

scottmcm mentioned this pull request Jan 18, 2023

replace if with match in binary_search #106969

Closed

timrobertsdev added 2 commits January 20, 2023 02:26

Change bindings_with_variant_name to deny-by-default

734f375

Add compile_fail to doctest for bindings_with_variant_name

1cbce72

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 20, 2023

This was referenced Jan 20, 2023

Rollup of 8 pull requests #107132

Closed

Rollup of 9 pull requests #107143

Merged

bors merged commit e640069 into rust-lang:master Jan 21, 2023

rustbot added this to the 1.68.0 milestone Jan 21, 2023

timrobertsdev deleted the deny-by-default-bindings_with_variant_name branch January 22, 2023 01:20

Mark-Simulacrum mentioned this pull request Feb 21, 2023

Deny multiple catch all arms #86677

Closed

mjrogozinski mentioned this pull request Apr 1, 2023

Question 7 requires correction. dtolnay/rust-quiz#71

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change `bindings_with_variant_name` to deny-by-default #104154

Change `bindings_with_variant_name` to deny-by-default #104154

timrobertsdev commented Nov 8, 2022

rustbot commented Nov 8, 2022

fmease commented Nov 8, 2022

lcnr commented Nov 8, 2022

rfcbot commented Nov 8, 2022 •

edited by scottmcm

Loading

estebank commented Nov 8, 2022

timrobertsdev commented Nov 8, 2022

estebank commented Nov 9, 2022

scottmcm commented Nov 27, 2022

workingjubilee commented Nov 27, 2022

rfcbot commented Dec 15, 2022

bors commented Dec 18, 2022

jhpratt commented Dec 22, 2022

scottmcm commented Dec 23, 2022

nikomatsakis commented Dec 24, 2022

rfcbot commented Dec 25, 2022

scottmcm commented Jan 18, 2023

timrobertsdev commented Jan 18, 2023

scottmcm commented Jan 20, 2023

bors commented Jan 20, 2023

Change bindings_with_variant_name to deny-by-default #104154

Change bindings_with_variant_name to deny-by-default #104154

Conversation

timrobertsdev commented Nov 8, 2022

rustbot commented Nov 8, 2022

fmease commented Nov 8, 2022

lcnr commented Nov 8, 2022

rfcbot commented Nov 8, 2022 • edited by scottmcm Loading

estebank commented Nov 8, 2022

timrobertsdev commented Nov 8, 2022

estebank commented Nov 9, 2022

scottmcm commented Nov 27, 2022

workingjubilee commented Nov 27, 2022

rfcbot commented Dec 15, 2022

bors commented Dec 18, 2022

jhpratt commented Dec 22, 2022

scottmcm commented Dec 23, 2022

nikomatsakis commented Dec 24, 2022

rfcbot commented Dec 25, 2022

scottmcm commented Jan 18, 2023

timrobertsdev commented Jan 18, 2023

scottmcm commented Jan 20, 2023

bors commented Jan 20, 2023

Change `bindings_with_variant_name` to deny-by-default #104154

Change `bindings_with_variant_name` to deny-by-default #104154

rfcbot commented Nov 8, 2022 •

edited by scottmcm

Loading