Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland optimized-compiler-builtins config #102579

Closed
wants to merge 2 commits into from
Closed

Reland optimized-compiler-builtins config #102579

wants to merge 2 commits into from

Commits on Dec 25, 2023

  1. add and document a new is_system_llvm abstraction

    @jyn514
    jyn514 committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    b3ebe50 View commit details
    Browse the repository at this point in the history

  2. add a new optimized_compiler_builtins option 

    in particular, this makes the `c` feature for compiler-builtins an explicit opt-in, rather than silently detected by whether `llvm-project` is checked out on disk.
exposing this is necessary because the `cc` crate doesn't support cross-compiling to MSVC, and we want people to be able to run `x check --target foo` regardless of whether they have a c toolchain available.

this also uses the new option in CI, where we *do* want to optimize compiler_builtins.

the new option is off by default for the `dev` channel and on otherwise.
    @jyn514
    jyn514 committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    a10b1be View commit details
    Browse the repository at this point in the history