Prevent usage of .stab elements to create scrollable areas in doc blocks #102100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
changed the title
GuillaumeGomez
force-pushed
the
stab-in-docblocks
branch
from
ffeabd0
to
7495e0d
Compare
notriddle
reviewed
Sep 21, 2022
| // Checking that there is no scrollable content. | ||
| assert-property: ( | ||
| ".top-doc .docblock p:nth-of-type(1)", | ||
| {"scrollHeight": "120", "clientHeight": "120", "scrollWidth": "502", "clientWidth": "502"}, |
There was a problem hiding this comment.
Instead of hard coding the number 502, would it be better to create a fourth paragraph, with no stab tags in it, and use compare-elements-property to assert that they all have the same scroll width?
There was a problem hiding this comment.
That wouldn't be "accurate" as for whatever reasons the size could be different. What I'm currently working on is adding support for variables in browser-ui-test so we can instead directly store either scroll* or client* and then compare to the other ones, so no need for raw numbers like this.
There was a problem hiding this comment.
I created the issue so you can have an idea of what it will look like: GuillaumeGomez/browser-UI-test#351
notriddle
reviewed
Sep 21, 2022
GuillaumeGomez
force-pushed
the
stab-in-docblocks
branch
from
7495e0d
to
6069f71
Compare
|
Fixed the formatting and the invalid CSS selector. |
|
Ah the CI finally restarted. |
|
CI passed \o/ |
|
@bors r rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2022
Rollup of 12 pull requests Successful merges: - rust-lang#101952 (Avoid panicking on missing fallback) - rust-lang#102030 (Don't crate-locally reexport walk functions in tidy) - rust-lang#102032 (Adding ignore fuchsia tests for signal interpretation cases) - rust-lang#102033 (Adding needs-unwind to nicer-assert-messages compiler ui tests) - rust-lang#102054 (Unify "all items" page's sidebar with other pages) - rust-lang#102071 (Adding needs-unwind for tests testing memory size of Futures/Closures) - rust-lang#102073 (Adding ignore fuchsia tests for execvp) - rust-lang#102075 (rustdoc: remove no-op CSS `.content > .methods > .method`) - rust-lang#102079 (Update books) - rust-lang#102084 (Adding needs-unwind for test using panic::catch_unwind) - rust-lang#102100 (Prevent usage of .stab elements to create scrollable areas in doc blocks) - rust-lang#102102 (Add doc aliases on Sized trait) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101874.
You can test it online here.
r? @notriddle