Sunset RLS #100863

ehuss · 2022-08-22T00:27:15Z

This removes RLS per the plan outlined in https://blog.rust-lang.org/2022/07/01/RLS-deprecation.html. This replaces the rls executable with a small program which will display an alert telling the user that RLS is no longer available.

An overview of the changes here:

Removes the rls submodule and replaces it with a small stub program.
rls is removed from ./x.py install. I do not think users running install will need the stub.
rls is removed from ./x.py test, it doesn't have any tests.

Other things of note:

I kept DIST_REQUIRE_ALL_TOOLS even though it is no longer needed, with the thought that it could be useful in the feature. However, I could remove it if desired.
I kept extra_deps in tool_extended (which allows tools to depend on other things), even though it is no longer needed. This can also be removed if desired.
~~This keeps RLS in the macOS pkg installer and the Windows msi installer. I kinda lean towards removing it from those, but I'm not sure?~~ RLS has been removed from pkg and msi.
This does not remove the analysis component. It is not clear if we should keep this or not. RLS was the primary user, but I think there are a few users that have made tools around it.
There will be several followup steps after this PR:
- Updating the toolstate repo to remove RLS.
- Updating documentation, such as rustc-dev-guide, to remove references to RLS.

The alert looks like this in VSCode:

In Sublime it looks similar.

I would appreciate if others could help test with other editors such as vim or Emacs.

rust-highfive · 2022-08-22T00:27:18Z

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

rustbot · 2022-08-22T00:27:18Z

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

bors · 2022-08-23T08:31:46Z

☔ The latest upstream changes (presumably #100904) made this pull request unmergeable. Please resolve the merge conflicts.

klensy · 2022-08-23T12:42:14Z

Cargo.lock

 [[package]]
 name = "serde"
-version = "1.0.140"
+version = "1.0.143"
 source = "registry https://github.com/rust-lang/crates.io-index"
-checksum = "fc855a42c7967b7c369eb5860f7164ef1f6f81c20c7cc1141f2a604e18723b03"
+checksum = "53e8e5d5b70924f74ff5c6d64d9a5acd91422117c60f48c4e07855238a254553"
 dependencies = [
 "serde_derive",
 ]


Few updates here and lower sneaked in, but i guess it's ok?

klensy · 2022-08-23T12:44:23Z

src/tools/rustc-workspace-hack/Cargo.toml

 [dependencies]
 bstr = { version = "0.2.17", features = ["default"] }
-byteorder = { version = "1", features = ['default', 'std'] }
 clap = { version = "3.1.1", features = ["derive", "clap_derive"]}
 curl-sys = { version = "0.4.13", features = ["http2", "libnghttp2-sys"], optional = true }
-crossbeam-utils = { version = "0.8.0", features = ["nightly"] }
-libc = { version = "0.2.79", features = ["align"] }
 # Ensure default features of libz-sys, which are disabled in some scenarios.
 libz-sys = { version = "1.1.2" }
 # The only user of memchr's deprecated `use_std` feature is `combine`, so this can be
 # removed if/when https://github.com/Marwes/combine/pull/348 is merged and released.
 memchr = { version = "2.5", features = ["std", "use_std"] }
 # Ensure default features of regex, which are disabled in some scenarios.
 regex = { version = "1.5.6" }
-proc-macro2 = { version = "1", features = ["default"] }
-quote = { version = "1", features = ["default"] }
-rand_core_0_5 = { package = "rand_core", version = "0.5.1", features = ["getrandom", "alloc", "std"] }
-serde = { version = "1.0.82", features = ['derive'] }
 serde_json = { version = "1.0.31", features = ["raw_value", "unbounded_depth"] }
-smallvec = { version = "1.8.1", features = ['union', 'may_dangle'] }
-syn = { version = "1", features = ['fold', 'full', 'extra-traits', 'visit', 'visit-mut'] }
 url = { version = "2.0", features = ['serde'] }


Probably not all removed crates should be removed, as some of them still used somewhere else.

These were removed based on extensive testing to ensure they aren't used elsewhere. There is some possibility that one of the more obscure platforms may enable one of these features, but that can be resolved via CI.

Uhh, i don't understand. For example, proc-macro2 with friends of quote and syn used literally everywhere: rustc\rustdoc\clippy\cargo\rustfmt.

Yes, removing this entries probably don't break things now, until some of crates decide to add\remove some of features (at which point CI will fail and contributor will be forced to return back here and rollback something).

That is true of any shared dependency between the tools. Features can be adjusted at any time. The rustc-workspace-hack doesn't cover all of the shared dependencies (nor should it, since not all tools use the same dependencies). I don't think rustc-workspace-hack should proactively add dependencies in the anticipation that they might be needed in the future. Adding new entries is relatively easy.

As for proc-macro2 and quote, I doubt those will ever appear without their default features. It is not really clear from the history why those were added.

klensy · 2022-08-23T12:45:48Z

Also this can be removed?

rust/compiler/rustc_driver/src/lib.rs

Lines 163 to 180 in 1cff564

    
           /// Emit diagnostics to the specified location. 
        
           /// 
        
           /// Used by RLS. 
        
           pub fn set_emitter(&mut self, emitter: Option<Box<dyn Write   Send>>) -> &mut Self { 
        
               self.emitter = emitter; 
        
               self 
        
           } 
        
           /// Load files from sources other than the file system. 
        
           /// 
        
           /// Used by RLS. 
        
           pub fn set_file_loader( 
        
               &mut self, 
        
               file_loader: Option<Box<dyn FileLoader   Send   Sync>>, 
        
           ) -> &mut Self { 
        
               self.file_loader = file_loader; 
        
               self 
        
           }

Mark-Simulacrum

This looks largely good to me; I think leaving further cleanups of the more interesting decisions (e.g., DIST_REQUIRE_ALL_TOOLS, other things listed in your list) to future PRs should be fine. Definitely great to see a bunch of simplifications.

I think dropping RLS from the pkg and msi installers in this PR makes sense though; usage on those is probably quite low and I'm not sure an "upgrade" there is typically done without checking back to blog posts etc (unlike may be the case with rustup).

A few smaller comments to resolve left inline.

src/tools/rls/LICENSE-MIT

src/tools/rustfmt/atom.md

ehuss · 2022-08-23T21:08:06Z

think dropping RLS from the pkg and msi installers in this PR makes sense though;

Pushed an update that removes it from the msi and pkg installers.

Mark-Simulacrum · 2022-08-27T14:45:56Z

@bors r p=1 rollup=iffy

bors · 2022-08-27T14:45:57Z

📌 Commit 9b66f46f36d9cb2189a177854e96af54f920bd19 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bjorn3 · 2022-08-27T15:37:50Z

Also this can be removed?

rust/compiler/rustc_driver/src/lib.rs

Lines 163 to 180 in 1cff564

/// Emit diagnostics to the specified location.

///

/// Used by RLS.

pub fn set_emitter(&mut self, emitter: Option<Box<dyn Write Send>>) -> &mut Self {

self.emitter = emitter;

self

}

/// Load files from sources other than the file system.

///

/// Used by RLS.

pub fn set_file_loader(

&mut self,

file_loader: Option<Box<dyn FileLoader Send Sync>>,

) -> &mut Self {

self.file_loader = file_loader;

self

}

No, I don't think so. While RLS is the main user, it is also useful outside of RLS. For example my (not updated for current nightly) https://github.com/bjorn3/rust_read_rlib uses set_file_loader to generate a fake lib.rs without having to write anything to the disk. They may also be used to fix rust-lang/rust-analyzer#3107 at some point in the future.

bors · 2022-08-27T19:38:29Z

⌛ Testing commit 9b66f46f36d9cb2189a177854e96af54f920bd19 with merge 01264cdc8b1ca0f56700ff335685ca5fe6a1c4b3...

bors · 2022-08-27T20:03:32Z

💔 Test failed - checks-actions

eddyb · 2022-08-28T19:50:38Z

This does not remove the analysis component. It is not clear if we should keep this or not. RLS was the primary user, but I think there are a few users that have made tools around it.

First off: is there a tracking issue that we could discuss this on? I will move this comment wherever necessary.

I believe searchfox's Rust indexer might be one of the more important users but I don't really know much about it, sadly (@emilio's handle shows up in the comments, maybe they can shed some light?).

(EDIT: ignore this collapsed section, @bjorn3's suggestion below of using RA is much better)

My rough suggestion would be to look at what information it reads and try to reduce the -Z save-analysis implementation in the compiler so that it doesn't outright break, but we put less effort into "offering detail".
(imagine things like pretending module::function and Type::method are the same thing, or that there is no difference between enum/structs and type aliases, etc.)

I would expect we may be able to shrink it all the way to "dump all use->def relations where we have unique Span mappings" style approach (roughly structured like a lint over the HIR that wants to see both direct paths, and inferred e.g. method callees, using the "current typeck results" pattern available to lints, though other passes also mimic their own - rustc_privacy would be a great example if it were much smaller).

AFAIK, this information would also be very similar to what rustdoc source annotation needs (cc @GuillaumeGomez @Manishearth), so there's maybe some sharing opportunity there? (e.g. make a query computing something like this, -Z save-analysis' only job becomes dumping it into some JSON format)

bjorn3 · 2022-08-28T20:05:30Z

Rust-analyzer has support for emitting LSIF formatted analysis results as well as Sourcegraph's SCIP. This might be a viable alternative for the save-analysis results for most users.

ehuss · 2022-08-28T20:09:34Z

I have no intent on making changes to save-analysis. If you want to start a discussion on that, I would imagine #43606 or something like an MCP or internals discussion would be a good start.

eddyb · 2022-08-28T20:11:45Z

(EDIT: moved to the save-analysis tracking issue, #43606)

Ah, thanks for the keywords @bjorn3, I was able to find LSIF mentioned twice already wrt searchfox:

rust-analyze: only stick with the deps/save-analysis file, instead of all of them. mozsearch/mozsearch#81 (comment)
Bug 1633260 - Add Java AST parser using JavaParser mozsearch/mozsearch#314 (comment)

Based on https://bugzilla.mozilla.org/show_bug.cgi?id=1761287 I'm guessing we should coordinate with @asutherland and eventually remove save-analysis in favor of RA LSIF.>

Will continue this discussion #43606 (saw @ehuss' comment as I was writing this, heh).

rust-timer · 2022-08-28T21:51:30Z

Finished benchmarking commit (d5ef528): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.6%	[2.6%, 2.6%]	1
Regressions ❌ (secondary)	1.9%	[1.9%, 1.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-6.9%	[-6.9%, -6.9%]	1
All ❌✅ (primary)	2.6%	[2.6%, 2.6%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.1%	[2.0%, 2.1%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.8%	[-3.8%, -3.8%]	1
All ❌✅ (primary)	2.1%	[2.0%, 2.1%]	2

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

Xanewok · 2022-08-29T11:08:55Z

Thanks a lot @ehuss, appreciate it!

…ubmodule_update, r=jyn514 Avoid bootstrap from updating rls submodule Our CI performing tests of the `x86_64-fortanix-unknown-sgx` failed with: ``` 21:00:53 ./configure --enable-lld --disable-rpath --set llvm.ninja=false --set rust.verbose-tests=true 21:00:53 ./x.py test --stage=1 --target=x86_64-fortanix-unknown-sgx library/std --host= --no-doc --exclude src/tools/linkchecker 21:00:53 Building rustbuild 21:00:53 Finished dev [unoptimized] target(s) in 0.11s 21:00:53 Updating submodule src/tools/rls 21:00:54 Building stage0 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu) 21:00:54 Updating crates.io index 21:00:55 Updating git repository `[https://github.com/rust-lang/cargo`](https://github.com/rust-lang/cargo`) ... 21:00:55 Updating git repository `[https://github.com/rust-lang/rust-clippy`](https://github.com/rust-lang/rust-clippy`) 21:00:56 Updating git repository `[https://github.com/rust-lang/rustfmt`](https://github.com/rust-lang/rustfmt`) 21:00:56 error: failed to select a version for `libgit2-sys`. 21:00:56 ... required by package `cargo v0.65.0 (https://github.com/rust-lang/cargo?rev=5514f1e0e1b3650ed8a78306198e90b66b292693#5514f1e0)` 21:00:56 ... which satisfies git dependency `cargo` of package `rls v1.41.0 (/home/jenkins/workspace/rust-sgx-ci/rust/src/tools/rls)` 21:00:56 versions that meet the requirements `^0.13.2` are: 0.13.4 1.4.2, 0.13.3 1.4.2, 0.13.2 1.4.2 21:00:56 21:00:56 the package `libgit2-sys` links to the native library `git2`, but it conflicts with a previous package which links to `git2` as well: 21:00:56 package `libgit2-sys v0.14.0 1.5.0` 21:00:56 ... which satisfies dependency `libgit2-sys = "^0.14.0"` of package `cargo v0.66.0 (/home/jenkins/workspace/rust-sgx-ci/rust/src/tools/cargo)` 21:00:56 Only one package in the dependency graph may specify the same links value. This helps ensure that only one copy of a native library is linked in the final binary. Try to adjust your dependencies so that only one package uses the links ='libgit2-sys' value. For more information, see https://doc.rust-lang.org/cargo/reference/resolver.html#links. 21:00:56 21:00:56 failed to select a version for `libgit2-sys` which could resolve this conflict ``` This is related to the version bump of `libgit2-sys` in rust-lang#11004, but the root cause is the RLS is sunset (rust-lang#100863). When the bootstrapper manages the git submodules, the wrong repo commit is checked out. This PR removes rls from the list of rust submodules.

Pkgsrc changes: * We now manage to build for mipsel-unknown-netbsd, but despite the target spec saying cpu = "mips3", the compiler manages to emit 64-bit instructions which cause "illegal instruction" error. Will need more work. The mipsel-unknown-netbsd entry is commentd out since there is no 1.64.0 bootstrap. * Managed to retain the build of aarch64_be, llvm needed a patch to avoid use of neon instructions in the BE case (llvm doesn't support use of neon in BE mode). Ref. patch to src/llvm-project/llvm/lib/Support/BLAKE3/blake3_impl.h. * The minimum gcc version is now 7.x, and that includes the cross-compiler for the targets. For i386 this also needs to /usr/include/gcc-7 include files in the target root, because immintrin.h from gcc 5 is not compatible with gcc 7.x. This applies for the targets where we build against a root from netbsd-8 (sparc64, powerpc, i386), and files/gcc-wrap gets a hack for this. * Pick up tweak for -latomic inclusion from rust-lang/rust#104220 and rust-lang/rust#104572 * Retain ability to do 32-bit NetBSD, by changing from 64 to 32 bit types in library/std/src/sys/unix/thread_parker/netbsd.rs. * I've struggled a bit to get the "openssl-src" build with -latomic where it's needed. I introduce "NetBSD-generic32" system type and use it for the NetBSD mipsel target. There is another attempt to do the same in the patch to vendor/openssl-sys/build/main.rs. * Bump bootstraps to 1.64.0, checksum updates. Upstream changes: Version 1.65.0 (2022-11-03) ========================== Language -------- - [Error on `as` casts of enums with `#[non_exhaustive]` variants] (rust-lang/rust#92744) - [Stabilize `let else`](rust-lang/rust#93628) - [Stabilize generic associated types (GATs)] (rust-lang/rust#96709) - [Add lints `let_underscore_drop`, `let_underscore_lock`, and `let_underscore_must_use` from Clippy] (rust-lang/rust#97739) - [Stabilize `break`ing from arbitrary labeled blocks ("label-break-value")] (rust-lang/rust#99332) - [Uninitialized integers, floats, and raw pointers are now considered immediate UB](rust-lang/rust#98919). Usage of `MaybeUninit` is the correct way to work with uninitialized memory. - [Stabilize raw-dylib for Windows x86_64, aarch64, and thumbv7a] (rust-lang/rust#99916) - [Do not allow `Drop` impl on foreign ADTs] (rust-lang/rust#99576) Compiler -------- - [Stabilize -Csplit-debuginfo on Linux] (rust-lang/rust#98051) - [Use niche-filling optimization even when multiple variants have data] (rust-lang/rust#94075) - [Associated type projections are now verified to be well-formed prior to resolving the underlying type] (rust-lang/rust#99217) - [Stringify non-shorthand visibility correctly] (rust-lang/rust#100350) - [Normalize struct field types when unsizing] (rust-lang/rust#101831) - [Update to LLVM 15](rust-lang/rust#99464) - [Fix aarch64 call abi to correctly zeroext when needed] (rust-lang/rust#97800) - [debuginfo: Generalize C -like encoding for enums] (rust-lang/rust#98393) - [Add `special_module_name` lint] (rust-lang/rust#94467) - [Add support for generating unique profraw files by default when using `-C instrument-coverage`] (rust-lang/rust#100384) - [Allow dynamic linking for iOS/tvOS targets] (rust-lang/rust#100636) New targets: - [Add armv4t-none-eabi as a tier 3 target] (rust-lang/rust#100244) - [Add powerpc64-unknown-openbsd and riscv64-unknown-openbsd as tier 3 targets] (rust-lang/rust#101025) - Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Don't generate `PartialEq::ne` in derive(PartialEq)] (rust-lang/rust#98655) - [Windows RNG: Use `BCRYPT_RNG_ALG_HANDLE` by default] (rust-lang/rust#101325) - [Forbid mixing `System` with direct system allocator calls] (rust-lang/rust#101394) - [Document no support for writing to non-blocking stdio/stderr] (rust-lang/rust#101416) - [`std::layout::Layout` size must not overflow `isize::MAX` when rounded up to `align`](rust-lang/rust#95295) This also changes the safety conditions on `Layout::from_size_align_unchecked`. Stabilized APIs --------------- - [`std::backtrace::Backtrace`] (https://doc.rust-lang.org/stable/std/backtrace/struct.Backtrace.html) - [`Bound::as_ref`] (https://doc.rust-lang.org/stable/std/ops/enum.Bound.html#method.as_ref) - [`std::io::read_to_string`] (https://doc.rust-lang.org/stable/std/io/fn.read_to_string.html) - [`<*const T>::cast_mut`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.cast_mut) - [`<*mut T>::cast_const`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.cast_const) These APIs are now stable in const contexts: - [`<*const T>::offset_from`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.offset_from) - [`<*mut T>::offset_from`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.offset_from) Cargo ----- - [Apply GitHub fast path even for partial hashes] (rust-lang/cargo#10807) - [Do not add home bin path to PATH if it's already there] (rust-lang/cargo#11023) - [Take priority into account within the pending queue] (rust-lang/cargo#11032). This slightly optimizes job scheduling by Cargo, with typically small improvements on larger crate graph builds. Compatibility Notes ------------------- - [`std::layout::Layout` size must not overflow `isize::MAX` when rounded up to `align`] (rust-lang/rust#95295). This also changes the safety conditions on `Layout::from_size_align_unchecked`. - [`PollFn` now only implements `Unpin` if the closure is `Unpin`] (rust-lang/rust#102737). This is a possible breaking change if users were relying on the blanket unpin implementation. See discussion on the PR for details of why this change was made. - [Drop ExactSizeIterator impl from std::char::EscapeAscii] (rust-lang/rust#99880) This is a backwards-incompatible change to the standard library's surface area, but is unlikely to affect real world usage. - [Do not consider a single repeated lifetime eligible for elision in the return type] (rust-lang/rust#103450) This behavior was unintentionally changed in 1.64.0, and this release reverts that change by making this an error again. - [Reenable disabled early syntax gates as future-incompatibility lints] (rust-lang/rust#99935) - [Update the minimum external LLVM to 13] (rust-lang/rust#100460) - [Don't duplicate file descriptors into stdio fds] (rust-lang/rust#101426) - [Sunset RLS](rust-lang/rust#100863) - [Deny usage of `#![cfg_attr(..., crate_type = ...)]` to set the crate type] (rust-lang/rust#99784) This strengthens the forward compatibility lint deprecated_cfg_attr_crate_type_name to deny. - [`llvm-has-rust-patches` allows setting the build system to treat the LLVM as having Rust-specific patches] (rust-lang/rust#101072) This option may need to be set for distributions that are building Rust with a patched LLVM via `llvm-config`, not the built-in LLVM. Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Add `x.sh` and `x.ps1` shell scripts] (rust-lang/rust#99992) - [compiletest: use target cfg instead of hard-coded tables] (rust-lang/rust#100260) - [Use object instead of LLVM for reading bitcode from rlibs] (rust-lang/rust#98100) - [Enable MIR inlining for optimized compilations] (rust-lang/rust#91743) This provides a 3-10% improvement in compiletimes for real world crates. See [perf results] (https://perf.rust-lang.org/compare.html?start=aedf78e56b2279cc869962feac5153b6ba7001ed&end=0075bb4fad68e64b6d1be06bf2db366c30bc75e1&stat=instructions:u).

doc(contrib): remove rls in release process ### What does this PR try to resolve? Remove mentions of RLS from doc of release process. RLS is no longer required to test when bumping Cargo version in rust-lang/rust. See: - rust-lang/rust#100863 - https://blog.rust-lang.org/2022/07/01/RLS-deprecation.html

Pkgsrc changes: * pkglint cleanups, bump bootstrap kits to 1.65.0. * New target: mipsel-unknown-netbsd, for cpu=mips32 with soft-float. * Managed to retain the build of aarch64_be, llvm needed a patch to avoid use of neon instructions in the BE case (llvm doesn't support use of neon in BE mode). Ref. patch to src/llvm-project/llvm/lib/Support/BLAKE3/blake3_impl.h. Also submitted upstream of LLVM to the BLAKE3 maintainers. * The minimum gcc version is now 7.x, and that includes the cross-compiler for the targets. For i386 this also needs to /usr/include/gcc-7 include files in the target root, because immintrin.h from gcc 5 is not compatible with gcc 7.x. This applies for the targets where we build against a root from netbsd-8 (sparc64, powerpc, i386), and files/gcc-wrap gets a hack for this. * Pick up tweak for -latomic inclusion from rust-lang/rust#104220 and rust-lang/rust#104572 * Retain ability to do 32-bit NetBSD, by changing from 64 to 32 bit types in library/std/src/sys/unix/thread_parker/netbsd.rs. * I've tried to get the "openssl-src" build with -latomic where it's needed. I've introduced the "NetBSD-generic32" system type and use it for the NetBSD mipsel target. There is another attempt to do the same in the patch to vendor/openssl-sys/build/main.rs. Upstream changes: Version 1.66.1 (2023-01-10) =========================== - Added validation of SSH host keys for git URLs in Cargo ([CVE-2022-46176](https://www.cve.org/CVERecord?id=CVE-2022-46176)) Version 1.66.0 (2022-12-15) =========================== Language -------- - [Permit specifying explicit discriminants on all `repr(Int)` enums](rust-lang/rust#95710) ```rust #[repr(u8)] enum Foo { A(u8) = 0, B(i8) = 1, C(bool) = 42, } ``` - [Allow transmutes between the same type differing only in lifetimes](rust-lang/rust#101520) - [Change constant evaluation errors from a deny-by-default lint to a hard error](rust-lang/rust#102091) - [Trigger `must_use` on `impl Trait` for supertraits](rust-lang/rust#102287) This makes `impl ExactSizeIterator` respect the existing `#[must_use]` annotation on `Iterator`. - [Allow `..X` and `..=X` in patterns](rust-lang/rust#102275) - [Uplift `clippy::for_loops_over_fallibles` lint into rustc](rust-lang/rust#99696) - [Stabilize `sym` operands in inline assembly](rust-lang/rust#103168) - [Update to Unicode 15](rust-lang/rust#101912) - [Opaque types no longer imply lifetime bounds](rust-lang/rust#95474) This is a soundness fix which may break code that was erroneously relying on this behavior. Compiler -------- - [Add armv5te-none-eabi and thumbv5te-none-eabi tier 3 targets](rust-lang/rust#101329) - Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. - [Add support for linking against macOS universal libraries](rust-lang/rust#98736) Libraries --------- - [Fix `#[derive(Default)]` on a generic `#[default]` enum adding unnecessary `Default` bounds](rust-lang/rust#101040) - [Update to Unicode 15](rust-lang/rust#101821) Stabilized APIs --------------- - [`proc_macro::Span::source_text`](https://doc.rust-lang.org/stable/proc_macro/struct.Span.html#method.source_text) - [`uX::{checked_add_signed, overflowing_add_signed, saturating_add_signed, wrapping_add_signed}`](https://doc.rust-lang.org/stable/std/primitive.u8.html#method.checked_add_signed) - [`iX::{checked_add_unsigned, overflowing_add_unsigned, saturating_add_unsigned, wrapping_add_unsigned}`](https://doc.rust-lang.org/stable/std/primitive.i8.html#method.checked_add_unsigned) - [`iX::{checked_sub_unsigned, overflowing_sub_unsigned, saturating_sub_unsigned, wrapping_sub_unsigned}`](https://doc.rust-lang.org/stable/std/primitive.i8.html#method.checked_sub_unsigned) - [`BTreeSet::{first, last, pop_first, pop_last}`](https://doc.rust-lang.org/stable/std/collections/struct.BTreeSet.html#method.first) - [`BTreeMap::{first_key_value, last_key_value, first_entry, last_entry, pop_first, pop_last}`](https://doc.rust-lang.org/stable/std/collections/struct.BTreeMap.html#method.first_key_value) - [Add `AsFd` implementations for stdio lock types on WASI.](rust-lang/rust#101768) - [`impl TryFrom<Vec<T>> for Box<[T; N]>`](https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#impl-TryFrom>-for-Box<[T; N], Global>) - [`core::hint::black_box`](https://doc.rust-lang.org/stable/std/hint/fn.black_box.html) - [`Duration::try_from_secs_{f32,f64}`](https://doc.rust-lang.org/stable/std/time/struct.Duration.html#method.try_from_secs_f32) - [`Option::unzip`](https://doc.rust-lang.org/stable/std/option/enum.Option.html#method.unzip) - [`std::os::fd`](https://doc.rust-lang.org/stable/std/os/fd/index.html) Rustdoc ------- - [Add Rustdoc warning for invalid HTML tags in the documentation](rust-lang/rust#101720) Cargo ----- - [Added `cargo remove` to remove dependencies from Cargo.toml](https://doc.rust-lang.org/nightly/cargo/commands/cargo-remove.html) - [`cargo publish` now waits for the new version to be downloadable before exiting](rust-lang/cargo#11062) See [detailed release notes](https://github.com/rust-lang/cargo/blob/master/CHANGELOG.md#cargo-166-2022-12-15) for more. Compatibility Notes ------------------- - [Only apply `ProceduralMasquerade` hack to older versions of `rental`](rust-lang/rust#94063) - [Don't export `__heap_base` and `__data_end` on wasm32-wasi.](rust-lang/rust#102385) - [Don't export `__wasm_init_memory` on WebAssembly.](rust-lang/rust#102426) - [Only export `__tls_*` on wasm32-unknown-unknown.](rust-lang/rust#102440) - [Don't link to `libresolv` in libstd on Darwin](rust-lang/rust#102766) - [Update libstd's libc to 0.2.135 (to make `libstd` no longer pull in `libiconv.dylib` on Darwin)](rust-lang/rust#103277) - [Opaque types no longer imply lifetime bounds](rust-lang/rust#95474) This is a soundness fix which may break code that was erroneously relying on this behavior. - [Make `order_dependent_trait_objects` show up in future-breakage reports](rust-lang/rust#102635) - [Change std::process::Command spawning to default to inheriting the parent's signal mask](rust-lang/rust#101077) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Enable BOLT for LLVM compilation](rust-lang/rust#94381) - [Enable LTO for rustc_driver.so](rust-lang/rust#101403) Version 1.65.0 (2022-11-03) ========================== Language -------- - [Error on `as` casts of enums with `#[non_exhaustive]` variants] (rust-lang/rust#92744) - [Stabilize `let else`](rust-lang/rust#93628) - [Stabilize generic associated types (GATs)] (rust-lang/rust#96709) - [Add lints `let_underscore_drop`, `let_underscore_lock`, and `let_underscore_must_use` from Clippy] (rust-lang/rust#97739) - [Stabilize `break`ing from arbitrary labeled blocks ("label-break-value")] (rust-lang/rust#99332) - [Uninitialized integers, floats, and raw pointers are now considered immediate UB](rust-lang/rust#98919). Usage of `MaybeUninit` is the correct way to work with uninitialized memory. - [Stabilize raw-dylib for Windows x86_64, aarch64, and thumbv7a] (rust-lang/rust#99916) - [Do not allow `Drop` impl on foreign ADTs] (rust-lang/rust#99576) Compiler -------- - [Stabilize -Csplit-debuginfo on Linux] (rust-lang/rust#98051) - [Use niche-filling optimization even when multiple variants have data] (rust-lang/rust#94075) - [Associated type projections are now verified to be well-formed prior to resolving the underlying type] (rust-lang/rust#99217) - [Stringify non-shorthand visibility correctly] (rust-lang/rust#100350) - [Normalize struct field types when unsizing] (rust-lang/rust#101831) - [Update to LLVM 15](rust-lang/rust#99464) - [Fix aarch64 call abi to correctly zeroext when needed] (rust-lang/rust#97800) - [debuginfo: Generalize C -like encoding for enums] (rust-lang/rust#98393) - [Add `special_module_name` lint] (rust-lang/rust#94467) - [Add support for generating unique profraw files by default when using `-C instrument-coverage`] (rust-lang/rust#100384) - [Allow dynamic linking for iOS/tvOS targets] (rust-lang/rust#100636) New targets: - [Add armv4t-none-eabi as a tier 3 target] (rust-lang/rust#100244) - [Add powerpc64-unknown-openbsd and riscv64-unknown-openbsd as tier 3 targets] (rust-lang/rust#101025) - Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Don't generate `PartialEq::ne` in derive(PartialEq)] (rust-lang/rust#98655) - [Windows RNG: Use `BCRYPT_RNG_ALG_HANDLE` by default] (rust-lang/rust#101325) - [Forbid mixing `System` with direct system allocator calls] (rust-lang/rust#101394) - [Document no support for writing to non-blocking stdio/stderr] (rust-lang/rust#101416) - [`std::layout::Layout` size must not overflow `isize::MAX` when rounded up to `align`](rust-lang/rust#95295) This also changes the safety conditions on `Layout::from_size_align_unchecked`. Stabilized APIs --------------- - [`std::backtrace::Backtrace`] (https://doc.rust-lang.org/stable/std/backtrace/struct.Backtrace.html) - [`Bound::as_ref`] (https://doc.rust-lang.org/stable/std/ops/enum.Bound.html#method.as_ref) - [`std::io::read_to_string`] (https://doc.rust-lang.org/stable/std/io/fn.read_to_string.html) - [`<*const T>::cast_mut`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.cast_mut) - [`<*mut T>::cast_const`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.cast_const) These APIs are now stable in const contexts: - [`<*const T>::offset_from`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.offset_from) - [`<*mut T>::offset_from`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.offset_from) Cargo ----- - [Apply GitHub fast path even for partial hashes] (rust-lang/cargo#10807) - [Do not add home bin path to PATH if it's already there] (rust-lang/cargo#11023) - [Take priority into account within the pending queue] (rust-lang/cargo#11032). This slightly optimizes job scheduling by Cargo, with typically small improvements on larger crate graph builds. Compatibility Notes ------------------- - [`std::layout::Layout` size must not overflow `isize::MAX` when rounded up to `align`] (rust-lang/rust#95295). This also changes the safety conditions on `Layout::from_size_align_unchecked`. - [`PollFn` now only implements `Unpin` if the closure is `Unpin`] (rust-lang/rust#102737). This is a possible breaking change if users were relying on the blanket unpin implementation. See discussion on the PR for details of why this change was made. - [Drop ExactSizeIterator impl from std::char::EscapeAscii] (rust-lang/rust#99880) This is a backwards-incompatible change to the standard library's surface area, but is unlikely to affect real world usage. - [Do not consider a single repeated lifetime eligible for elision in the return type] (rust-lang/rust#103450) This behavior was unintentionally changed in 1.64.0, and this release reverts that change by making this an error again. - [Reenable disabled early syntax gates as future-incompatibility lints] (rust-lang/rust#99935) - [Update the minimum external LLVM to 13] (rust-lang/rust#100460) - [Don't duplicate file descriptors into stdio fds] (rust-lang/rust#101426) - [Sunset RLS](rust-lang/rust#100863) - [Deny usage of `#![cfg_attr(..., crate_type = ...)]` to set the crate type] (rust-lang/rust#99784) This strengthens the forward compatibility lint deprecated_cfg_attr_crate_type_name to deny. - [`llvm-has-rust-patches` allows setting the build system to treat the LLVM as having Rust-specific patches] (rust-lang/rust#101072) This option may need to be set for distributions that are building Rust with a patched LLVM via `llvm-config`, not the built-in LLVM. Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Add `x.sh` and `x.ps1` shell scripts] (rust-lang/rust#99992) - [compiletest: use target cfg instead of hard-coded tables] (rust-lang/rust#100260) - [Use object instead of LLVM for reading bitcode from rlibs] (rust-lang/rust#98100) - [Enable MIR inlining for optimized compilations] (rust-lang/rust#91743) This provides a 3-10% improvement in compiletimes for real world crates. See [perf results] (https://perf.rust-lang.org/compare.html?start=aedf78e56b2279cc869962feac5153b6ba7001ed&end=0075bb4fad68e64b6d1be06bf2db366c30bc75e1&stat=instructions:u).

rust-highfive assigned Mark-Simulacrum Aug 22, 2022

rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 22, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 22, 2022

This comment has been minimized.

Sign in to view

ehuss force-pushed the sunset-rls branch from e03c18b to 29f303e Compare August 22, 2022 00:32

klensy reviewed Aug 23, 2022

View reviewed changes

Mark-Simulacrum reviewed Aug 23, 2022

View reviewed changes

src/tools/rls/LICENSE-MIT Outdated Show resolved Hide resolved

src/tools/rustfmt/atom.md Outdated Show resolved Hide resolved

ehuss force-pushed the sunset-rls branch 2 times, most recently from 6502028 to 9b66f46 Compare August 23, 2022 19:49

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2022

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 27, 2022

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2022

ehuss force-pushed the sunset-rls branch from 9b66f46 to c0dc111 Compare August 28, 2022 04:34

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 28, 2022

bors merged commit d5ef528 into rust-lang:master Aug 28, 2022

rustbot added this to the 1.65.0 milestone Aug 28, 2022

This was referenced Aug 28, 2022

Rewrite LLVM's archive writer in Rust #97485

Merged

Distribute bootstrap in CI #98483

Merged

Alignment of the bytes of Allocation to match align parameter #100467

Closed

ehuss added the relnotes Marks issues that should be documented in the release notes of the next release. label Aug 28, 2022

lebensterben mentioned this pull request Aug 28, 2022

tracking issue: deprecate rls from rust layer syl20bnr/spacemacs#15713

Closed

This was referenced Aug 28, 2022

Update for removal of RLS rust-lang/rustc-dev-guide#1450

Merged

Remove RLS rust-lang-nursery/rust-toolstate#25

Merged

Remove mentions of RLS rust-lang/rust-forge#646

Merged

ehuss mentioned this pull request Aug 28, 2022

Spurious RLS test failures #62225

Closed

eddyb mentioned this pull request Aug 28, 2022

Tracking issue for -Zsave-analysis #43606

Closed

Veykril mentioned this pull request Aug 29, 2022

Tracking issue fo RFC2912, transition to rust-analyzer as our official LSP rust-lang/rust-analyzer#4224

Closed

7 tasks

raoulstrackx mentioned this pull request Aug 30, 2022

Avoid bootstrap from updating rls submodule #101203

Merged

weihanglo mentioned this pull request Jan 20, 2023

doc(contrib): remove rls in release process rust-lang/cargo#11601

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sunset RLS #100863

Sunset RLS #100863

ehuss commented Aug 22, 2022 •

edited

Loading

rust-highfive commented Aug 22, 2022

rustbot commented Aug 22, 2022

This comment has been minimized.

bors commented Aug 23, 2022

klensy Aug 23, 2022

klensy Aug 23, 2022 •

edited

Loading

ehuss Aug 23, 2022

klensy Aug 23, 2022

ehuss Aug 23, 2022

klensy commented Aug 23, 2022

Mark-Simulacrum left a comment

ehuss commented Aug 23, 2022

Mark-Simulacrum commented Aug 27, 2022

bors commented Aug 27, 2022

bjorn3 commented Aug 27, 2022

bors commented Aug 27, 2022

This comment has been minimized.

bors commented Aug 27, 2022

eddyb commented Aug 28, 2022 •

edited

Loading

bjorn3 commented Aug 28, 2022

ehuss commented Aug 28, 2022

eddyb commented Aug 28, 2022 •

edited

Loading

rust-timer commented Aug 28, 2022

Xanewok commented Aug 29, 2022

Sunset RLS #100863

Sunset RLS #100863

Conversation

ehuss commented Aug 22, 2022 • edited Loading

rust-highfive commented Aug 22, 2022

rustbot commented Aug 22, 2022

This comment has been minimized.

bors commented Aug 23, 2022

klensy Aug 23, 2022

Choose a reason for hiding this comment

klensy Aug 23, 2022 • edited Loading

Choose a reason for hiding this comment

ehuss Aug 23, 2022

Choose a reason for hiding this comment

klensy Aug 23, 2022

Choose a reason for hiding this comment

ehuss Aug 23, 2022

Choose a reason for hiding this comment

klensy commented Aug 23, 2022

Mark-Simulacrum left a comment

Choose a reason for hiding this comment

ehuss commented Aug 23, 2022

Mark-Simulacrum commented Aug 27, 2022

bors commented Aug 27, 2022

bjorn3 commented Aug 27, 2022

bors commented Aug 27, 2022

This comment has been minimized.

bors commented Aug 27, 2022

eddyb commented Aug 28, 2022 • edited Loading

bjorn3 commented Aug 28, 2022

ehuss commented Aug 28, 2022

eddyb commented Aug 28, 2022 • edited Loading

rust-timer commented Aug 28, 2022

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Xanewok commented Aug 29, 2022

ehuss commented Aug 22, 2022 •

edited

Loading

klensy Aug 23, 2022 •

edited

Loading

eddyb commented Aug 28, 2022 •

edited

Loading

eddyb commented Aug 28, 2022 •

edited

Loading