Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rustdoc] Fix item info display #100718

Merged
merged 2 commits into from
Aug 20, 2022
Merged

Conversation

GuillaumeGomez
Copy link
Member

Fixes #100369.

The solution I came up with was simply to wrap the "text part" of the item-info into another span so that flex wouldn't mess with it.

Live demo is here.

r? @jsha

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: rustdoc UI (generated HTML) labels Aug 18, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 18, 2022
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez
Copy link
Member Author

Fixed fmt too.

@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez
Copy link
Member Author

And updated tests.

@jsha
Copy link
Contributor

jsha commented Aug 20, 2022

@bors r rollup

@bors
Copy link
Contributor

bors commented Aug 20, 2022

📌 Commit 0df1c69 has been approved by jsha

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 20, 2022
[rustdoc] Fix item info display

Fixes  rust-lang#100369.

The solution I came up with was simply to wrap the "text part" of the `item-info` into another span so that `flex` wouldn't mess with it.

Live demo is [here](https://rustdoc.crud.net/imperio/fix-item-info/foo/struct.ItemInfo.html).

r? `@jsha`
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 20, 2022
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#97963 (net listen backlog set to negative on Linux.)
 - rust-lang#99935 (Reenable disabled early syntax gates as future-incompatibility lints)
 - rust-lang#100129 (add miri-test-libstd support to libstd)
 - rust-lang#100500 (Ban references to `Self` in trait object substs for projection predicates too.)
 - rust-lang#100636 (Revert "Revert "Allow dynamic linking for iOS/tvOS targets."")
 - rust-lang#100718 ([rustdoc] Fix item info display)
 - rust-lang#100769 (Suggest adding a reference to a trait assoc item)
 - rust-lang#100777 (elaborate how revisions work with FileCheck stuff in src/test/codegen)
 - rust-lang#100796 (Refactor: remove unnecessary string searchings)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit aaa5574 into rust-lang:master Aug 20, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 20, 2022
@GuillaumeGomez GuillaumeGomez deleted the fix-item-info branch August 21, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: rustdoc UI (generated HTML) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc: item-info is incorrectly wrapped on narrow screens
6 participants