Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add next_up and next_down for f32/f64 - take 2 #100578

Merged
merged 9 commits into from
Aug 29, 2022
Merged

Add next_up and next_down for f32/f64 - take 2 #100578

merged 9 commits into from
Aug 29, 2022

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Aug 15, 2022

This is a revival of #88728 which staled due to inactivity of the original author. I've address the last review comment.

This is a pull request implementing the features described at rust-lang/rfcs#3173.

@rustbot label T-libs-api -T-libs
r? @scottmcm
cc @orlp

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Aug 15, 2022
@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 15, 2022
@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Aug 15, 2022
@scottmcm
Copy link
Member

Thanks for reviving this!

@bors r rollup=iffy (probably fine this time, but previously failed in 32-bit i386 so might want its own bors run)

@bors
Copy link
Contributor

bors commented Aug 20, 2022

📌 Commit 3f10e6c has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2022
@orlp
Copy link
Contributor

orlp commented Aug 21, 2022

I'd just like to say that my pull request hasn't really stalled due to inactivity, but due to me not knowing what to do about this unresolved question: #91399 (comment)

@scottmcm
Copy link
Member

@orlp I guess I'm happy saying that that's something that might block stabilization, but don't need to keep it from going into nightly.

(Unless libs-api previously said otherwise, since its their call.)

@bors
Copy link
Contributor

bors commented Aug 28, 2022

⌛ Testing commit 3f10e6c with merge 1ea4efd...

@bors
Copy link
Contributor

bors commented Aug 29, 2022

☀️ Test successful - checks-actions
Approved by: scottmcm
Pushing 1ea4efd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 29, 2022
@bors bors merged commit 1ea4efd into rust-lang:master Aug 29, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 29, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1ea4efd): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.2% [1.2%, 1.2%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.5% [-0.5%, -0.5%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 2.1% [2.1%, 2.1%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.7% [-2.7%, -2.7%] 1
Improvements ✅
(secondary)		 -6.0% [-6.0%, -6.0%] 1
All ❌✅ (primary) -0.3% [-2.7%, 2.1%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@workingjubilee workingjubilee mentioned this pull request Nov 22, 2022
Open
4 tasks
@RalfJung RalfJung mentioned this pull request Sep 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scottmcm scottmcm

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Urgau @rustbot @scottmcm @bors @orlp @rust-timer @rust-highfive