Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for #![feature(const_cell_into_inner)] #78729

Open
3 of 4 tasks
Tracked by #3
a1phyr opened this issue Nov 4, 2020 · 5 comments
Open
3 of 4 tasks
Tracked by #3

Tracking Issue for #![feature(const_cell_into_inner)] #78729

a1phyr opened this issue Nov 4, 2020 · 5 comments
Labels
A-const-fn Area: const fn foo(..) {..}. Pure functions which can be applied at compile time. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@a1phyr
Copy link
Contributor

a1phyr commented Nov 4, 2020 •
edited
Loading

This is a tracking issue for #![feature(const_cell_into_inner)].

Constantified functions are:

  • UnsafeCell::into_inner
  • Cell::into_inner
  • RefCell::into_inner
  • Atomic*::into_inner (done)

Steps
@a1phyr a1phyr added the C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. label Nov 4, 2020
@a1phyr a1phyr mentioned this issue Nov 4, 2020
Merged
@LeSeulArtichaut LeSeulArtichaut added A-const-fn Area: const fn foo(..) {..}. Pure functions which can be applied at compile time. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Nov 4, 2020
@KodrAus KodrAus added the Libs-Tracked Libs issues that are tracked on the team's project board. label Nov 6, 2020
m-ou-se added a commit to m-ou-se/rust that referenced this issue Nov 7, 2020
@m-ou-se
Rollup merge of rust-lang#78728 - a1phyr:const_cell_into_inner, r=dto…
31c3252 
…lnay

Constantify `UnsafeCell::into_inner` and related

Tracking issue: rust-lang#78729

This PR constantifies:
- `UnsafeCell::into_inner`
- `Cell::into_inner`
- `RefCell::into_inner`
- `Atomic*::into_inner`

r? `@dtolnay`
m-ou-se added a commit to m-ou-se/rust that referenced this issue Nov 7, 2020
@m-ou-se
Rollup merge of rust-lang#78728 - a1phyr:const_cell_into_inner, r=dto…
3f35770 
…lnay

Constantify `UnsafeCell::into_inner` and related

Tracking issue: rust-lang#78729

This PR constantifies:
- `UnsafeCell::into_inner`
- `Cell::into_inner`
- `RefCell::into_inner`
- `Atomic*::into_inner`

r? ``@dtolnay``
m-ou-se added a commit to m-ou-se/rust that referenced this issue Nov 7, 2020
@m-ou-se
Rollup merge of rust-lang#78728 - a1phyr:const_cell_into_inner, r=dto…
331b7fb 
…lnay

Constantify `UnsafeCell::into_inner` and related

Tracking issue: rust-lang#78729

This PR constantifies:
- `UnsafeCell::into_inner`
- `Cell::into_inner`
- `RefCell::into_inner`
- `Atomic*::into_inner`

r? ```@dtolnay```
m-ou-se added a commit to m-ou-se/rust that referenced this issue Nov 7, 2020
@m-ou-se
Rollup merge of rust-lang#78728 - a1phyr:const_cell_into_inner, r=dto…
c152e91 
…lnay

Constantify `UnsafeCell::into_inner` and related

Tracking issue: rust-lang#78729

This PR constantifies:
- `UnsafeCell::into_inner`
- `Cell::into_inner`
- `RefCell::into_inner`
- `Atomic*::into_inner`

r? ````@dtolnay````
m-ou-se added a commit to m-ou-se/rust that referenced this issue Nov 8, 2020
@m-ou-se
Rollup merge of rust-lang#78728 - a1phyr:const_cell_into_inner, r=dto…
2967e58 
…lnay

Constantify `UnsafeCell::into_inner` and related

Tracking issue: rust-lang#78729

This PR constantifies:
- `UnsafeCell::into_inner`
- `Cell::into_inner`
- `RefCell::into_inner`
- `Atomic*::into_inner`

r? `````@dtolnay`````
@m-ou-se
Copy link
Member

m-ou-se commented Mar 31, 2021

@rfcbot merge

cc @rust-lang/wg-const-eval

@rfcbot
Copy link

rfcbot commented Mar 31, 2021 •
edited by BurntSushi
Loading

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Mar 31, 2021
@rfcbot
Copy link

rfcbot commented Mar 31, 2021

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Mar 31, 2021
@rfcbot rfcbot added the finished-final-comment-period The final comment period is finished for this PR / Issue. label Apr 10, 2021
@rfcbot
Copy link

rfcbot commented Apr 10, 2021

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@rfcbot rfcbot added to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Apr 10, 2021
@m-ou-se m-ou-se mentioned this issue Apr 11, 2021
Closed
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Apr 15, 2021
@mkroening mkroening mentioned this issue Oct 8, 2023
Open
1 task
@dtolnay dtolnay mentioned this issue Apr 5, 2024
Merged
@dtolnay
Copy link
Member

dtolnay commented Apr 5, 2024

According to #84087 (comment), this is blocked on the "precise drop analysis" unstable const feature (#73255).

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Apr 6, 2024
@matthiaskrgr
Rollup merge of rust-lang#123522 - dtolnay:constatomicintoinner, r=Ni…
0b5a8ac 
…lstrieb

Stabilize const Atomic*::into_inner

Partial stabilization for rust-lang#78729, for which the FCP has already completed.

The other `into_inner` functions in that tracking issue (`UnsafeCell`, `Cell`, `RefCell`) are blocked on rust-lang#73255 for now.

```console
error[E0493]: destructor of `UnsafeCell<T>` cannot be evaluated at compile-time
    --> library/core/src/cell.rs:2076:29
     |
2076 |     pub const fn into_inner(self) -> T {
     |                             ^^^^ the destructor for this type cannot be evaluated in constant functions
2077 |         self.value
2078 |     }
     |     - value is dropped here
```
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Apr 7, 2024
@rust-timer
Unrolled build for rust-lang#123522
30ca7b6 
Rollup merge of rust-lang#123522 - dtolnay:constatomicintoinner, r=Nilstrieb

Stabilize const Atomic*::into_inner

Partial stabilization for rust-lang#78729, for which the FCP has already completed.

The other `into_inner` functions in that tracking issue (`UnsafeCell`, `Cell`, `RefCell`) are blocked on rust-lang#73255 for now.

```console
error[E0493]: destructor of `UnsafeCell<T>` cannot be evaluated at compile-time
    --> library/core/src/cell.rs:2076:29
     |
2076 |     pub const fn into_inner(self) -> T {
     |                             ^^^^ the destructor for this type cannot be evaluated in constant functions
2077 |         self.value
2078 |     }
     |     - value is dropped here
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-const-fn Area: const fn foo(..) {..}. Pure functions which can be applied at compile time. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stabilize const_cell_into_inner. m-ou-se/rust
7 participants
@m-ou-se @dtolnay @apiraino @KodrAus @rfcbot @LeSeulArtichaut @a1phyr