Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for #![feature(const_float_classify)] #72505

Open
ecstatic-morse opened this issue May 23, 2020 · 1 comment
Open

Tracking issue for #![feature(const_float_classify)] #72505

ecstatic-morse opened this issue May 23, 2020 · 1 comment
Assignees
@ecstatic-morse
Labels
A-const-fn Area: const fn foo(..) {..}. Pure functions which can be applied at compile time. A-floating-point Area: Floating point numbers and arithmetic B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@ecstatic-morse
Copy link
Contributor

ecstatic-morse commented May 23, 2020 •
edited by RalfJung
Loading

Tracking issue for the #![feature(const_float_classify)] feature gate, which makes the following methods on f32 and f64 const fn:

  • classify
  • is_nan
  • is_infinite
  • is_finite
  • is_normal
  • is_sign_positive
  • is_positive (deprecated)
  • is_sign_negative
  • is_negative (deprecated)

These require #72447 (#![feature(const_float_bits_conv)]), so this is transitively blocked on #57241.
@ecstatic-morse ecstatic-morse self-assigned this May 23, 2020
@ecstatic-morse ecstatic-morse added A-const-fn Area: const fn foo(..) {..}. Pure functions which can be applied at compile time. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels May 23, 2020
@ecstatic-morse ecstatic-morse mentioned this issue May 23, 2020
Merged
RalfJung added a commit to RalfJung/rust that referenced this issue Jun 12, 2020
@RalfJung
Rollup merge of rust-lang#72449 - ecstatic-morse:const-float-bitcast,…
802a9ac 
… r=RalfJung,oli-obk

Const floating point bitcasts and classification

Makes the `f32` and `f64` methods described in rust-lang#72447 and rust-lang#72505 unstably const.

r? @RalfJung
@KodrAus KodrAus added A-floating-point Area: Floating point numbers and arithmetic B-unstable Blocker: Implemented in the nightly compiler and unstable. Libs-Tracked Libs issues that are tracked on the team's project board. labels Jul 29, 2020
bors added a commit to rust-lang-ci/rust that referenced this issue Aug 23, 2020
@bors
Auto merge of rust-lang#72449 - ecstatic-morse:const-float-bitcast, r…
0ec9459 
…=RalfJung

Const floating point bitcasts and classification

Makes the `f32` and `f64` methods described in rust-lang#72447 and rust-lang#72505 unstably const.

r? @RalfJung
@Urgau Urgau mentioned this issue Aug 5, 2023
Merged
@killercup killercup mentioned this issue Nov 17, 2023
Merged
@J-ZhengLi J-ZhengLi mentioned this issue Feb 27, 2024
Open
@RalfJung
Copy link
Member

RalfJung commented Aug 3, 2024 •
edited
Loading

#57241 is being proposed for stabilization, so this feature is also finally (transitively) unblocked. :)

Note that #114486 should also be reverted when is_nan becomes const-stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ecstatic-morse ecstatic-morse

Labels
A-const-fn Area: const fn foo(..) {..}. Pure functions which can be applied at compile time. A-floating-point Area: Floating point numbers and arithmetic B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RalfJung @KodrAus @ecstatic-morse