Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dvec and vec interface cleanup #2924

Closed
bblum opened this issue Jul 14, 2012 · 1 comment
Closed

dvec and vec interface cleanup #2924

bblum opened this issue Jul 14, 2012 · 1 comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@bblum
Copy link
Contributor

bblum commented Jul 14, 2012

Vec needs 'reach'. (fixed)
Dvec needs 'reverse'. (fixed)
Dvec 'reach' doesn't... reach. i.e., it iterates in fwd order. (fixed)
many should be pure that aren't (dvec len) (fixed)
dvec needs 'view' (didn't bother)
the fold* suite is really messy when constness doesn't match up - maybe have one for each constness? (didn't bother)

Found during ICFP (#2928).
@ghost ghost assigned bblum Jul 14, 2012
@bblum
Copy link
Contributor Author

bblum commented Jul 17, 2012

156eceb

@bblum bblum closed this as completed Jul 17, 2012
@bblum bblum removed their assignment Jun 16, 2014
RalfJung pushed a commit to RalfJung/rust that referenced this issue Jun 29, 2023
@bors
Auto merge of rust-lang#2924 - RalfJung:rustup, r=RalfJung
15a6362 
Rustup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bblum