Docs feature banner will not show on top level docs when using glob export #120487
Labels
A-rustdoc-ui
Area: rustdoc UI (generated HTML)
C-bug
Category: This is a bug.
F-doc_cfg
`#![feature(doc_cfg)]`
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Comments
rustbot
added
the
needs-triage
|
Probably #113091, it shouldn't have affected glob re-exports but maybe did (cc @GuillaumeGomez). |
Nemo157
added
T-rustdoc
|
Taking a look. |
|
Same issue with a simple reexport: mod b {
#[doc(cfg(not(feature = "a")))]
#[cfg(not(feature = "a"))]
pub struct Test2;
}
pub use b::Test2; |
|
That's what #113091 was meant to do, it wasn't meant to affect globs though. |
|
I think there is another issue with how it's handled because nothing is listed on the item itself too:
|
|
Ok so it's the expected output for a non-glob reexport. I wrote the fix for glob reexports, just need to add tests. |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Jan 30, 2024
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Jan 30, 2024
…merge-bugfix, r=notriddle rustdoc: Correctly handle attribute merge if this is a glob reexport Fixes rust-lang#120487. The regression was introduced in rust-lang#113091. Only non-glob reexports should have been impacted. cc `@Nemo157` r? `@notriddle`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Jan 30, 2024
…merge-bugfix, r=notriddle rustdoc: Correctly handle attribute merge if this is a glob reexport Fixes rust-lang#120487. The regression was introduced in rust-lang#113091. Only non-glob reexports should have been impacted. cc ``@Nemo157`` r? ``@notriddle``
Nadrieril
added a commit
to Nadrieril/rust
that referenced
this issue
Jan 31, 2024
…merge-bugfix, r=notriddle rustdoc: Correctly handle attribute merge if this is a glob reexport Fixes rust-lang#120487. The regression was introduced in rust-lang#113091. Only non-glob reexports should have been impacted. cc ```@Nemo157``` r? ```@notriddle```
Nadrieril
added a commit
to Nadrieril/rust
that referenced
this issue
Jan 31, 2024
…merge-bugfix, r=notriddle rustdoc: Correctly handle attribute merge if this is a glob reexport Fixes rust-lang#120487. The regression was introduced in rust-lang#113091. Only non-glob reexports should have been impacted. cc ````@Nemo157```` r? ````@notriddle````
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jan 31, 2024
Rollup merge of rust-lang#120501 - GuillaumeGomez:glob-reexport-attr-merge-bugfix, r=notriddle rustdoc: Correctly handle attribute merge if this is a glob reexport Fixes rust-lang#120487. The regression was introduced in rust-lang#113091. Only non-glob reexports should have been impacted. cc `````@Nemo157````` r? `````@notriddle`````
|
@GuillaumeGomez Latest nightly fixed the issue for #![feature(doc_auto_cfg)]
mod a {
#[cfg(feature = "a")]
pub struct Test1;
}
pub use a::*;its last working version was also |
|
Noted. Sending a fix for it as well. :) |
|
Fixed in #120548. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Feb 13, 2024
…erge, r=GuillaumeGomez rustdoc: Fix handling of doc_auto_cfg feature for cfg attributes on glob reexport This is a follow-up of rust-lang#120501 and a part of rust-lang#120487. r? `@notriddle`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Feb 13, 2024
Rollup merge of rust-lang#120548 - GuillaumeGomez:glob-reexport-cfg-merge, r=GuillaumeGomez rustdoc: Fix handling of doc_auto_cfg feature for cfg attributes on glob reexport This is a follow-up of rust-lang#120501 and a part of rust-lang#120487. r? `@notriddle`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I tried this code:
I expected to see this happen:
Instead, this happened:
This is issue from
nightly-2023-12-16.First screenshot is ofnightly-2023-12-15and second is ofnightly-2023-12-16The text was updated successfully, but these errors were encountered: