Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for AArch64 SHA3 intrinsics #117225

Open
3 tasks
Amanieu opened this issue Oct 26, 2023 · 5 comments
Open
3 tasks

Tracking Issue for AArch64 SHA3 intrinsics #117225

Amanieu opened this issue Oct 26, 2023 · 5 comments
Labels
A-SIMD Area: SIMD (Single Instruction Multiple Data) C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. O-AArch64 Armv8-A or later processors in AArch64 mode T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@Amanieu
Copy link
Member

Amanieu commented Oct 26, 2023

Feature gate: #![feature(stdarch_neon_sha3)]

This is a tracking issue for NEON intrinsics under the sha3 feature.

Public API

// core::arch::aarch64

fn veor3q*(..);
fn vbcaxq*(..);
fn vrax1q*(..);
fn vsha512*(..);

Steps / History

  • Implementation: #...
  • Final comment period (FCP)1
  • Stabilization PR

Unresolved Questions

  • None yet.

Footnotes

  1. https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html ↩
@Amanieu Amanieu added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. labels Oct 26, 2023
@Amanieu Amanieu mentioned this issue Oct 26, 2023
Merged
@Jules-Bertholet
Copy link
Contributor

Jules-Bertholet commented Oct 26, 2023 •
edited
Loading

@rustbot label o-aarch64 a-simd

@rustbot rustbot added O-AArch64 Armv8-A or later processors in AArch64 mode A-SIMD Area: SIMD (Single Instruction Multiple Data) labels Oct 26, 2023
@zachs18 zachs18 mentioned this issue Feb 8, 2024
Closed
@Amanieu Amanieu mentioned this issue Mar 10, 2024
Closed
3 tasks
This was referenced Mar 12, 2024
Merged
Open
@tarcieri
Copy link
Contributor

I'm interested in helping stabilize vsha512*.

I saw vsha256* was stabilized in rust-lang/stdarch#1399. Is all that's needed a similar stabilization PR? (although possibly without the not(target_arch = "arm") gating since it's AArch64-specific anyway?)

@Amanieu
Copy link
Member Author

Amanieu commented Mar 12, 2024

Yes, just submit a stabilization PR and then we can start an FCP.

@tarcieri
Copy link
Contributor

It looks like since it's autogenerated code, stabilizing vsha512* would involve stabilizing all of stdarch_neon_sha3 by modifying this line, which I can open a PR for: https://github.com/rust-lang/stdarch/blob/3961d3b/crates/stdarch-gen-arm/src/main.rs#L532

tarcieri added a commit to tarcieri/rust-stdarch that referenced this issue Mar 13, 2024
@tarcieri
Stabilize AArch64 SHA3 intrinsics
2359b86 
See also: rust-lang/rust#117225
tarcieri added a commit to tarcieri/rust-stdarch that referenced this issue Mar 13, 2024
@tarcieri
Stabilize AArch64 SHA3 intrinsics
d12b01d 
See also: rust-lang/rust#117225
@tarcieri tarcieri mentioned this issue Mar 13, 2024
Merged
@tarcieri
Copy link
Contributor

Opened a PR: rust-lang/stdarch#1552

tarcieri added a commit to tarcieri/rust-stdarch that referenced this issue Mar 13, 2024
@tarcieri
Stabilize AArch64 SHA3 intrinsics
631eb00 
See also: rust-lang/rust#117225
tarcieri added a commit to tarcieri/rust-stdarch that referenced this issue Apr 11, 2024
@tarcieri
Stabilize AArch64 SHA3 intrinsics
4a5204f 
See also: rust-lang/rust#117225
Amanieu pushed a commit to rust-lang/stdarch that referenced this issue Apr 12, 2024
@tarcieri @Amanieu
Stabilize AArch64 SHA3 intrinsics
841733a 
See also: rust-lang/rust#117225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-SIMD Area: SIMD (Single Instruction Multiple Data) C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. O-AArch64 Armv8-A or later processors in AArch64 mode T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tarcieri @Amanieu @rustbot @Jules-Bertholet