Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend useless_ptr_null_checks to more functions #114442

Closed
est31 opened this issue Aug 3, 2023 · 0 comments · Fixed by #114494
Closed

Extend useless_ptr_null_checks to more functions #114442

est31 opened this issue Aug 3, 2023 · 0 comments · Fixed by #114494
Labels
A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@est31
Copy link
Member

est31 commented Aug 3, 2023

Filing an issue as #113657 has been merged and we now warn on a bunch of functions/casts that return raw pointers that will never be null. The standard library contains a larger set than the specified one though, as pointed out in this comment on the PR.

I think it would be good idea to add a #[rustc_return_non_null_ptr] attribute, and add it to the functions mentioned in the comment, then make the useless_ptr_null_checks lint check for that attribute.

cc @Urgau
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 3, 2023
@est31 est31 added A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Aug 3, 2023
@est31 est31 mentioned this issue Aug 5, 2023
Merged
@bors bors closed this as completed in 635c4a5 Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make useless_ptr_null_checks smarter about some std functions est31/rust
2 participants
@est31 @rustbot