Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create separate feature gate for #[track_caller] on async fn #110009

Closed
bryangarza opened this issue Apr 6, 2023 · 4 comments · Fixed by #112117
Closed

Create separate feature gate for #[track_caller] on async fn #110009

bryangarza opened this issue Apr 6, 2023 · 4 comments · Fixed by #112117
Assignees
@bryangarza
Labels
T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@bryangarza
Copy link
Contributor

bryangarza commented Apr 6, 2023 •
edited by rustbot
Loading

Currently, #[track_caller] on async fn depends on #![feature(closure_track_caller)].

We want to make this a separate feature gate now, so that #[track_caller] on async fn can be independently toggled on.

feature gate name: async_fn_track_caller

See comment at: #87417 (comment)
@bryangarza bryangarza changed the title Create separate feature flag for #[track_caller] on async fn Create separate feature gate for #[track_caller] on async fn Apr 6, 2023
@bryangarza bryangarza mentioned this issue Apr 6, 2023
Open
4 tasks
@bryangarza
Copy link
Contributor Author

@rustbot claim

@bryangarza
Copy link
Contributor Author

@rustbot label T-lang

@rustbot rustbot added the T-lang Relevant to the language team, which will review and decide on the PR/issue. label Apr 6, 2023
@tmandry
Copy link
Member

tmandry commented May 18, 2023

Friendly ping @bryangarza, are you still working on / planning to work on this?

@bryangarza
Copy link
Contributor Author

@tmandry I can work on it next week! Haven’t started yet.

@bryangarza bryangarza mentioned this issue May 30, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Aug 4, 2023
@bors
Auto merge of rust-lang#112117 - bryangarza:track-caller-feature-gate…
e173a8e 
…, r=compiler-errors

Add separate feature gate for async fn track caller

This patch adds a feature gate `async_fn_track_caller` that is separate from `closure_track_caller`. This is to allow enabling `async_fn_track_caller` separately.

Fixes rust-lang#110009
@bors bors closed this as completed in 673ab17 Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bryangarza bryangarza

Labels
T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add separate feature gate for async fn track caller bryangarza/rust
3 participants
@bryangarza @tmandry @rustbot