Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spin loop in MPSC channel #106804

Closed
albertlarsan68 opened this issue Jan 13, 2023 · 3 comments · Fixed by #106836
Closed

Remove spin loop in MPSC channel #106804

albertlarsan68 opened this issue Jan 13, 2023 · 3 comments · Fixed by #106836
Assignees
@rustbot
Labels
T-libs Relevant to the library team, which will review and decide on the PR/issue.

Comments

@albertlarsan68
Copy link
Member

albertlarsan68 commented Jan 13, 2023 •
edited by rustbot
Loading

Separately, I think the retry loop when sending a message should be removed (like we did with the similar loop in recv). The reasoning is the same: we don't want to waste CPU cycles spinning when trying to write to a full channel. Instead we should just go ahead and block immediately. But this can be a separate PR.

Originally posted by @Amanieu in #106701 (comment)

This issue has been assigned to @ibraheemdev via this comment.
@albertlarsan68
Copy link
Member Author

@rustbot claim

@Noratrieb Noratrieb added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jan 13, 2023
@marmeladema
Copy link
Contributor

Done in #106836 I believe

@albertlarsan68 albertlarsan68 mentioned this issue Jan 14, 2023
Merged
@albertlarsan68
Copy link
Member Author

@rustbot assign @ibraheemdev

@rustbot rustbot assigned rustbot and unassigned albertlarsan68 Jan 19, 2023
@bors bors closed this as completed in 35a8d6f Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustbot rustbot

Labels
T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove optimistic spinning from mpsc::SyncSender ibraheemdev/rust
4 participants
@marmeladema @rustbot @Noratrieb @albertlarsan68