-
Notifications
You must be signed in to change notification settings - Fork 12.5k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: rust-lang/rust
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f892202
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: rust-lang/rust
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7d6969b
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 8 commits
- 8 files changed
- 4 contributors
Commits on Feb 15, 2024
-
Add ASCII fast-path for
char::is_grapheme_extended
I discovered that `impl Debug for str` is quite slow because it ends up doing a `unicode_data::grapheme_extend::lookup` for each char, which ends up doing a binary search. This introduces a fast-path for ASCII chars which do not have this property. The `lookup` is thus completely gone from profiles.
Configuration menu - View commit details
-
Copy full SHA for 8eaaa6e - Browse repository at this point
Copy the full SHA 8eaaa6eView commit details
Commits on Mar 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b493613 - Browse repository at this point
Copy the full SHA b493613View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bebbf1 - Browse repository at this point
Copy the full SHA 9bebbf1View commit details
Commits on Mar 5, 2024
-
Assert that test names cannot contain dots
This is so that we can catch stray test output files, since test names without dots can form predictable patterns we can match on.
Configuration menu - View commit details
-
Copy full SHA for 53f48dd - Browse repository at this point
Copy the full SHA 53f48ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 247a080 - Browse repository at this point
Copy the full SHA 247a080View commit details -
Auto merge of #121138 - Swatinem:grapheme-extend-ascii, r=cuviper
Add ASCII fast-path for `char::is_grapheme_extended` I discovered that `impl Debug for str` is quite slow because it ends up doing a `unicode_data::grapheme_extend::lookup` for each char, which ends up doing a binary search. This introduces a fast-path for ASCII chars which do not have this property. The `lookup` is thus completely gone from profiles. --- As a followup, maybe it’s worth implementing this fast path directly in `unicode_data` so that it can check for the lower bound directly before going to a potentially expensive binary search.
Configuration menu - View commit details
-
Copy full SHA for bdde2a8 - Browse repository at this point
Copy the full SHA bdde2a8View commit details -
Auto merge of #121992 - jieyouxu:fix-tidy-unpaired-revision, r=onur-o…
…zkan tidy: split dots in filename not the entire path when checking for stray stdout/stderr files I committed a path crime by splitting the entire path on `.`, when I meant to split on the filename. This means that any parent folders which contain `.` will cause tidy failure. Added a regression test so that doesn't happen again. ### Follow-up - [ ] Adjust rustc-dev-guide to document assert on test name not containing dots. rust-lang/rustc-dev-guide#1927 Fixes #121986.
Configuration menu - View commit details
-
Copy full SHA for c7beecf - Browse repository at this point
Copy the full SHA c7beecfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d6969b - Browse repository at this point
Copy the full SHA 7d6969bView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff f892202...7d6969b