Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/rust
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f892202
Choose a base ref
...
head repository: rust-lang/rust
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7d6969b
Choose a head ref
  • 8 commits
  • 8 files changed
  • 4 contributors

Commits on Feb 15, 2024

  1. Add ASCII fast-path for char::is_grapheme_extended

    I discovered that `impl Debug for str` is quite slow because it ends up doing a `unicode_data::grapheme_extend::lookup` for each char, which ends up doing a binary search.
    
    This introduces a fast-path for ASCII chars which do not have this property.
    
    The `lookup` is thus completely gone from profiles.
    Swatinem committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    8eaaa6e View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Configuration menu
    Copy the full SHA
    b493613 View commit details
    Browse the repository at this point in the history
  2. Use Path::file_stem instead

    jieyouxu committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    9bebbf1 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Assert that test names cannot contain dots

    This is so that we can catch stray test output files, since test names
    without dots can form predictable patterns we can match on.
    jieyouxu committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    53f48dd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    247a080 View commit details
    Browse the repository at this point in the history
  3. Auto merge of #121138 - Swatinem:grapheme-extend-ascii, r=cuviper

    Add ASCII fast-path for `char::is_grapheme_extended`
    
    I discovered that `impl Debug for str` is quite slow because it ends up doing a `unicode_data::grapheme_extend::lookup` for each char, which ends up doing a binary search.
    
    This introduces a fast-path for ASCII chars which do not have this property.
    
    The `lookup` is thus completely gone from profiles.
    
    ---
    
    As a followup, maybe it’s worth implementing this fast path directly in `unicode_data` so that it can check for the lower bound directly before going to a potentially expensive binary search.
    bors committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    bdde2a8 View commit details
    Browse the repository at this point in the history
  4. Auto merge of #121992 - jieyouxu:fix-tidy-unpaired-revision, r=onur-o…

    …zkan
    
    tidy: split dots in filename not the entire path when checking for stray stdout/stderr files
    
    I committed a path crime by splitting the entire path on `.`, when I meant to split on the filename. This means that any parent folders which contain `.` will cause tidy failure. Added a regression test so that doesn't happen again.
    
    ### Follow-up
    
    - [ ] Adjust rustc-dev-guide to document assert on test name not containing dots. rust-lang/rustc-dev-guide#1927
    
    Fixes #121986.
    bors committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    c7beecf View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7d6969b View commit details
    Browse the repository at this point in the history
Loading