Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose implicit named arguments for formatting macros #2795

Merged
merged 9 commits into from
Jan 7, 2020
Merged

Propose implicit named arguments for formatting macros #2795

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift click to select a range
d1fb492
Propose implicit named parameters for formatting macros
davidhewitt Oct 28, 2019
46efff3
Extend discussion around interpolation and prior art
davidhewitt Oct 28, 2019
f9b720b
Correct PHP string interpolation syntax
davidhewitt Oct 30, 2019
2d44315
Fix typos
davidhewitt Nov 3, 2019
8ed9a11
Extend discussion of future work for `dotted.paths`
davidhewitt Nov 4, 2019
090b356
Fix typo: hygeiene -> hygiene
davidhewitt Nov 5, 2019
270bada
State precedence of implicit named arguments
davidhewitt Nov 8, 2019
1bd2bdc
Discuss hygiene with format_args!(expr)
davidhewitt Nov 8, 2019
ba36e80
Add discussion on `panic!("{foo}")`
davidhewitt Nov 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Correct PHP string interpolation syntax 
The examples provided had incorrectly merged Scala and PHP.
Scala's string interpolation is written `s"$foo"` whereas PHP is written `"$foo"`
  • Loading branch information
@davidhewitt
davidhewitt authored Oct 30, 2019
commit f9b720b37dda9d96e87c0640312263e1236903f7
5 changes: 4 additions & 1 deletion text/0000-format-args-implicit-identifiers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 255,11 @@ The following code would be the equivalent way to produce a new string combining
// Ruby
"#{greeting} #{person}"

// Scala / PHP
// Scala
s"$greeting $person"

// PHP
davidhewitt marked this conversation as resolved.
Show resolved Hide resolved
"$greeting $person"

It is the RFC author's experience that these interpolating mechanisms read easily from left-to-right and it is clear where each variable is being substituted into the format string.

Expand Down