Fix type_length_limit example. #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewjasper
approved these changes
May 28, 2021
|
thanks |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 9, 2021
Update books ## reference 4 commits in 9c68af3ce6ccca2395e1868addef26a0542e9ddd..8f598e2af6c25b4a7ee88ef6a8196d9b8ea50ca8 2021-05-24 09:53:32 -0700 to 2021-06-01 19:00:46 0100 - Add crate and module to glossary. (rust-lang/reference#1016) - Fix type_length_limit example. (rust-lang/reference#1026) - Rearrange HRTB grammar. (rust-lang/reference#1011) - Revert "Temporarily remove pat_param." (rust-lang/reference#1010) ## rustc-dev-guide 6 commits in 50de7f0682adc5d95ce858fe6318d19b4b951553..c8da5bfd1c7c71d90ef1646f5e0a9f6609d5c78a 2021-05-20 15:02:20 0200 to 2021-06-04 09:08:56 0200 - Fix some links (rust-lang/rustc-dev-guide#1137) - explain Miri engine vs Miri-the-tool - Add more information about no_hash query modifier. (rust-lang/rustc-dev-guide#1133) - improve section introduction - not all tools require waiting for a nightly release before they can be fixed - Describe the difference of rustc_lint vs rustc_lint_defs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing example for the
type_length_limitattribute wasn't failing as expected. Somewhere between 2020-09-18 and 2020-09-19 the old example stopped failing (maybe rust-lang/rust#72412 or rust-lang/rust#76575, I can't tell).I adjusted the example to require some recursion which now triggers the error. This is more similar to the existing test.
Additionally, since rust-lang/rust#68664,
ignorecan be removed and it should check the example now.