Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate incremental crate identity #726

Closed
1 of 3 tasks
Zoxc opened this issue Feb 26, 2024 · 2 comments
Closed
1 of 3 tasks

Separate incremental crate identity #726

Zoxc opened this issue Feb 26, 2024 · 2 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@Zoxc
Copy link

Zoxc commented Feb 26, 2024

Proposal

This proposes changing crate identity used for matching previous incremental compilation sessions to not depend on the crate name in the source code. Crate identity for incremental compilation would instead only be based on information in command line arguments.

The current scheme is problematic since we need to parse the crate before loading the previous compilation session. This is not ideal for performance and it also prevents moving of parsing into the query system.

This does not change the other uses of crate identity in the compiler.

This change would not affect the behavior of Cargo as it uses a separate incremental compilation directory per crate and thus has its own separate concept of crate identity. It may however affect non-Cargo users of incremental compilation.

#115693 is a related PR.

Mentors or Reviewers

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@Zoxc Zoxc added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Feb 26, 2024
@rustbot
Copy link
Collaborator

rustbot commented Feb 26, 2024

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Concerns or objections to the proposal should be discussed on Zulip and formally registered here by adding a comment with the following syntax:

@rustbot concern reason-for-concern 
<description of the concern>

Concerns can be lifted with:

@rustbot resolve reason-for-concern

See documentation at https://forge.rust-lang.org

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Feb 26, 2024
@oli-obk
Copy link
Contributor

oli-obk commented Feb 27, 2024

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Feb 27, 2024
@Zoxc Zoxc mentioned this issue Feb 28, 2024
Merged
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Feb 29, 2024
@petrochenkov petrochenkov mentioned this issue Mar 7, 2024
Open
@oli-obk oli-obk closed this as completed Mar 13, 2024
@oli-obk oli-obk added the major-change-accepted A major change proposal that was accepted label Mar 13, 2024
@rustbot rustbot added the to-announce Announce this issue on triage meeting label Mar 13, 2024
@fmease fmease removed the final-comment-period The FCP has started, most (if not all) team members are in agreement label Mar 13, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 13, 2024
@matthiaskrgr
Rollup merge of rust-lang#121764 - Zoxc:incr-sess-no-source, r=oli-obk
6948dc6 
Make incremental sessions identity no longer depend on the crate names provided by source code

This makes incremental sessions identity no longer depend on the crate names provided by source code, implementing
rust-lang/compiler-team#726.

r? `@oli-obk`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 13, 2024
@matthiaskrgr
Rollup merge of rust-lang#121764 - Zoxc:incr-sess-no-source, r=oli-obk
e4d89a8 
Make incremental sessions identity no longer depend on the crate names provided by source code

This makes incremental sessions identity no longer depend on the crate names provided by source code, implementing
rust-lang/compiler-team#726.

r? ``@oli-obk``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 14, 2024
@matthiaskrgr
Rollup merge of rust-lang#121764 - Zoxc:incr-sess-no-source, r=oli-obk
8d1aeed 
Make incremental sessions identity no longer depend on the crate names provided by source code

This makes incremental sessions identity no longer depend on the crate names provided by source code, implementing
rust-lang/compiler-team#726.

r? ```@oli-obk```
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Mar 14, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 14, 2024
@matthiaskrgr
Rollup merge of rust-lang#121764 - Zoxc:incr-sess-no-source, r=oli-obk
4dff106 
Make incremental sessions identity no longer depend on the crate names provided by source code

This makes incremental sessions identity no longer depend on the crate names provided by source code, implementing
rust-lang/compiler-team#726.

r? ````@oli-obk````
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 15, 2024
@rust-timer
Unrolled build for rust-lang#121764
6623c59 
Rollup merge of rust-lang#121764 - Zoxc:incr-sess-no-source, r=oli-obk

Make incremental sessions identity no longer depend on the crate names provided by source code

This makes incremental sessions identity no longer depend on the crate names provided by source code, implementing
rust-lang/compiler-team#726.

r? ````@oli-obk````
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Zoxc @oli-obk @apiraino @fmease @rustbot