Warn on unused patches. #6470
Merged
Warn on unused patches. #6470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Eh2406 (rust_highfive has picked a reviewer for you, use r? to override) |
|
My confidence is low that this is correct, or that the new message is clear enough. My original impression was that patches are typically temporary, and you'd always want to know if it's not working. However, sometimes people do clever things that I don't expect. |
|
Thanks for working on this! This looks like a good step in the correct direction. I don't know much about how the |
src/cargo/ops/resolve.rs
Outdated
| let warnings: Vec<String> = resolved | ||
| .unused_patches() | ||
| .iter() | ||
| .map(|pkgid| format!("Patch for `{}` did not match any packages.", pkgid)) |
There was a problem hiding this comment.
I might recommend s/did not match any packages/did not end up being used in the crate graph/
(or something like that, it must match in one way or another but the error here is that it didn't end up actually being use)
ehuss
force-pushed
the
warn-unused-patch
branch
from
1d74e49
to
7e43a11
Compare
ehuss
force-pushed
the
warn-unused-patch
branch
from
7e43a11
to
e35ecbe
Compare
|
@bors r=alexcrichton |
|
📌 Commit e35ecbe has been approved by |
bors
added a commit
that referenced
this pull request
Dec 22, 2018
Warn on unused patches. Adds a warning when a `[patch]` entry fails to match anything. I've hit this several times in the past, and it always takes me 5 minutes of confusion to figure out what's wrong. Fixes #6444
|
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
that referenced
this pull request
Dec 28, 2018
Fix new unused patch warning. The unused `[patch]` warning added in #6470 was misfiring if you build only a subset of a workspace that doesn't include the patch. I'm about 80% confident this new logic is correct. It addresses the scenario I discovered, and I tested a bunch of commands (generate-lockfile, update, etc.) to make sure they all work. However, the many ways that `resolve_with_previous` is called is tricky to ensure every scenario works correctly.
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Jan 4, 2019
Update cargo 24 commits in 0d1f1bbeabd5b43a7f3ecfa16540af8e76d5efb4..34320d212dca8cd27d06ce93c16c6151f46fcf2e 2018-12-19 14:45:14 0000 to 2019-01-03 19:12:38 0000 - Display environment variables for rustc commands (rust-lang/cargo#6492) - Fix a very minor race condition in `cargo fix`. (rust-lang/cargo#6515) - Add a high-level overview of how `fix` works. (rust-lang/cargo#6516) - Add dependency `registry` to `cargo metadata`. (rust-lang/cargo#6500) - Fix fingerprint calculation for patched deps. (rust-lang/cargo#6493) - serialize version directly (rust-lang/cargo#6512) - use DYLD_FALLBACK_LIBRARY_PATH for dylib_path_envvar on macOS (rust-lang/cargo#6355) - Fix error message when resolving dependencies (rust-lang/cargo#6510) - use PathBuf in cargo metadata (rust-lang/cargo#6511) - Fixed link to testsuite in CONTRIBUTING.md (rust-lang/cargo#6506) - Update display of contents of Cargo.toml (rust-lang/cargo#6501) - Update display of contents of Cargo.toml (rust-lang/cargo#6502) - Fixup cargo install's help message (rust-lang/cargo#6495) - testsuite: Require failing commands to check output. (rust-lang/cargo#6497) - Delete unnecessary 'return' (rust-lang/cargo#6496) - Fix new unused patch warning. (rust-lang/cargo#6494) - Some minor documentation changes. (rust-lang/cargo#6481) - Add `links` to `cargo metadata`. (rust-lang/cargo#6480) - Salvaged semver work (rust-lang/cargo#6476) - Warn on unused patches. (rust-lang/cargo#6470) - don't write a an incorrect rustc version to the fingerprint file (rust-lang/cargo#6473) - Rewrite `login` and registry cleanups. (rust-lang/cargo#6466) - [issue#6461] Fix cargo commands list (rust-lang/cargo#6462) - Restrict registry names to same style as package names. (rust-lang/cargo#6469)
bors
added a commit
that referenced
this pull request
May 21, 2020
Provide better error messages for a bad `patch`. This attempts to provide more user-friendly error messages for some situations with a bad `patch`. This is a follow-up to #8243. I think this more or less covers all the issues from #4678. I imagine there are other corner cases, but those will need to wait for another day. The main one I can think of is when the patch location is missing required features. Today you get a "blah was not used in the crate graph." warning, with some suggestions added in #6470, but it doesn't actually check if there is a feature mismatch. Closes #4678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a warning when a
[patch]entry fails to match anything.I've hit this several times in the past, and it always takes me
5 minutes of confusion to figure out what's wrong.
Fixes #6444