Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement base paths (RFC 3529) 2/n: unstable docs #14361

Closed
wants to merge 1 commit into from
Closed

Implement base paths (RFC 3529) 2/n: unstable docs #14361

wants to merge 1 commit into from

Conversation

dpaoliello
Copy link
Contributor

RFC: rust-lang/rfcs#3529
Tracking Issue: #14355

This PR documents the feature in the unstable book.

@rustbot
Copy link
Collaborator

rustbot commented Aug 6, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2024
@dpaoliello dpaoliello mentioned this pull request Aug 6, 2024
Open
10 tasks
epage
epage reviewed Aug 7, 2024
View reviewed changes
src/doc/src/reference/unstable.md
@@ -1570,6 1571,58 @@ implicit-features = "warn"
workspace = true
```

## Path Bases
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo we shouldn't merge functionality without the docs (except in some very specific circumstances). This fully belongs with the prior PR. I think what got confusing was my comment about the unstable docs. I was more suggesting something like b8a6846 or 4d09a6a (though in its own PR rather than a commit in a PR. Then as each PR adds functionality, the docs get updated to reflect that.

@dpaoliello
Copy link
Contributor Author

Merging with implementation PRs

@dpaoliello dpaoliello closed this Aug 8, 2024
@dpaoliello dpaoliello deleted the basepathdoc branch August 8, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epage epage epage left review comments

Assignees

@weihanglo weihanglo

Labels
A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dpaoliello @rustbot @epage @weihanglo