Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-1.77] Do not strip debuginfo by default for MSVC #13654

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

weihanglo
Copy link
Member

Stable backports:

In order to make CI pass, the following PRs are also cherry-picked:

@rustbot
Copy link
Collaborator

rustbot commented Mar 26, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Mar 26, 2024

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.77.0. Please double check that you specified the right target!

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 26, 2024
@epage
Copy link
Contributor

epage commented Mar 26, 2024

@bors r

@bors
Copy link
Collaborator

bors commented Mar 26, 2024

📌 Commit 2cb25a2 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2024
@weihanglo
Copy link
Member Author

Assumed we're going to release the new version of cargo crate, I bumped it to 0.78.1. Let me know if we don't want that.

@bors
Copy link
Collaborator

bors commented Mar 26, 2024

⌛ Testing commit 2cb25a2 with merge e52e360...

@weihanglo
Copy link
Member Author

check-version-bump job failed because of rustdoc.json version incompatibility. I am not too worried about that as we don't really have any semver-major change in this backport.

@bors
Copy link
Collaborator

bors commented Mar 26, 2024

☀️ Test successful - checks-actions
Approved by: epage
Pushing e52e360 to rust-1.77.0...

@bors bors merged commit e52e360 into rust-lang:rust-1.77.0 Mar 26, 2024
21 of 22 checks passed
@weihanglo weihanglo deleted the rust-1.77.0-backport branch March 26, 2024 18:31
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 27, 2024
…k-Simulacrum

[stable-1.77] cargo backport

1 commits in 3fe68eabf93cbf3772bbcad09a9206c783e2de3f..e52e360061cacbbeac79f7f1215a7a90b6f08442
2024-02-29 00:16:03  0000 to 2024-03-26 17:54:36  0000
- [stable-1.77] Do not strip debuginfo by default for MSVC (rust-lang/cargo#13654)

r? ghost
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 27, 2024
…k-Simulacrum

[stable-1.77] cargo backport

1 commits in 3fe68eabf93cbf3772bbcad09a9206c783e2de3f..e52e360061cacbbeac79f7f1215a7a90b6f08442
2024-02-29 00:16:03  0000 to 2024-03-26 17:54:36  0000
- [stable-1.77] Do not strip debuginfo by default for MSVC (rust-lang/cargo#13654)

r? ghost
@rustbot rustbot added this to the 1.77.1 milestone Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants