Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve word usage #13206

Merged
merged 1 commit into from
Dec 26, 2023
Merged

doc: improve word usage #13206

merged 1 commit into from
Dec 26, 2023

Conversation

shivdhar
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Dec 25, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 25, 2023
hi-rustin
hi-rustin reviewed Dec 26, 2023
View reviewed changes
Copy link
Member

@hi-rustin hi-rustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please offer additional context regarding the reason for your desire to make this change?

I have no strong option about changing it or not. Just curious the reason because the PR body is empty.

Thanks!

@weihanglo
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 26, 2023
@shivdhar
Copy link
Contributor Author

Hey, sure. The word fanciful isn't used correctly; perhaps the author meant fancier. In any case, complex seems to get the message across.

"Fanciful" definition from Merriam-Webster:

fanciful
adjective
fan·​ci·​ful ˈfan(t)-si-fəl 
Synonyms of fanciful
1
: marked by fancy or unrestrained imagination rather than by reason and experience
a fanciful person
a fanciful tale of a monster in the woods
2
: existing in fancy (see FANCY entry 2) only
a fanciful notion
the falsehoods about some fanciful secret treaties
—F. D. Roosevelt
3
: marked by or as if by fancy or whim
gave their children fanciful names

Probably not the appropriate word in this context?

weihanglo
weihanglo approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. As a non-native English speaker, complex is way better to understand. Thank you.

@weihanglo
Copy link
Member

@bors r

@bors
Copy link
Collaborator

bors commented Dec 26, 2023

📌 Commit d148d69 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Dec 26, 2023
@bors
Copy link
Collaborator

bors commented Dec 26, 2023

⌛ Testing commit d148d69 with merge d711ac0...

@shivdhar
Copy link
Contributor Author

Thank you, quite appreciate the swift workflow as well!

@bors
Copy link
Collaborator

bors commented Dec 26, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing d711ac0 to master...

@bors bors merged commit d711ac0 into rust-lang:master Dec 26, 2023
20 checks passed
@weihanglo weihanglo mentioned this pull request Dec 27, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 27, 2023
@bors
Auto merge of rust-lang#119334 - weihanglo:update-cargo, r=weihanglo
0961661 
Update cargo

7 commits in 363a2d11320faf531f6aacd1ea067c6bc08343b9..ac6bbb33293d8d424c17ecdb42af3aac25fb7295
2023-12-22 03:12:42  0000 to 2023-12-26 23:22:08  0000
- docs: fix link to nightly doc of cargo-util-schemas (rust-lang/cargo#13209)
- doc: improve word usage (rust-lang/cargo#13206)
- fix: clarify `--path` is the installation source not destination (rust-lang/cargo#13205)
- refactor: give some better examples for package ID spec (rust-lang/cargo#13202)
- chore: fix a typo (rust-lang/cargo#13201)
- Extend the build directive syntax with `cargo::` (rust-lang/cargo#12201)
- Rework `--check-cfg` generation comment (rust-lang/cargo#13195)

r? ghost
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 27, 2023
@bors
Auto merge of rust-lang#119334 - weihanglo:update-cargo, r=weihanglo
625c2c4 
Update cargo

7 commits in 363a2d11320faf531f6aacd1ea067c6bc08343b9..ac6bbb33293d8d424c17ecdb42af3aac25fb7295
2023-12-22 03:12:42  0000 to 2023-12-26 23:22:08  0000
- docs: fix link to nightly doc of cargo-util-schemas (rust-lang/cargo#13209)
- doc: improve word usage (rust-lang/cargo#13206)
- fix: clarify `--path` is the installation source not destination (rust-lang/cargo#13205)
- refactor: give some better examples for package ID spec (rust-lang/cargo#13202)
- chore: fix a typo (rust-lang/cargo#13201)
- Extend the build directive syntax with `cargo::` (rust-lang/cargo#12201)
- Rework `--check-cfg` generation comment (rust-lang/cargo#13195)

r? ghost
@rustbot rustbot added this to the 1.77.0 milestone Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hi-rustin hi-rustin hi-rustin left review comments

@weihanglo weihanglo weihanglo approved these changes

Assignees

@weihanglo weihanglo

Labels
A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shivdhar @rustbot @weihanglo @bors @hi-rustin