Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: differentiate defaults for split-debuginfo #12680

Merged
merged 1 commit into from
Sep 18, 2023
Merged

doc: differentiate defaults for split-debuginfo #12680

merged 1 commit into from
Sep 18, 2023

Conversation

tompscanlan
Copy link
Contributor

What does this PR try to resolve?

Documentation of different values for same named option in two different tools.
could fix #12243

How should we test and review this PR?

Editor review.

@rustbot
Copy link
Collaborator

rustbot commented Sep 16, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2023
Copy link
Member

@hi-rustin hi-rustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@weihanglo
Copy link
Member

People, thanks for the contribution and the review :)

@bors r=hi-rustin

@bors
Copy link
Collaborator

bors commented Sep 18, 2023

📌 Commit 95bf0ab has been approved by hi-rustin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2023
@bors
Copy link
Collaborator

bors commented Sep 18, 2023

⌛ Testing commit 95bf0ab with merge b4ddf95...

@bors
Copy link
Collaborator

bors commented Sep 18, 2023

☀️ Test successful - checks-actions
Approved by: hi-rustin
Pushing b4ddf95 to master...

@bors bors merged commit b4ddf95 into rust-lang:master Sep 18, 2023
20 checks passed
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 18, 2023
Update cargo

6 commits in d5336f813df39d476e61fc46daabb1446350660a..b4ddf95ad9954118ac0dae835f2966394ad04c02
2023-09-14 19:55:49  0000 to 2023-09-18 03:48:09  0000
- doc: differentiate defaults for split-debuginfo (rust-lang/cargo#12680)
- feat(cli): Add '-n' to dry-run (rust-lang/cargo#12660)
- feat: stabilize credential-process and registry-auth (rust-lang/cargo#12649)
- refactor: use `RegistryOrIndex` enum to replace two booleans (rust-lang/cargo#12677)
- doc: clarify caret requirements (rust-lang/cargo#12679)
- feat(pkgid): Allow incomplete versions when unambigious (rust-lang/cargo#12614)

r? ghost
@tompscanlan tompscanlan deleted the split-debuginfo branch September 18, 2023 11:20
@ehuss ehuss added this to the 1.74.0 milestone Sep 30, 2023
@tompscanlan tompscanlan restored the split-debuginfo branch October 15, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

split-debuginfo documentation contradiction
6 participants