Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Win32_System_Console feature since it is used #12016

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

lu-zero
Copy link
Contributor

@lu-zero lu-zero commented Apr 22, 2023

In src/cargo/core/shell.rs windows_sys::Win32::System::Console is used but the feature is not present in Cargo.toml.

I found it while updating cargo-c.

@rustbot
Copy link
Collaborator

rustbot commented Apr 22, 2023

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2023
@epage
Copy link
Contributor

epage commented Apr 23, 2023

@bors r

@bors
Copy link
Contributor

bors commented Apr 23, 2023

📌 Commit dfb4be8 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2023
@bors
Copy link
Contributor

bors commented Apr 23, 2023

⌛ Testing commit dfb4be8 with merge dcc4702...

@bors
Copy link
Contributor

bors commented Apr 23, 2023

☀️ Test successful - checks-actions
Approved by: epage
Pushing dcc4702 to master...

@bors bors merged commit dcc4702 into rust-lang:master Apr 23, 2023
@lu-zero lu-zero deleted the unbreak-master branch April 23, 2023 07:51
@ehuss
Copy link
Contributor

ehuss commented Apr 23, 2023

I'm not clear why this was needed. The feature seems to be enabled by is-terminal. Although it is good to make sure that all used features are listed, why was this causing a problem for you?

@lu-zero
Copy link
Contributor Author

lu-zero commented Apr 23, 2023

I'm using cargo as library and apparently I do not have anything that requires that feature.

ehuss pushed a commit to ehuss/cargo that referenced this pull request Apr 25, 2023
Add the Win32_System_Console feature since it is used

In `src/cargo/core/shell.rs` `windows_sys::Win32::System::Console` is used but the feature is not present in Cargo.toml.

I found it while updating `cargo-c`.
bors added a commit that referenced this pull request Apr 25, 2023
[beta-1.70] backport add the Win32_System_Console feature

This is a beta backport of #12016 which is required to build the cargo library on Windows.

This also includes #12011 to get CI passing.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 26, 2023
Update cargo

17 commits in de80432f04da61d98dcbbc1572598071718ccfd2..9e586fbd8b931494067144623b76c37d213b1ab6
2023-04-21 13:18:32  0000 to 2023-04-25 22:09:11  0000
- Update home dependency (rust-lang/cargo#12037)
- Warn instead of error in `cargo package` on empty `readme` or `license-file` in manifest (rust-lang/cargo#12036)
- Clarify documentation around test target setting. (rust-lang/cargo#12032)
- fix: apply `[env]` to target info discovery rustc (rust-lang/cargo#12029)
- CI: ensure intra links for all members are checked (rust-lang/cargo#12025)
- chore: make credential dependencies platform-specific (rust-lang/cargo#12027)
- CI: use `-p` to specify workspace members instead of `--manifest-path` (rust-lang/cargo#12024)
- ci: requires `test_gitoxide` and `lockfile` for both bors success and failure (rust-lang/cargo#12026)
- Update windows-sys (rust-lang/cargo#12021)
- Bump libc to 0.2.142 (rust-lang/cargo#12014)
- Update openssl-src to 111.25.3 1.1.1t (rust-lang/cargo#12005)
- Improve error message for empty dep (rust-lang/cargo#12001)
- Remove wrong url in benchsuite manifest. (rust-lang/cargo#12020)
- Bump versions of local crates (rust-lang/cargo#12019)
- Add the Win32_System_Console feature since it is used (rust-lang/cargo#12016)
- Update outdated crates.io URLs in publishing guide (rust-lang/cargo#12018)
- Allow named debuginfo options in Cargo.toml (rust-lang/cargo#11958)

r? `@ghost`
@ehuss ehuss added this to the 1.71.0 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants