-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beta-1.68] Backport fixes of split-debuginfo detection #11649
Conversation
…=weihanglo Fix split-debuginfo support detection ### What does this PR try to resolve? cargo assumed that if `-Csplit-debuginfo=packed` worked, all values would be correct. This however is not the case -- as of Rust 1.65.0, rustc supports `packed`, but not `unpacked` or `off` on Windows. Because of this, having `split-debuginfo="unpacked`" on Windows has caused builds to fail, as cargo assumed that the option is fine (`split-debuginfo=packed` worked), but rustc then failed when being passed `-Csplit-debuginfo=unpacked`. ### How should we test and review this PR? Consider an empty project with the following change to `Cargo.toml`: ```toml [profile.dev] split-debuginfo="unpacked" ``` `cargo 1.64.0 build` will work, but `cargo 1.65.0 build` will fail with the following error message: ``` PS C:\REDACTED> cargo build Compiling tmp v0.1.0 (C:\REDACTED) error: `-Csplit-debuginfo=unpacked` is unstable on this platform error: could not compile `tmp` due to previous error ``` With this patch and 1.65.0 rustc, cargo will ignore all `split-debuginfo` settings, but with rust-lang/rust#104104 rustc (approved, awaiting merge), it will properly detect supported values for `split-debuginfo` and only ignore those that are unsupported.
…=ehuss Reduce target info rustc query calls
r? @ehuss (rustbot has picked a reviewer for you, use r? to override) |
test: Update for clap 4.1.3 The latest clap release fixed a bug with the algorithm for providing suggestions, leading this suggestion to change.
Temporarily pin libgit2-sys. There are some issues with the most recent libgit2-sys 0.14.2 not working on Windows (libgit2/libgit2#6453 and libgit2/libgit2#6454). Until we figure out what to do with it, this pins the release to the previous version.
… r=epage Disable network SSH tests on windows. These tests have a high failure rate on Windows, so this disables them for now. I don't know exactly why they are failing. If I had to take a wild guess, I would suspect the use of WinCNG for the SSH backend, which may mean it is out of our control.
@bors r |
💔 Test failed - checks-actions |
@bors retry GitHub Actions has encountered an internal error when running your job. |
By the way, when we backport we are often required to backport unrelated PRs just to make CI happy, since we don't commit Cargo.lock. It may also make |
☀️ Test successful - checks-actions |
1 commits in 985d561f0bb9b76ec043a2b12511790ec7a2b954..0762e3bbdb6fa64b6859154199ec47d6c90c731c 2023-01-20 14:39:28 0000 to 2023-01-30 22:07:51 0000 - [beta-1.68] Backport fixes of split-debuginfo detection (rust-lang/cargo#11649)
[beta] Cargo 1.68.0 backports 1 commits in 985d561f0bb9b76ec043a2b12511790ec7a2b954..0762e3bbdb6fa64b6859154199ec47d6c90c731c 2023-01-20 14:39:28 0000 to 2023-01-30 22:07:51 0000 - [beta-1.68] Backport fixes of split-debuginfo detection (rust-lang/cargo#11649) r? `@ehuss`
Beta backports:
In order to make CI pass, the following PR are also cherry-picked: