Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/cargo
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: baf606a
Choose a base ref
...
head repository: rust-lang/cargo
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 511beaa
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Jan 19, 2024

  1. test: verify runner doesn't inherit jobserver

    @weihanglo
    weihanglo committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    ac1dc0b View commit details
    Browse the repository at this point in the history

  2. feat: inherit jobserver from env for all kinds of runner 

    External subcommands are already able to inherit the jobserver from
env since #10511. However, users reported that they've expected
`cargo run` to behave the same as external subcommands.

A popular example "cargo-xtask" pattern is used as scripting to run
arbitrary tasks. Users may want to invoke `cargo run` from Make and
expect some parallelism. This PR provides such an ability to the
general `target.<...>.runner`, which affects `cargo test`,
`cargo bench`, and `cargo run`.

Note that this PR doesn't create any jobserver client if there is no
existing jobserver from the environment. Nor `-j`/`--jobs` would create
a new client. Reasons for this decision:

* There might be crates don't want the jobserver to pollute their
  file descriptors, although they might be rare
* Creating a jobsever driver with the new FIFO named pipe style is not
  yet supported as of `[email protected]`. Once we can create a named
  pipe-based jobserver, it will be less risky and inheritance by
  default can be implemented.
    @weihanglo
    weihanglo committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    511beaa View commit details
    Browse the repository at this point in the history
Loading