Bug fix: correctly handle spaces in /proc/pid/maps pathnames #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasonRemaley
force-pushed
the
pathname-with-spaces
branch
from
6294cb5
to
2f2e9f9
Compare
|
Below is the size of a hello-world Rust program linked with libstd with backtrace. Original binary size: 518896B |
1 similar comment
|
Below is the size of a hello-world Rust program linked with libstd with backtrace. Original binary size: 518896B |
|
Side note--I tried to make the least invasive change possible since I'm not familiar with the codebase. That being said, is parsing If I'm reading the code correctly it's parsing the whole thing just to get the path to the main program. I would think there are simpler ways to get that info, but it's possible I'm missing something! [EDIT] Okay yeah--you could open |
|
Edit: Looks like you are right. It seems to only be used for the current executable and not shared libraries. |
|
There's an edge case where explicitly running ld.so gives the wrong path; see #488 |
klensy
reviewed
Jul 24, 2023
klensy
reviewed
Jul 24, 2023
klensy
reviewed
Jul 24, 2023
|
Below is the size of a hello-world Rust program linked with libstd with backtrace. Original binary size: 518896B |
klensy
reviewed
Jul 24, 2023
|
Below is the size of a hello-world Rust program linked with libstd with backtrace. Original binary size: 518896B |
|
Below is the size of a hello-world Rust program linked with libstd with backtrace. Original binary size: 518896B |
Wasn't aware of this, thanks for the link! |
|
Below is the size of a hello-world Rust program linked with libstd with backtrace. Original binary size: 518896B |
MasonRemaley
force-pushed
the
pathname-with-spaces
branch
from
015cdb8
to
aeb25db
Compare
|
Below is the size of a hello-world Rust program linked with libstd with backtrace. Original binary size: 518904B |
|
Looking at https://github.com/torvalds/linux/blob/18b44bc5a67275641fb26f2c54ba7eef80ac5950/fs/proc/task_mmu.c#L254 i think that multiple spaces isn't possible anywhere except around pathname? |
|
Below is the size of a hello-world Rust program linked with libstd with backtrace. Original binary size: 519500B |
MasonRemaley
force-pushed
the
pathname-with-spaces
branch
from
52dc969
to
aeb25db
Compare
|
Below is the size of a hello-world Rust program linked with libstd with backtrace. Original binary size: 519500B |
I'm being intentionally forgiving-- If my game crashes most players will just refund it, but assuming they consent I'll at least get a stack trace so I can fix it for the next person. If some day Linux decides to start aligning other elements by column too, I don't want to end up with a nightmare where I have to drop everything to figure out why my stack traces are failing before missing too much debug info. [EDIT] Clarifying to make this PR easier to review--backtrace-rs does fail today on Linux on any executable stored at a path containing a space, this PR fixes that. The above discussion is just about how forgiving the parser should be, it's not questioning whether this fix is necessary. |
There was a problem hiding this comment.
Oh hey, thank you so much!
- Yes, as discussed, it unfortunately is necessary to parse
proc/${pid}/mapsdue to the "fun" edge-cases if we want this backtrace to be consistently correct. It's acceptable to throw away more data than we currently throw away and adjust strictness, but not to avoid parsing, as avoiding parsing opens up far more problems than it solves. Case in point: the parse wasn't even right. - Unless we find some other way around the edge-cases (and I'm not confident ld.so is the only one!). I won't ask you to waste your time on that, however.
- Yes, I agree that we don't need to require strict consistency in spacing with the existing format. There's no need to be too brittle, and even if the rendering of
/proc/*/mapschanges, libstd will be expected to have its backtrace work consistently across all kernel versions.
This PR looks great overall! I just see a few silly nits.
Co-authored-by: Jubilee <46493976 [email protected]>
Co-authored-by: Jubilee <46493976 [email protected]>
Co-authored-by: Jubilee <46493976 [email protected]>
|
Below is the size of a hello-world Rust program linked with libstd with backtrace. Original binary size: 518984B |
2 similar comments
|
Below is the size of a hello-world Rust program linked with libstd with backtrace. Original binary size: 518984B |
|
Below is the size of a hello-world Rust program linked with libstd with backtrace. Original binary size: 518984B |
You're welcome! :)
That makes sense!
Thanks! Merged your suggestions--apologies for the typos! |
|
Hey! Just checking in to see if you need any other changes for this to be mergeable. :) |
workingjubilee
approved these changes
Aug 18, 2023
|
Haha no worries, glad to get the fix in! |
kodiakhq bot
referenced
this pull request
in X-oss-byte/Canary-nextjs
May 1, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [backtrace](https://togithub.com/rust-lang/backtrace-rs) | dependencies | patch | `0.3` -> `0.3.71` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>rust-lang/backtrace-rs (backtrace)</summary> ### [`v0.3.71`](https://togithub.com/rust-lang/backtrace-rs/releases/tag/0.3.71) [Compare Source](https://togithub.com/rust-lang/backtrace-rs/compare/0.3.70...0.3.71) This is mostly CI changes, with a very mild bump to our effective cc crate version recorded, and a small modification to a previous changeset to allow backtrace to run at its current checked-in MSRV on Windows. Sorry about that! We will be getting 0.3.70 yanked shortly. ##### What's Changed - Make sgx functions exist with cfg(miri) by [@​saethlin](https://togithub.com/saethlin) in [https://github.com/rust-lang/backtrace-rs/pull/591](https://togithub.com/rust-lang/backtrace-rs/pull/591) - Update version of cc crate by [@​jfgoog](https://togithub.com/jfgoog) in [https://github.com/rust-lang/backtrace-rs/pull/592](https://togithub.com/rust-lang/backtrace-rs/pull/592) - Pull back MSRV on Windows by [@​workingjubilee](https://togithub.com/workingjubilee) in [https://github.com/rust-lang/backtrace-rs/pull/598](https://togithub.com/rust-lang/backtrace-rs/pull/598) - Force frame pointers on all i686 tests by [@​workingjubilee](https://togithub.com/workingjubilee) in [https://github.com/rust-lang/backtrace-rs/pull/601](https://togithub.com/rust-lang/backtrace-rs/pull/601) - Use rustc from stage0 instead of stage0-sysroot by [@​Nilstrieb](https://togithub.com/Nilstrieb) in [https://github.com/rust-lang/backtrace-rs/pull/602](https://togithub.com/rust-lang/backtrace-rs/pull/602) - Cut backtrace 0.3.71 by [@​workingjubilee](https://togithub.com/workingjubilee) in [https://github.com/rust-lang/backtrace-rs/pull/599](https://togithub.com/rust-lang/backtrace-rs/pull/599) ##### New Contributors - [@​jfgoog](https://togithub.com/jfgoog) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/592](https://togithub.com/rust-lang/backtrace-rs/pull/592) - [@​Nilstrieb](https://togithub.com/Nilstrieb) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/602](https://togithub.com/rust-lang/backtrace-rs/pull/602) **Full Changelog**: rust-lang/backtrace-rs@0.3.70...0.3.71 ### [`v0.3.70`](https://togithub.com/rust-lang/backtrace-rs/releases/tag/0.3.70) [Compare Source](https://togithub.com/rust-lang/backtrace-rs/compare/0.3.69...0.3.70) ##### New API - A `BacktraceFrame` can now have `resolve(&mut self)` called on it thanks to [@​fraillt](https://togithub.com/fraillt) in [https://github.com/rust-lang/backtrace-rs/pull/526](https://togithub.com/rust-lang/backtrace-rs/pull/526) ##### Platform Support We added support for new platforms in this release! - Thanks to [@​bzEq](https://togithub.com/bzEq) in [https://github.com/rust-lang/backtrace-rs/pull/508](https://togithub.com/rust-lang/backtrace-rs/pull/508) we now have AIX support! - Thanks to [@​sthibaul](https://togithub.com/sthibaul) in [https://github.com/rust-lang/backtrace-rs/pull/567](https://togithub.com/rust-lang/backtrace-rs/pull/567) we now have GNU/Hurd support! - Thanks to [@​dpaoliello](https://togithub.com/dpaoliello) in [https://github.com/rust-lang/backtrace-rs/pull/587](https://togithub.com/rust-lang/backtrace-rs/pull/587) we now support "emulation-compatible" AArch64 Windows (aka arm64ec) ##### Windows - Rewrite msvc backtrace support to be much faster on 64-bit platforms by [@​wesleywiser](https://togithub.com/wesleywiser) in [https://github.com/rust-lang/backtrace-rs/pull/569](https://togithub.com/rust-lang/backtrace-rs/pull/569) - Fix i686-pc-windows-gnu missing dbghelp module by [@​wesleywiser](https://togithub.com/wesleywiser) in [https://github.com/rust-lang/backtrace-rs/pull/571](https://togithub.com/rust-lang/backtrace-rs/pull/571) - Fix build errors on `thumbv7a-*-windows-msvc` targets by [@​kleisauke](https://togithub.com/kleisauke) in [https://github.com/rust-lang/backtrace-rs/pull/573](https://togithub.com/rust-lang/backtrace-rs/pull/573) - Fix panic in backtrace symbolication on win7 by [@​roblabla](https://togithub.com/roblabla) in [https://github.com/rust-lang/backtrace-rs/pull/578](https://togithub.com/rust-lang/backtrace-rs/pull/578) - remove few unused windows ffi fn by [@​klensy](https://togithub.com/klensy) in [https://github.com/rust-lang/backtrace-rs/pull/576](https://togithub.com/rust-lang/backtrace-rs/pull/576) - Make dbghelp look for PDBs next to their exe/dll. by [@​michaelwoerister](https://togithub.com/michaelwoerister) in [https://github.com/rust-lang/backtrace-rs/pull/584](https://togithub.com/rust-lang/backtrace-rs/pull/584) - Revert 32-bit dbghelp to a version WINE (presumably) likes by [@​ChrisDenton](https://togithub.com/ChrisDenton) in [https://github.com/rust-lang/backtrace-rs/pull/588](https://togithub.com/rust-lang/backtrace-rs/pull/588) - Update for Win10 by [@​ChrisDenton](https://togithub.com/ChrisDenton) in [https://github.com/rust-lang/backtrace-rs/pull/589](https://togithub.com/rust-lang/backtrace-rs/pull/589) ##### SGX Thanks to - Adjust frame IP in SGX relative to image base by [@​mzohreva](https://togithub.com/mzohreva) in [https://github.com/rust-lang/backtrace-rs/pull/566](https://togithub.com/rust-lang/backtrace-rs/pull/566) ##### Internals We did a bunch more work on our CI and internal cleanups - Modularise CI workflow and validate outputs for binary size checks. by [@​detly](https://togithub.com/detly) in [https://github.com/rust-lang/backtrace-rs/pull/549](https://togithub.com/rust-lang/backtrace-rs/pull/549) - Commit Cargo.lock by [@​bjorn3](https://togithub.com/bjorn3) in [https://github.com/rust-lang/backtrace-rs/pull/562](https://togithub.com/rust-lang/backtrace-rs/pull/562) - Enable calling build.rs externally v2 by [@​pitaj](https://togithub.com/pitaj) in [https://github.com/rust-lang/backtrace-rs/pull/568](https://togithub.com/rust-lang/backtrace-rs/pull/568) - Upgrade to 2021 ed and inline panics by [@​nyurik](https://togithub.com/nyurik) in [https://github.com/rust-lang/backtrace-rs/pull/538](https://togithub.com/rust-lang/backtrace-rs/pull/538) - Fix deny(unused) of an unused import with SGX Miri by [@​saethlin](https://togithub.com/saethlin) in [https://github.com/rust-lang/backtrace-rs/pull/581](https://togithub.com/rust-lang/backtrace-rs/pull/581) - Fix unused_imports warning on latest nightly by [@​ChrisDenton](https://togithub.com/ChrisDenton) in [https://github.com/rust-lang/backtrace-rs/pull/575](https://togithub.com/rust-lang/backtrace-rs/pull/575) - Fix CI by [@​saethlin](https://togithub.com/saethlin) in [https://github.com/rust-lang/backtrace-rs/pull/582](https://togithub.com/rust-lang/backtrace-rs/pull/582) - Use `addr_of!` by [@​GrigorenkoPV](https://togithub.com/GrigorenkoPV) in [https://github.com/rust-lang/backtrace-rs/pull/585](https://togithub.com/rust-lang/backtrace-rs/pull/585) - Write down MSRV policy by [@​workingjubilee](https://togithub.com/workingjubilee) in [https://github.com/rust-lang/backtrace-rs/pull/561](https://togithub.com/rust-lang/backtrace-rs/pull/561) - Apply clippy::uninlined_format_args fixes by [@​nyurik](https://togithub.com/nyurik) in [https://github.com/rust-lang/backtrace-rs/pull/486](https://togithub.com/rust-lang/backtrace-rs/pull/486) - ignore clippy lints in `symbolize/gimli/stash.rs` by [@​onur-ozkan](https://togithub.com/onur-ozkan) in [https://github.com/rust-lang/backtrace-rs/pull/586](https://togithub.com/rust-lang/backtrace-rs/pull/586) ##### New Contributors - [@​nyurik](https://togithub.com/nyurik) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/538](https://togithub.com/rust-lang/backtrace-rs/pull/538) - [@​bzEq](https://togithub.com/bzEq) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/508](https://togithub.com/rust-lang/backtrace-rs/pull/508) - [@​bjorn3](https://togithub.com/bjorn3) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/562](https://togithub.com/rust-lang/backtrace-rs/pull/562) - [@​sthibaul](https://togithub.com/sthibaul) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/567](https://togithub.com/rust-lang/backtrace-rs/pull/567) - [@​mzohreva](https://togithub.com/mzohreva) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/566](https://togithub.com/rust-lang/backtrace-rs/pull/566) - [@​wesleywiser](https://togithub.com/wesleywiser) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/569](https://togithub.com/rust-lang/backtrace-rs/pull/569) - [@​kleisauke](https://togithub.com/kleisauke) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/573](https://togithub.com/rust-lang/backtrace-rs/pull/573) - [@​roblabla](https://togithub.com/roblabla) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/578](https://togithub.com/rust-lang/backtrace-rs/pull/578) - [@​michaelwoerister](https://togithub.com/michaelwoerister) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/584](https://togithub.com/rust-lang/backtrace-rs/pull/584) - [@​dpaoliello](https://togithub.com/dpaoliello) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/587](https://togithub.com/rust-lang/backtrace-rs/pull/587) - [@​GrigorenkoPV](https://togithub.com/GrigorenkoPV) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/585](https://togithub.com/rust-lang/backtrace-rs/pull/585) - [@​fraillt](https://togithub.com/fraillt) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/526](https://togithub.com/rust-lang/backtrace-rs/pull/526) - [@​onur-ozkan](https://togithub.com/onur-ozkan) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/586](https://togithub.com/rust-lang/backtrace-rs/pull/586) **Full Changelog**: rust-lang/backtrace-rs@0.3.69...0.3.70 ### [`v0.3.69`](https://togithub.com/rust-lang/backtrace-rs/releases/tag/0.3.69) [Compare Source](https://togithub.com/rust-lang/backtrace-rs/compare/0.3.68...0.3.69) Thank you everyone for contributing to a very nice release! ##### Tracking Binary Size As backtrace-rs is compiled into every single Rust program, we have begun tracking its binary size in order to find ways to reduce its impact on programs that only minimally use backtraces over time. This change is mostly relevant to this crate's CI, and has been implemented by [@​Kobzol](https://togithub.com/Kobzol) and [@​detly](https://togithub.com/detly) over PRs [#​542](https://togithub.com/rust-lang/backtrace-rs/issues/542), [#​544](https://togithub.com/rust-lang/backtrace-rs/issues/544), [#​546](https://togithub.com/rust-lang/backtrace-rs/issues/546), and [#​550](https://togithub.com/rust-lang/backtrace-rs/issues/550)! ##### Platform-Specific Fixes As usual, the majority of PRs for this release only affect 1 or 2 platforms. Technically, even the binary-size tracking is only implemented to track binary size on `x86_64-unknown-linux-gnu`. ##### fuchsia Backtraces for Fuchsia will now uses extended symbolization thanks to [@​liudangyi](https://togithub.com/liudangyi) in [https://github.com/rust-lang/backtrace-rs/pull/559](https://togithub.com/rust-lang/backtrace-rs/pull/559) ##### unix (with `procfs`) Many Unix-y platforms support `/proc`, including Linux and FreeBSD, but not OpenBSD. For those which do, backtrace uses `/proc/self/maps` to assist in recovering the trace. We did not parse the output of `/proc/self/maps` in a way that accounted for the fact that it may have spaces in path names, but this was fixed thanks to [@​MasonRemaley](https://togithub.com/MasonRemaley) in [https://github.com/rust-lang/backtrace-rs/pull/553](https://togithub.com/rust-lang/backtrace-rs/pull/553) ##### windows-msvc Some changes that should help binary size specifically on Windows MSVC targets, or at least compile times, have already been implemented, thanks to [@​klensy](https://togithub.com/klensy) in [https://github.com/rust-lang/backtrace-rs/pull/543](https://togithub.com/rust-lang/backtrace-rs/pull/543) omitting compiling-in ELF backtrace capabilities. We don't have full binary size tracking for all major supported operating systems yet, so we believe this is worth 30KiB but that's more of an estimate than hard stats. ##### Dependency Management - Update addr2line and object dependencies by [@​philipc](https://togithub.com/philipc) in [https://github.com/rust-lang/backtrace-rs/pull/557](https://togithub.com/rust-lang/backtrace-rs/pull/557) - Exclude ci directory from packaged crate by [@​mulkieran](https://togithub.com/mulkieran) in [https://github.com/rust-lang/backtrace-rs/pull/555](https://togithub.com/rust-lang/backtrace-rs/pull/555) - Enable calling build.rs directly from std/build.rs by [@​pitaj](https://togithub.com/pitaj) in [https://github.com/rust-lang/backtrace-rs/pull/556](https://togithub.com/rust-lang/backtrace-rs/pull/556) ##### New Contributors - [@​Kobzol](https://togithub.com/Kobzol) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/542](https://togithub.com/rust-lang/backtrace-rs/pull/542) - [@​detly](https://togithub.com/detly) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/550](https://togithub.com/rust-lang/backtrace-rs/pull/550) - [@​liudangyi](https://togithub.com/liudangyi) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/559](https://togithub.com/rust-lang/backtrace-rs/pull/559) - [@​MasonRemaley](https://togithub.com/MasonRemaley) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/553](https://togithub.com/rust-lang/backtrace-rs/pull/553) - [@​mulkieran](https://togithub.com/mulkieran) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/555](https://togithub.com/rust-lang/backtrace-rs/pull/555) - [@​pitaj](https://togithub.com/pitaj) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/556](https://togithub.com/rust-lang/backtrace-rs/pull/556) - [@​klensy](https://togithub.com/klensy) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/543](https://togithub.com/rust-lang/backtrace-rs/pull/543) **Full Changelog**: rust-lang/backtrace-rs@0.3.68...0.3.69 ### [`v0.3.68`](https://togithub.com/rust-lang/backtrace-rs/releases/tag/0.3.68) [Compare Source](https://togithub.com/rust-lang/backtrace-rs/compare/0.3.67...0.3.68) A bunch of behind-the-scenes work on upgrading CI has finally got things to a place where we can do confident releases again, so hopefully the next backtrace version will not take 6 months! Thanks to everyone who contributed to that! Most of the user-facing changes are about dependency updates and consequent improved platform compatibility, including with split DWARF. A few new functions on BacktraceFmt should also make it easier to inject additional text into backtrace's output. - Adapt to new Fuchsia target name by [@​flba-eb](https://togithub.com/flba-eb) in [https://github.com/rust-lang/backtrace-rs/pull/509](https://togithub.com/rust-lang/backtrace-rs/pull/509) - armv7 PSVita OS support by [@​nikarh](https://togithub.com/nikarh) in [https://github.com/rust-lang/backtrace-rs/pull/523](https://togithub.com/rust-lang/backtrace-rs/pull/523) - Upgrade addr2line and properly handle split DWARF on Linux by [@​khuey](https://togithub.com/khuey) in [https://github.com/rust-lang/backtrace-rs/pull/513](https://togithub.com/rust-lang/backtrace-rs/pull/513) - deps: update miniz_oxide to 0.7 by [@​poliorcetics](https://togithub.com/poliorcetics) in [https://github.com/rust-lang/backtrace-rs/pull/521](https://togithub.com/rust-lang/backtrace-rs/pull/521) - Add print in BacktraceFmt by [@​chenyukang](https://togithub.com/chenyukang) in [https://github.com/rust-lang/backtrace-rs/pull/527](https://togithub.com/rust-lang/backtrace-rs/pull/527) - Bump object to 0.31 by [@​lnicola](https://togithub.com/lnicola) in [https://github.com/rust-lang/backtrace-rs/pull/522](https://togithub.com/rust-lang/backtrace-rs/pull/522) - Add an exception for QNX Neutrino 7.0 as a 'no-op' platform by [@​samkearney](https://togithub.com/samkearney) in [https://github.com/rust-lang/backtrace-rs/pull/529](https://togithub.com/rust-lang/backtrace-rs/pull/529) - Use mmap64 on Linux. by [@​mikebenfield](https://togithub.com/mikebenfield) in [https://github.com/rust-lang/backtrace-rs/pull/501](https://togithub.com/rust-lang/backtrace-rs/pull/501) - dbghlp: Make mutex name unique to the process by [@​ChrisDenton](https://togithub.com/ChrisDenton) in [https://github.com/rust-lang/backtrace-rs/pull/518](https://togithub.com/rust-lang/backtrace-rs/pull/518) - gimli add netbsd to handle dl_iterate_phdr as well. by [@​devnexen](https://togithub.com/devnexen) in [https://github.com/rust-lang/backtrace-rs/pull/512](https://togithub.com/rust-lang/backtrace-rs/pull/512) - Add other apple targets to libunwind workaround by [@​thomcc](https://togithub.com/thomcc) in [https://github.com/rust-lang/backtrace-rs/pull/516](https://togithub.com/rust-lang/backtrace-rs/pull/516) - Add fmt method for BacktraceFmt by [@​chenyukang](https://togithub.com/chenyukang) in [https://github.com/rust-lang/backtrace-rs/pull/532](https://togithub.com/rust-lang/backtrace-rs/pull/532) ##### New Contributors - [@​bwmf2](https://togithub.com/bwmf2) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/515](https://togithub.com/rust-lang/backtrace-rs/pull/515) - [@​flba-eb](https://togithub.com/flba-eb) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/509](https://togithub.com/rust-lang/backtrace-rs/pull/509) - [@​nikarh](https://togithub.com/nikarh) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/523](https://togithub.com/rust-lang/backtrace-rs/pull/523) - [@​poliorcetics](https://togithub.com/poliorcetics) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/521](https://togithub.com/rust-lang/backtrace-rs/pull/521) - [@​GuillaumeGomez](https://togithub.com/GuillaumeGomez) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/524](https://togithub.com/rust-lang/backtrace-rs/pull/524) - [@​chenyukang](https://togithub.com/chenyukang) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/527](https://togithub.com/rust-lang/backtrace-rs/pull/527) - [@​lnicola](https://togithub.com/lnicola) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/522](https://togithub.com/rust-lang/backtrace-rs/pull/522) - [@​samkearney](https://togithub.com/samkearney) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/529](https://togithub.com/rust-lang/backtrace-rs/pull/529) - [@​mikebenfield](https://togithub.com/mikebenfield) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/501](https://togithub.com/rust-lang/backtrace-rs/pull/501) - [@​devnexen](https://togithub.com/devnexen) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/512](https://togithub.com/rust-lang/backtrace-rs/pull/512) - [@​thomcc](https://togithub.com/thomcc) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/516](https://togithub.com/rust-lang/backtrace-rs/pull/516) - [@​workingjubilee](https://togithub.com/workingjubilee) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/533](https://togithub.com/rust-lang/backtrace-rs/pull/533) - [@​chriswailes](https://togithub.com/chriswailes) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/534](https://togithub.com/rust-lang/backtrace-rs/pull/534) **Full Changelog**: rust-lang/backtrace-rs@0.3.67...0.3.68 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Canary-nextjs).
](https://renovatebot.com){kind=link}
kodiakhq bot
referenced
this pull request
in X-oss-byte/Nextjs
May 1, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [backtrace](https://togithub.com/rust-lang/backtrace-rs) | dependencies | patch | `0.3` -> `0.3.71` | --- ### Release Notes <details> <summary>rust-lang/backtrace-rs (backtrace)</summary> ### [`v0.3.71`](https://togithub.com/rust-lang/backtrace-rs/releases/tag/0.3.71) [Compare Source](https://togithub.com/rust-lang/backtrace-rs/compare/0.3.70...0.3.71) This is mostly CI changes, with a very mild bump to our effective cc crate version recorded, and a small modification to a previous changeset to allow backtrace to run at its current checked-in MSRV on Windows. Sorry about that! We will be getting 0.3.70 yanked shortly. ##### What's Changed - Make sgx functions exist with cfg(miri) by [@​saethlin](https://togithub.com/saethlin) in [https://github.com/rust-lang/backtrace-rs/pull/591](https://togithub.com/rust-lang/backtrace-rs/pull/591) - Update version of cc crate by [@​jfgoog](https://togithub.com/jfgoog) in [https://github.com/rust-lang/backtrace-rs/pull/592](https://togithub.com/rust-lang/backtrace-rs/pull/592) - Pull back MSRV on Windows by [@​workingjubilee](https://togithub.com/workingjubilee) in [https://github.com/rust-lang/backtrace-rs/pull/598](https://togithub.com/rust-lang/backtrace-rs/pull/598) - Force frame pointers on all i686 tests by [@​workingjubilee](https://togithub.com/workingjubilee) in [https://github.com/rust-lang/backtrace-rs/pull/601](https://togithub.com/rust-lang/backtrace-rs/pull/601) - Use rustc from stage0 instead of stage0-sysroot by [@​Nilstrieb](https://togithub.com/Nilstrieb) in [https://github.com/rust-lang/backtrace-rs/pull/602](https://togithub.com/rust-lang/backtrace-rs/pull/602) - Cut backtrace 0.3.71 by [@​workingjubilee](https://togithub.com/workingjubilee) in [https://github.com/rust-lang/backtrace-rs/pull/599](https://togithub.com/rust-lang/backtrace-rs/pull/599) ##### New Contributors - [@​jfgoog](https://togithub.com/jfgoog) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/592](https://togithub.com/rust-lang/backtrace-rs/pull/592) - [@​Nilstrieb](https://togithub.com/Nilstrieb) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/602](https://togithub.com/rust-lang/backtrace-rs/pull/602) **Full Changelog**: rust-lang/backtrace-rs@0.3.70...0.3.71 ### [`v0.3.70`](https://togithub.com/rust-lang/backtrace-rs/releases/tag/0.3.70) [Compare Source](https://togithub.com/rust-lang/backtrace-rs/compare/0.3.69...0.3.70) ##### New API - A `BacktraceFrame` can now have `resolve(&mut self)` called on it thanks to [@​fraillt](https://togithub.com/fraillt) in [https://github.com/rust-lang/backtrace-rs/pull/526](https://togithub.com/rust-lang/backtrace-rs/pull/526) ##### Platform Support We added support for new platforms in this release! - Thanks to [@​bzEq](https://togithub.com/bzEq) in [https://github.com/rust-lang/backtrace-rs/pull/508](https://togithub.com/rust-lang/backtrace-rs/pull/508) we now have AIX support! - Thanks to [@​sthibaul](https://togithub.com/sthibaul) in [https://github.com/rust-lang/backtrace-rs/pull/567](https://togithub.com/rust-lang/backtrace-rs/pull/567) we now have GNU/Hurd support! - Thanks to [@​dpaoliello](https://togithub.com/dpaoliello) in [https://github.com/rust-lang/backtrace-rs/pull/587](https://togithub.com/rust-lang/backtrace-rs/pull/587) we now support "emulation-compatible" AArch64 Windows (aka arm64ec) ##### Windows - Rewrite msvc backtrace support to be much faster on 64-bit platforms by [@​wesleywiser](https://togithub.com/wesleywiser) in [https://github.com/rust-lang/backtrace-rs/pull/569](https://togithub.com/rust-lang/backtrace-rs/pull/569) - Fix i686-pc-windows-gnu missing dbghelp module by [@​wesleywiser](https://togithub.com/wesleywiser) in [https://github.com/rust-lang/backtrace-rs/pull/571](https://togithub.com/rust-lang/backtrace-rs/pull/571) - Fix build errors on `thumbv7a-*-windows-msvc` targets by [@​kleisauke](https://togithub.com/kleisauke) in [https://github.com/rust-lang/backtrace-rs/pull/573](https://togithub.com/rust-lang/backtrace-rs/pull/573) - Fix panic in backtrace symbolication on win7 by [@​roblabla](https://togithub.com/roblabla) in [https://github.com/rust-lang/backtrace-rs/pull/578](https://togithub.com/rust-lang/backtrace-rs/pull/578) - remove few unused windows ffi fn by [@​klensy](https://togithub.com/klensy) in [https://github.com/rust-lang/backtrace-rs/pull/576](https://togithub.com/rust-lang/backtrace-rs/pull/576) - Make dbghelp look for PDBs next to their exe/dll. by [@​michaelwoerister](https://togithub.com/michaelwoerister) in [https://github.com/rust-lang/backtrace-rs/pull/584](https://togithub.com/rust-lang/backtrace-rs/pull/584) - Revert 32-bit dbghelp to a version WINE (presumably) likes by [@​ChrisDenton](https://togithub.com/ChrisDenton) in [https://github.com/rust-lang/backtrace-rs/pull/588](https://togithub.com/rust-lang/backtrace-rs/pull/588) - Update for Win10 by [@​ChrisDenton](https://togithub.com/ChrisDenton) in [https://github.com/rust-lang/backtrace-rs/pull/589](https://togithub.com/rust-lang/backtrace-rs/pull/589) ##### SGX Thanks to - Adjust frame IP in SGX relative to image base by [@​mzohreva](https://togithub.com/mzohreva) in [https://github.com/rust-lang/backtrace-rs/pull/566](https://togithub.com/rust-lang/backtrace-rs/pull/566) ##### Internals We did a bunch more work on our CI and internal cleanups - Modularise CI workflow and validate outputs for binary size checks. by [@​detly](https://togithub.com/detly) in [https://github.com/rust-lang/backtrace-rs/pull/549](https://togithub.com/rust-lang/backtrace-rs/pull/549) - Commit Cargo.lock by [@​bjorn3](https://togithub.com/bjorn3) in [https://github.com/rust-lang/backtrace-rs/pull/562](https://togithub.com/rust-lang/backtrace-rs/pull/562) - Enable calling build.rs externally v2 by [@​pitaj](https://togithub.com/pitaj) in [https://github.com/rust-lang/backtrace-rs/pull/568](https://togithub.com/rust-lang/backtrace-rs/pull/568) - Upgrade to 2021 ed and inline panics by [@​nyurik](https://togithub.com/nyurik) in [https://github.com/rust-lang/backtrace-rs/pull/538](https://togithub.com/rust-lang/backtrace-rs/pull/538) - Fix deny(unused) of an unused import with SGX Miri by [@​saethlin](https://togithub.com/saethlin) in [https://github.com/rust-lang/backtrace-rs/pull/581](https://togithub.com/rust-lang/backtrace-rs/pull/581) - Fix unused_imports warning on latest nightly by [@​ChrisDenton](https://togithub.com/ChrisDenton) in [https://github.com/rust-lang/backtrace-rs/pull/575](https://togithub.com/rust-lang/backtrace-rs/pull/575) - Fix CI by [@​saethlin](https://togithub.com/saethlin) in [https://github.com/rust-lang/backtrace-rs/pull/582](https://togithub.com/rust-lang/backtrace-rs/pull/582) - Use `addr_of!` by [@​GrigorenkoPV](https://togithub.com/GrigorenkoPV) in [https://github.com/rust-lang/backtrace-rs/pull/585](https://togithub.com/rust-lang/backtrace-rs/pull/585) - Write down MSRV policy by [@​workingjubilee](https://togithub.com/workingjubilee) in [https://github.com/rust-lang/backtrace-rs/pull/561](https://togithub.com/rust-lang/backtrace-rs/pull/561) - Apply clippy::uninlined_format_args fixes by [@​nyurik](https://togithub.com/nyurik) in [https://github.com/rust-lang/backtrace-rs/pull/486](https://togithub.com/rust-lang/backtrace-rs/pull/486) - ignore clippy lints in `symbolize/gimli/stash.rs` by [@​onur-ozkan](https://togithub.com/onur-ozkan) in [https://github.com/rust-lang/backtrace-rs/pull/586](https://togithub.com/rust-lang/backtrace-rs/pull/586) ##### New Contributors - [@​nyurik](https://togithub.com/nyurik) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/538](https://togithub.com/rust-lang/backtrace-rs/pull/538) - [@​bzEq](https://togithub.com/bzEq) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/508](https://togithub.com/rust-lang/backtrace-rs/pull/508) - [@​bjorn3](https://togithub.com/bjorn3) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/562](https://togithub.com/rust-lang/backtrace-rs/pull/562) - [@​sthibaul](https://togithub.com/sthibaul) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/567](https://togithub.com/rust-lang/backtrace-rs/pull/567) - [@​mzohreva](https://togithub.com/mzohreva) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/566](https://togithub.com/rust-lang/backtrace-rs/pull/566) - [@​wesleywiser](https://togithub.com/wesleywiser) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/569](https://togithub.com/rust-lang/backtrace-rs/pull/569) - [@​kleisauke](https://togithub.com/kleisauke) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/573](https://togithub.com/rust-lang/backtrace-rs/pull/573) - [@​roblabla](https://togithub.com/roblabla) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/578](https://togithub.com/rust-lang/backtrace-rs/pull/578) - [@​michaelwoerister](https://togithub.com/michaelwoerister) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/584](https://togithub.com/rust-lang/backtrace-rs/pull/584) - [@​dpaoliello](https://togithub.com/dpaoliello) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/587](https://togithub.com/rust-lang/backtrace-rs/pull/587) - [@​GrigorenkoPV](https://togithub.com/GrigorenkoPV) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/585](https://togithub.com/rust-lang/backtrace-rs/pull/585) - [@​fraillt](https://togithub.com/fraillt) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/526](https://togithub.com/rust-lang/backtrace-rs/pull/526) - [@​onur-ozkan](https://togithub.com/onur-ozkan) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/586](https://togithub.com/rust-lang/backtrace-rs/pull/586) **Full Changelog**: rust-lang/backtrace-rs@0.3.69...0.3.70 ### [`v0.3.69`](https://togithub.com/rust-lang/backtrace-rs/releases/tag/0.3.69) [Compare Source](https://togithub.com/rust-lang/backtrace-rs/compare/0.3.68...0.3.69) Thank you everyone for contributing to a very nice release! ##### Tracking Binary Size As backtrace-rs is compiled into every single Rust program, we have begun tracking its binary size in order to find ways to reduce its impact on programs that only minimally use backtraces over time. This change is mostly relevant to this crate's CI, and has been implemented by [@​Kobzol](https://togithub.com/Kobzol) and [@​detly](https://togithub.com/detly) over PRs [#​542](https://togithub.com/rust-lang/backtrace-rs/issues/542), [#​544](https://togithub.com/rust-lang/backtrace-rs/issues/544), [#​546](https://togithub.com/rust-lang/backtrace-rs/issues/546), and [#​550](https://togithub.com/rust-lang/backtrace-rs/issues/550)! ##### Platform-Specific Fixes As usual, the majority of PRs for this release only affect 1 or 2 platforms. Technically, even the binary-size tracking is only implemented to track binary size on `x86_64-unknown-linux-gnu`. ##### fuchsia Backtraces for Fuchsia will now uses extended symbolization thanks to [@​liudangyi](https://togithub.com/liudangyi) in [https://github.com/rust-lang/backtrace-rs/pull/559](https://togithub.com/rust-lang/backtrace-rs/pull/559) ##### unix (with `procfs`) Many Unix-y platforms support `/proc`, including Linux and FreeBSD, but not OpenBSD. For those which do, backtrace uses `/proc/self/maps` to assist in recovering the trace. We did not parse the output of `/proc/self/maps` in a way that accounted for the fact that it may have spaces in path names, but this was fixed thanks to [@​MasonRemaley](https://togithub.com/MasonRemaley) in [https://github.com/rust-lang/backtrace-rs/pull/553](https://togithub.com/rust-lang/backtrace-rs/pull/553) ##### windows-msvc Some changes that should help binary size specifically on Windows MSVC targets, or at least compile times, have already been implemented, thanks to [@​klensy](https://togithub.com/klensy) in [https://github.com/rust-lang/backtrace-rs/pull/543](https://togithub.com/rust-lang/backtrace-rs/pull/543) omitting compiling-in ELF backtrace capabilities. We don't have full binary size tracking for all major supported operating systems yet, so we believe this is worth 30KiB but that's more of an estimate than hard stats. ##### Dependency Management - Update addr2line and object dependencies by [@​philipc](https://togithub.com/philipc) in [https://github.com/rust-lang/backtrace-rs/pull/557](https://togithub.com/rust-lang/backtrace-rs/pull/557) - Exclude ci directory from packaged crate by [@​mulkieran](https://togithub.com/mulkieran) in [https://github.com/rust-lang/backtrace-rs/pull/555](https://togithub.com/rust-lang/backtrace-rs/pull/555) - Enable calling build.rs directly from std/build.rs by [@​pitaj](https://togithub.com/pitaj) in [https://github.com/rust-lang/backtrace-rs/pull/556](https://togithub.com/rust-lang/backtrace-rs/pull/556) ##### New Contributors - [@​Kobzol](https://togithub.com/Kobzol) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/542](https://togithub.com/rust-lang/backtrace-rs/pull/542) - [@​detly](https://togithub.com/detly) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/550](https://togithub.com/rust-lang/backtrace-rs/pull/550) - [@​liudangyi](https://togithub.com/liudangyi) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/559](https://togithub.com/rust-lang/backtrace-rs/pull/559) - [@​MasonRemaley](https://togithub.com/MasonRemaley) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/553](https://togithub.com/rust-lang/backtrace-rs/pull/553) - [@​mulkieran](https://togithub.com/mulkieran) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/555](https://togithub.com/rust-lang/backtrace-rs/pull/555) - [@​pitaj](https://togithub.com/pitaj) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/556](https://togithub.com/rust-lang/backtrace-rs/pull/556) - [@​klensy](https://togithub.com/klensy) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/543](https://togithub.com/rust-lang/backtrace-rs/pull/543) **Full Changelog**: rust-lang/backtrace-rs@0.3.68...0.3.69 ### [`v0.3.68`](https://togithub.com/rust-lang/backtrace-rs/releases/tag/0.3.68) [Compare Source](https://togithub.com/rust-lang/backtrace-rs/compare/0.3.67...0.3.68) A bunch of behind-the-scenes work on upgrading CI has finally got things to a place where we can do confident releases again, so hopefully the next backtrace version will not take 6 months! Thanks to everyone who contributed to that! Most of the user-facing changes are about dependency updates and consequent improved platform compatibility, including with split DWARF. A few new functions on BacktraceFmt should also make it easier to inject additional text into backtrace's output. - Adapt to new Fuchsia target name by [@​flba-eb](https://togithub.com/flba-eb) in [https://github.com/rust-lang/backtrace-rs/pull/509](https://togithub.com/rust-lang/backtrace-rs/pull/509) - armv7 PSVita OS support by [@​nikarh](https://togithub.com/nikarh) in [https://github.com/rust-lang/backtrace-rs/pull/523](https://togithub.com/rust-lang/backtrace-rs/pull/523) - Upgrade addr2line and properly handle split DWARF on Linux by [@​khuey](https://togithub.com/khuey) in [https://github.com/rust-lang/backtrace-rs/pull/513](https://togithub.com/rust-lang/backtrace-rs/pull/513) - deps: update miniz_oxide to 0.7 by [@​poliorcetics](https://togithub.com/poliorcetics) in [https://github.com/rust-lang/backtrace-rs/pull/521](https://togithub.com/rust-lang/backtrace-rs/pull/521) - Add print in BacktraceFmt by [@​chenyukang](https://togithub.com/chenyukang) in [https://github.com/rust-lang/backtrace-rs/pull/527](https://togithub.com/rust-lang/backtrace-rs/pull/527) - Bump object to 0.31 by [@​lnicola](https://togithub.com/lnicola) in [https://github.com/rust-lang/backtrace-rs/pull/522](https://togithub.com/rust-lang/backtrace-rs/pull/522) - Add an exception for QNX Neutrino 7.0 as a 'no-op' platform by [@​samkearney](https://togithub.com/samkearney) in [https://github.com/rust-lang/backtrace-rs/pull/529](https://togithub.com/rust-lang/backtrace-rs/pull/529) - Use mmap64 on Linux. by [@​mikebenfield](https://togithub.com/mikebenfield) in [https://github.com/rust-lang/backtrace-rs/pull/501](https://togithub.com/rust-lang/backtrace-rs/pull/501) - dbghlp: Make mutex name unique to the process by [@​ChrisDenton](https://togithub.com/ChrisDenton) in [https://github.com/rust-lang/backtrace-rs/pull/518](https://togithub.com/rust-lang/backtrace-rs/pull/518) - gimli add netbsd to handle dl_iterate_phdr as well. by [@​devnexen](https://togithub.com/devnexen) in [https://github.com/rust-lang/backtrace-rs/pull/512](https://togithub.com/rust-lang/backtrace-rs/pull/512) - Add other apple targets to libunwind workaround by [@​thomcc](https://togithub.com/thomcc) in [https://github.com/rust-lang/backtrace-rs/pull/516](https://togithub.com/rust-lang/backtrace-rs/pull/516) - Add fmt method for BacktraceFmt by [@​chenyukang](https://togithub.com/chenyukang) in [https://github.com/rust-lang/backtrace-rs/pull/532](https://togithub.com/rust-lang/backtrace-rs/pull/532) ##### New Contributors - [@​bwmf2](https://togithub.com/bwmf2) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/515](https://togithub.com/rust-lang/backtrace-rs/pull/515) - [@​flba-eb](https://togithub.com/flba-eb) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/509](https://togithub.com/rust-lang/backtrace-rs/pull/509) - [@​nikarh](https://togithub.com/nikarh) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/523](https://togithub.com/rust-lang/backtrace-rs/pull/523) - [@​poliorcetics](https://togithub.com/poliorcetics) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/521](https://togithub.com/rust-lang/backtrace-rs/pull/521) - [@​GuillaumeGomez](https://togithub.com/GuillaumeGomez) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/524](https://togithub.com/rust-lang/backtrace-rs/pull/524) - [@​chenyukang](https://togithub.com/chenyukang) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/527](https://togithub.com/rust-lang/backtrace-rs/pull/527) - [@​lnicola](https://togithub.com/lnicola) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/522](https://togithub.com/rust-lang/backtrace-rs/pull/522) - [@​samkearney](https://togithub.com/samkearney) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/529](https://togithub.com/rust-lang/backtrace-rs/pull/529) - [@​mikebenfield](https://togithub.com/mikebenfield) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/501](https://togithub.com/rust-lang/backtrace-rs/pull/501) - [@​devnexen](https://togithub.com/devnexen) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/512](https://togithub.com/rust-lang/backtrace-rs/pull/512) - [@​thomcc](https://togithub.com/thomcc) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/516](https://togithub.com/rust-lang/backtrace-rs/pull/516) - [@​workingjubilee](https://togithub.com/workingjubilee) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/533](https://togithub.com/rust-lang/backtrace-rs/pull/533) - [@​chriswailes](https://togithub.com/chriswailes) made their first contribution in [https://github.com/rust-lang/backtrace-rs/pull/534](https://togithub.com/rust-lang/backtrace-rs/pull/534) **Full Changelog**: rust-lang/backtrace-rs@0.3.67...0.3.68 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Nextjs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, pathnames were parsed from
/proc/pid/mapsusings.split(' '). This is incorrect, because pathnames may contain spaces.In practice, on the relevant operating systems, this resulted in truncation of pathnames containing spaces. This lead to a failure resolve any symbols or offsets, which in turn causes the stack trace to be printed containing only
<unknown>s to the end user.This PR corrects the parsing code, resolving the issue.