Fix lazy_static Usage
#260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables the `drop_types_in_const` nightly feature to re-allow the use of `lazy_static`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Due to RFC 1440, having types with destructors being used in static items and in const functions requires enabling the
drop_types_in_constfeature on nightly.Since we use the
lazy_static!macro to lazily create a static Regex, andlazy_staticusesUnsafeCellinternally, then as of rust-lang/rust/pull/33130, this change affects us. In the latest nightly versions, we require thedrop_types_in_constfeature to be enabled in order to compile.Solution
This PR enables the
drop_types_in_constfeature on nightly builds.Resources
Droptypes in statics (tracking issue for RFC #1440)