Fix rustls-webpki feature #1979
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusoto#1965 modified the initialization code for HttpClient in a way that prevents it from building with the `rustls-webpki` feature enabled. Fix that, so that building with rustls-webpki works again.
joshtriplett
force-pushed
the
fix-rustls-webpki
branch
from
e4902dc to
f5106ea
Compare
|
Is it possible to avoid the forwarding feature? The real maintenance cost of Rusoto is the several hours it takes for a script to build and publish the hundreds of service crates, and if I can get away with pushing only a new 0.48.1 for I assume you can reference rusoto_core directly in your Cargo.toml and it’ll do the right thing. |
|
Ah, you already dropped that commit in the time it took me to write that here :) |
iliana
approved these changes
Apr 26, 2022
|
Following up on this: would it be possible to get a Not time-sensitive, just wanted to check in and see if there's anything I could do to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1965 modified the initialization
code for HttpClient in a way that prevents it from building with the
rustls-webpkifeature enabled. Fix that, so that building withrustls-webpki works again.
Also, add a rustls-webpki forwarding feature for generated crates.
Would it be possible to get an 0.48.1 release with this change included? #1651 mentions 0.48 being the last release of rusoto; I'd really appreciate having this feature working in the final release.
Thank you so much to everyone who has worked on Rusoto!