Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add processor target_field trait #2026

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Add processor target_field trait #2026

merged 2 commits into from
Nov 24, 2021

Conversation

deguif
Copy link
Collaborator

@deguif deguif commented Nov 24, 2021

No description provided.

@deguif deguif self-assigned this Nov 24, 2021
ruflin
ruflin approved these changes Nov 24, 2021
View reviewed changes
Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all this cleanup. I especially like that it reduces the duplication and lines of code we have without impacting the users in any way.

Screenshot 2021-11-24 at 11 13 06

@deguif deguif merged commit cb28c9d into ruflin:master Nov 24, 2021
@deguif deguif deleted the processor-target-field-trait branch November 24, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@deguif deguif

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deguif @ruflin