Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node.trigger(:input) doesn't dispatch an input event #197

Open
janko opened this issue May 19, 2022 · 1 comment
Open

node.trigger(:input) doesn't dispatch an input event #197

janko opened this issue May 19, 2022 · 1 comment

Comments

@janko
Copy link

janko commented May 19, 2022 •
edited
Loading

From following the JavaScript code, I believe that node.trigger(:input) currently ends up calling this.dispatchEvent('input'). However, that isn't the correct way to dispatch this event, it should be this.dispatchEvent(new Event('input')).

That's presumably the reason why the Cuprite JavaScript class defines a special input() function, instead of calling trigger().

cuprite/lib/capybara/cuprite/javascripts/index.js

Lines 182 to 186 in 2bbf363

input(node) {
let event = document.createEvent("HTMLEvents");
event.initEvent("input", true, false);
node.dispatchEvent(event);
}

@jcoyne
Copy link

jcoyne commented Aug 18, 2022

Additionally, shouldn't this event have a property like: { inputType:"insertText" }?

jcoyne referenced this issue in sul-dlss/happy-heron Aug 18, 2022
@jcoyne
Switch from cuprite to selenium-webdriver for testing
04f8b53 
Cuprite doesn't have events that are implemented correctly.  See https://github.com/rubycdp/cuprite/issues/197\#issuecomment-1219911246
jcoyne referenced this issue in sul-dlss/happy-heron Aug 18, 2022
@jcoyne
Switch from cuprite to selenium-webdriver for testing
7c05a30 
Cuprite doesn't have events that are implemented correctly.  See https://github.com/rubycdp/cuprite/issues/197\#issuecomment-1219911246
peetucket referenced this issue in sul-dlss/happy-heron Jun 13, 2023
@jcoyne @peetucket
Switch from cuprite to selenium-webdriver for testing
339cac5 
Cuprite doesn't have events that are implemented correctly.  See https://github.com/rubycdp/cuprite/issues/197\#issuecomment-1219911246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcoyne @janko