Introduce and default to "minimal" crash report mode #9900
11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobu
reviewed
Feb 9, 2024
vm_dump.c
Outdated
| @@ -1107,6 1107,19 @@ rb_vm_bugreport(const void *ctx, FILE *errout) | |||
| } | |||
| } | |||
|
|
|||
| // Print a "minimal" crash report when errout is a TTY | |||
| int full_crash_report = !(isatty(fileno(errout))); | |||
There was a problem hiding this comment.
Suggested change
| int full_crash_report = !(isatty(fileno(errout))); | |
| bool full_crash_report = !(isatty(fileno(errout))); |
nobu
reviewed
Feb 9, 2024
vm_dump.c
Outdated
Comment on lines
1115
to
1120
| if (strcmp(ruby_full_crash_report_env, "0") == 0) { | ||
| full_crash_report = false; | ||
| } | ||
| else { | ||
| full_crash_report = true; | ||
| } |
There was a problem hiding this comment.
This makes RUBY_FULL_CRASH_REPORT= ruby crash.rb full dump.
I'd expect that empty value would disable the feature.
Suggested change
| if (strcmp(ruby_full_crash_report_env, "0") == 0) { | |
| full_crash_report = false; | |
| } | |
| else { | |
| full_crash_report = true; | |
| } | |
| full_crash_report = strtoul(ruby_full_crash_report_env, 0, 0) != 0; |
Or even:
Suggested change
| if (strcmp(ruby_full_crash_report_env, "0") == 0) { | |
| full_crash_report = false; | |
| } | |
| else { | |
| full_crash_report = true; | |
| } | |
| bool full_crash_report = ruby_full_crash_report_env ? | |
| strtoul(ruby_full_crash_report_env, 0, 0) != 0 : | |
| !isatty(fileno(errout)); |
There was a problem hiding this comment.
Thank you! I agree that RUBY_FULL_CRASH_REPORT= ruby crash.rb should disable the feature.
Fixed in 4a3ebd4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PoC for https://bugs.ruby-lang.org/issues/20249.