YJIT: Let RubyVM::YJIT.enable respect --yjit-stats #9415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XrXr
approved these changes
Jan 5, 2024
sorah
added a commit
to sorah-rbpkg/ruby
that referenced
this pull request
Jan 17, 2024
Backports the following patches which fixes critical or major issues: - ruby/ruby#9457 - ruby/ruby#9415 - https://bugs.ruby-lang.org/issues/20184 ruby/ruby#9498 - https://bugs.ruby-lang.org/issues/20085 ruby/ruby#9385
This was referenced Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of adding
RubyVM::YJIT.enable#8705, it respected--yjit-statsand it was the intended behavior. #9297 accidentally changed it to ignore--yjit-stats.This PR lets
RubyVM::YJIT.enable(nostatsoption) respect whether--yjit-statsis given or not. I also added a documentation aboutstatsoption.I'll request a backport to ruby_3_3 once merged.