Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YJIT: Mark and update stubs in invalidated blocks #9104

Merged
merged 1 commit into from
Dec 4, 2023
Merged

YJIT: Mark and update stubs in invalidated blocks #9104

merged 1 commit into from
Dec 4, 2023

Conversation

XrXr
Copy link
Member

@XrXr XrXr commented Dec 2, 2023 •
edited
Loading

Like in the example given in delayed_deallocation(), stubs can be hit
even if the block housing it is invalidated. Mark them so we don't
work with invalidate ISeqs when hitting these stubs.

Diff easier to parse if you append ?w=1 to the URL

@matzbot matzbot requested a review from a team December 2, 2023 00:28
@XrXr XrXr force-pushed the yjit-mark-dead-blocks branch 2 times, most recently from e75b4ce to d4308a8 Compare December 2, 2023 01:19
@XrXr
YJIT: Mark and update stubs in invalidated blocks
d4e06ec 
Like in the example given in delayed_deallocation(), stubs can be hit
even if the block housing it is invalidated. Mark them so we don't
work with invalidate ISeqs when hitting these stubs.
@maximecb maximecb merged commit b5a62eb into ruby:master Dec 4, 2023
97 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XrXr @maximecb