Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YJIT: record num_send_cfunc stat #9022

Merged
merged 2 commits into from
Nov 23, 2023
Merged

YJIT: record num_send_cfunc stat #9022

merged 2 commits into from
Nov 23, 2023

Conversation

maximecb
Copy link
Contributor

Also report num_send_known_cfunc as percentage of num_send_cfunc.

The results are interesting, for example for lobsters:

num_send:                 26,760,083
num_send_known_class:        582,989 ( 2.2%)
num_send_polymorphic:      3,753,785 (14.0%)
num_send_megamorphic:        254,507 ( 1.0%)
num_send_dynamic:            746,039 ( 2.8%)
num_send_inline:             238,076 ( 0.9%)
num_send_leaf_builtin:       283,907 ( 1.1%)
num_send_cfunc:            8,191,737 (30.6%)
num_send_known_cfunc:      3,679,959 (44.9%)

We can see that we're actually inlining a pretty big chunk of the total C function calls we're generating.

@maximecb
YJIT: record num_send_cfunc stat
7ed9afc 
Also report num_send_known_cfunc as percentage of num_send_cfunc
@matzbot matzbot requested a review from a team November 23, 2023 19:54
@maximecb
Rename num_send_known_cfunc => num_send_cfunc_inline
007d97f 
Name seems more descriptive of what we do with out custom codegen
@maximecb maximecb merged commit f05d586 into ruby:master Nov 23, 2023
98 checks passed
@maximecb maximecb deleted the yjit_send_stats branch November 23, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XrXr XrXr XrXr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximecb @XrXr