Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix round_half_even #7023

Merged
merged 1 commit into from
Dec 26, 2022
Merged

Fix round_half_even #7023

merged 1 commit into from
Dec 26, 2022

Conversation

mrkn
Copy link
Member

@mrkn mrkn commented Dec 26, 2022

No description provided.

@mrkn mrkn force-pushed the fix_round_half_even branch 2 times, most recently from c2300c8 to 61734e7 Compare December 26, 2022 03:31
@mrkn mrkn changed the title WIP: Fix round_half_even Fix round_half_even Dec 26, 2022
@mrkn mrkn requested a review from nobu December 26, 2022 03:53
@mrkn mrkn force-pushed the fix_round_half_even branch 4 times, most recently from d1ac6da to 14fd115 Compare December 26, 2022 05:11
Copy link
Member

@nobu nobu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert "spec/ruby/core/float/round_spec.rb" too.

Handle the integert and the float parts separately in round_half_even
to prevent error occursions in floating point calculation.
@mrkn
Copy link
Member Author

mrkn commented Dec 26, 2022

@nobu Done.

@mrkn mrkn merged commit 9f23789 into ruby:master Dec 26, 2022
@mrkn mrkn deleted the fix_round_half_even branch December 26, 2022 12:02
@eregon
Copy link
Member

eregon commented Jan 6, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants