Deduplicate results from getaddrinfo #11456
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain configurations it's possible to get duplicate results back
from getaddrinfo: for example, if you accidentally have more than one
line in /etc/hosts mapping the same name to the same IP address, then
Linux/glibc systems will return multiple identical entries. This minor
misconfiguration is normally harmless, but it caused this program to
fail with `EADDRINUSE`:
require 'socket'
Socket.tcp_server_sockets('localhost', 0)
Prior to ruby/net-http#180, this caused a number
of `TestNetHTTP*` tests to fail, as seen in these Debian bugs:
https://bugs.debian.org/1069399 (Ruby 3.1)
https://bugs.debian.org/1064685 (Ruby 3.2)
https://bugs.debian.org/1077462 (Ruby 3.3)
It's easy enough to deduplicate these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain configurations it's possible to get duplicate results back from getaddrinfo: for example, if you accidentally have more than one line in /etc/hosts mapping the same name to the same IP address, then Linux/glibc systems will return multiple identical entries. This minor misconfiguration is normally harmless, but it caused this program to fail with
EADDRINUSE:Prior to ruby/net-http#180, this caused a number of
TestNetHTTP*tests to fail, as seen in these Debian bugs:https://bugs.debian.org/1069399 (Ruby 3.1)
https://bugs.debian.org/1064685 (Ruby 3.2)
https://bugs.debian.org/1077462 (Ruby 3.3)
It's easy enough to deduplicate these.