Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ZLayer.fromMagic #7

Open
sideeffffect opened this issue Apr 3, 2021 · 3 comments
Open

Add support for ZLayer.fromMagic #7

sideeffffect opened this issue Apr 3, 2021 · 3 comments

Comments

@sideeffffect
Copy link

sideeffffect commented Apr 3, 2021 •
edited
Loading

It seems like it doesn't create comment with the diagram for ZLayer.fromMagic.
Otherwise love this Scalafix rule! ❤️
@rtimush
Copy link
Owner

rtimush commented Apr 3, 2021 •
edited
Loading

It should work for ZLayer.fromMagic, at least for simple cases (MethodsTest.scala#L58-L61). If you have a reproducer that you can share I will be happy to take a look. Otherwise, at the moment it's not easy to tell why the comment isn't created, but I will update the rule to print some diagnostic messages when it fails.

Otherwise love this Scalafix rule! ❤️

Thanks! :)

@sideeffffect
Copy link
Author

Here's where I did my experiment
https://github.com/Idealiste-cz/ideal-voting-backend/blob/26ce83a3aad7ebb56ae51d91f848af6e3e98b184/ideal-voting-server/src/main/scala/cz/idealiste/idealvoting/server/Main.scala#L13

@rtimush
Copy link
Owner

rtimush commented Apr 11, 2021

Thank you! I found the problem and will try to fix it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rtimush @sideeffffect