Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jquery #3969

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update jquery #3969

wants to merge 5 commits into from

Conversation

davidmacro
Copy link

I followed the steps as outlined in tools/updatejQuery.R to update jQuery to 3.7.1 (current latest stable) and jQuery Types to 3.5.29 (current latest stable). This ran without problems.

To be sure, I verified that:

  • Correct .js files were included in inst/www/shared folders (jquery.js, jquery.min.js, jquery.min.js.map)
  • yarn.lock and 'package.json'.file were updated accordingly
  • 'devtools::check()' ran and introduced no (new) issues.

Note: devtools::check() did give me an (unrelated) error in the tabPanel test. But this test also occurs in main/ at the moment. Looking at the diff, it appears to be that the generated html wraps a body tag around the code that is to be asserted.

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2024

CLA assistant check
All committers have signed the CLA.

@davidmacro davidmacro marked this pull request as draft January 21, 2024 22:16
@davidmacro
Copy link
Author

Link to issue #3968

@davidmacro davidmacro marked this pull request as ready for review January 21, 2024 22:18
@cpsievert cpsievert added this to the 1.9 milestone Mar 15, 2024
@cpsievert
Copy link
Collaborator

Thanks, if you could also update the NEWS.md, that'd be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants