Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve some Bootstrap UI docs and function reference #3551

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

cpsievert
Copy link
Collaborator

Probably best reviewed commit-by-commit

  • More clearly documents that fixedRow() and basicPage() are soft-deprecated and remove them from the function reference.
  • More clearly document the similarities and differences amongst fluidPage(), fixedPage(), and bootstrapPage() (now on the same page). Also, clarify their connection to fluidRow() and column().
  • Groom the function reference and break the UI sections into more sections

TODO:

  • Maybe it makes sense to add a note to other UI functions (e.g., wellPanel()) that implicitly assume Bootstrap is on the page?

@cpsievert cpsievert changed the title UI docs reference Improve some Bootstrap UI docs and function reference Nov 19, 2021
@cpsievert cpsievert requested a review from wch November 19, 2021 19:49
R/bootstrap-deprecated.R Outdated Show resolved Hide resolved
@cpsievert cpsievert marked this pull request as ready for review January 20, 2022 19:42
@cpsievert cpsievert mentioned this pull request Jun 14, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant