bootstrapLib() now always sets state on render and cleans up post static render #3402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
added a commit
to rstudio/bslib
that referenced
this pull request
May 24, 2021
… with handling bootstrapLib() state during static render)
cpsievert
added a commit
to rstudio/bslib
that referenced
this pull request
May 25, 2021
…314) * New nav() api providing legacy support for shiny's tabPanel() logic * wip doc improvements * Resave data (GitHub Action) * Document (GitHub Actions) * Various cleanup * More wip docs * Document (GitHub Actions) * Simplify static rendering logic (rstudio/shiny#3402 should fix issues with handling bootstrapLib() state during static render) * Document (GitHub Actions) * Make it more clear that functions reside in bslib * More doc improvements * Document (GitHub Actions) * Don't re-export appendTab()/prependTab() (we should consider them deprecated at this point) * Default target to NULL in insertTab() * Finish up * Document (GitHub Actions) * Fix Rd link * Update pkgdown reference Co-authored-by: cpsievert <[email protected]>
cpsievert
force-pushed
the
bootstrapLibPostRender
branch
from
bf62dba
to
14521b6
Compare
cpsievert
force-pushed
the
bootstrapLibPostRender
branch
from
e6c0dfe
to
3bb56d5
Compare
cpsievert
force-pushed
the
bootstrapLibPostRender
branch
from
3bb56d5
to
923c1b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3401. To be merged after rstudio/htmltools#267
TODO:
runtime: shiny